Support any channel types from Notification #743

lezzago · 2023-09-26T23:12:21Z

Description

Support any channel types from Notification

Issues Resolved

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

codecov · 2023-09-26T23:26:23Z

Codecov Report

Merging #743 (f92f42d) into main (30b3b71) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head f92f42d differs from pull request most recent head 10f590c. Consider uploading reports for the commit 10f590c to get more accurate results

@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
- Coverage   49.85%   49.84%   -0.01%     
==========================================
  Files         233      232       -1     
  Lines        6561     6558       -3     
  Branches      939      940       +1     
==========================================
- Hits         3271     3269       -2     
+ Misses       3287     3286       -1     
  Partials        3        3

see 5 files with indirect coverage changes

public/pages/CreateTrigger/containers/ConfigureActions/ConfigureActions.js

bowenlan-amzn · 2023-09-27T17:47:17Z

Why all the cypress tests are failing?

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

lezzago · 2023-09-27T23:43:23Z

Why all the cypress tests are failing?

The github CI looks like it needs to be updated. I have tested this locally against the functional test repo and all the CIs passed.

AWSHurneyt · 2023-10-02T19:59:47Z

public/services/NotificationService.ts

+      return response.allowed_config_type_list as Array<String>;
+    } catch (error) {
+      console.error('error fetching available features', error);
+      return null;


Are there any concerns with receiving a null pointer exception somewhere by returning null here? Would it be worthwhile to instead return []?

good point, that would be more robust.

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Support any channel types from Notification Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Remove unused CHANNEL_TYPES constant Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Return empty array if failed to get features Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 1c7239f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Support any channel types from Notification * Remove unused CHANNEL_TYPES constant * Return empty array if failed to get features --------- (cherry picked from commit 1c7239f) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Support any channel types from Notification Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Remove unused CHANNEL_TYPES constant Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Return empty array if failed to get features Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Support any channel types from Notification (#743) * Support any channel types from Notification Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Remove unused CHANNEL_TYPES constant Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Return empty array if failed to get features Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Drafted 2.11 release notes. (#764) * Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed "last updated by" sections from the UI. (#767) * Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated cypress workflow. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Onboard Jenkins prod docker image to github actions (#789) * Onboard Jenkins prod docker image to github actions Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Small typos Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add back workflows Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Restore macos/windows Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Bumped babel version. (#821) * Bumped babel version. Adjusted babel config. Refactored unit test that started failing after bump. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated yarn file. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fix fetching of channels for composite monitors (#820) * fixed incorrect use of this.props Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * resolved dependency conflict Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated babel config Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. (#828) * Amended 2.11.0 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed bucket monitor groupBy/aggregation display bug. (#827) * Fixed a bug that was causing groupBy/aggregation fields from displaying in various areas of the UI. Related issues: 816, 817, 818. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed trigger context object bug in issue 791. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Capitalized bucket column titles, and moved bucket columns to the end of the column array. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added wait steps to reduce test flakiness. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added wait step to reduce test flakiness. Adjusted test monitor trigger condition to always triggers on a healthy clusters. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed unused imports. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * fixed bucket level monitor flaky cypress test Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Issue #671 fix trigger name validation (#794) Signed-off-by: Chenxi Wang <wangchenxi.us@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Remove integtest.sh since it is not being used (#849) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * do not create Message component on every text change (#854) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented server API call to feature backend API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented remote cluster support for creating/editing query, bucket, and cluster metrics monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented warning model when monitor execution time exceeds a certain value. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated alert details flyout to show remote cluster info. Updated monitor details page to show data sources. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated unit tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added experimental banner. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Edited text on the experimental banner. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Moved getSettings call to hide Data source panel for cluster metrics monitors when remote monitoring is disabled. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Increased cypress test timeout. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: Chenxi Wang <wangchenxi.us@gmail.com> Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Chenxi Wang <56898616+wang-chenxi@users.noreply.github.com> Co-authored-by: Derek Ho <derek01778@gmail.com>

* Support any channel types from Notification (#743) * Support any channel types from Notification Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Remove unused CHANNEL_TYPES constant Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Return empty array if failed to get features Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Drafted 2.11 release notes. (#764) * Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed "last updated by" sections from the UI. (#767) * Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated cypress workflow. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Onboard Jenkins prod docker image to github actions (#789) * Onboard Jenkins prod docker image to github actions Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Small typos Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add back workflows Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Restore macos/windows Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Bumped babel version. (#821) * Bumped babel version. Adjusted babel config. Refactored unit test that started failing after bump. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated yarn file. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fix fetching of channels for composite monitors (#820) * fixed incorrect use of this.props Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * resolved dependency conflict Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated babel config Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. (#828) * Amended 2.11.0 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed bucket monitor groupBy/aggregation display bug. (#827) * Fixed a bug that was causing groupBy/aggregation fields from displaying in various areas of the UI. Related issues: 816, 817, 818. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed trigger context object bug in issue 791. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Capitalized bucket column titles, and moved bucket columns to the end of the column array. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added wait steps to reduce test flakiness. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added wait step to reduce test flakiness. Adjusted test monitor trigger condition to always triggers on a healthy clusters. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed unused imports. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * fixed bucket level monitor flaky cypress test Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Issue #671 fix trigger name validation (#794) Signed-off-by: Chenxi Wang <wangchenxi.us@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Remove integtest.sh since it is not being used (#849) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * do not create Message component on every text change (#854) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented server API call to feature backend API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented remote cluster support for creating/editing query, bucket, and cluster metrics monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented warning model when monitor execution time exceeds a certain value. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated alert details flyout to show remote cluster info. Updated monitor details page to show data sources. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated unit tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added experimental banner. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Edited text on the experimental banner. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Moved getSettings call to hide Data source panel for cluster metrics monitors when remote monitoring is disabled. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Increased cypress test timeout. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: Chenxi Wang <wangchenxi.us@gmail.com> Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Chenxi Wang <56898616+wang-chenxi@users.noreply.github.com> Co-authored-by: Derek Ho <derek01778@gmail.com> (cherry picked from commit fb82368) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Support any channel types from Notification (#743) * Support any channel types from Notification * Remove unused CHANNEL_TYPES constant * Return empty array if failed to get features --------- * Drafted 2.11 release notes. (#764) * Drafted 2.11 release notes. * Drafted 2.11 release notes. --------- * Removed "last updated by" sections from the UI. (#767) * Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info. * Updated cypress workflow. --------- * Onboard Jenkins prod docker image to github actions (#789) * Onboard Jenkins prod docker image to github actions * Small typos * Add back workflows * Restore macos/windows --------- * Bumped babel version. (#821) * Bumped babel version. Adjusted babel config. Refactored unit test that started failing after bump. * Updated yarn file. --------- * Fix fetching of channels for composite monitors (#820) * fixed incorrect use of this.props * resolved dependency conflict * updated babel config --------- * Added 2.11.1 release notes. (#828) * Amended 2.11.0 release notes. * Added 2.11.1 release notes. * Added 2.11.1 release notes. * Added 2.11.1 release notes. * Added 2.11.1 release notes. --------- * Fixed bucket monitor groupBy/aggregation display bug. (#827) * Fixed a bug that was causing groupBy/aggregation fields from displaying in various areas of the UI. Related issues: 816, 817, 818. * Fixed trigger context object bug in issue 791. * Capitalized bucket column titles, and moved bucket columns to the end of the column array. * Added wait steps to reduce test flakiness. * Added wait step to reduce test flakiness. Adjusted test monitor trigger condition to always triggers on a healthy clusters. * Removed unused imports. * fixed bucket level monitor flaky cypress test --------- * Issue #671 fix trigger name validation (#794) * Remove integtest.sh since it is not being used (#849) * do not create Message component on every text change (#854) * Implemented server API call to feature backend API. * Implemented remote cluster support for creating/editing query, bucket, and cluster metrics monitors. * Implemented warning model when monitor execution time exceeds a certain value. * Updated alert details flyout to show remote cluster info. Updated monitor details page to show data sources. * Updated unit tests. * Added experimental banner. * Updated snapshots. * Edited text on the experimental banner. * Moved getSettings call to hide Data source panel for cluster metrics monitors when remote monitoring is disabled. * Updated snapshots. * Increased cypress test timeout. --------- (cherry picked from commit fb82368) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: Chenxi Wang <wangchenxi.us@gmail.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Chenxi Wang <56898616+wang-chenxi@users.noreply.github.com> Co-authored-by: Derek Ho <derek01778@gmail.com>

Support any channel types from Notification

4326edf

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

lezzago requested review from AWSHurneyt, amsiglan, sbcd90, eirsep, getsaurabh02, praveensameneni, qreshi, bowenlan-amzn and rishabhmaurya as code owners September 26, 2023 23:12

bowenlan-amzn reviewed Sep 27, 2023

View reviewed changes

public/pages/CreateTrigger/containers/ConfigureActions/ConfigureActions.js Show resolved Hide resolved

Remove unused CHANNEL_TYPES constant

f92f42d

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

lezzago added the backport 2.x label Sep 27, 2023

bowenlan-amzn previously approved these changes Sep 27, 2023

View reviewed changes

AWSHurneyt reviewed Oct 2, 2023

View reviewed changes

Return empty array if failed to get features

10f590c

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

lezzago dismissed bowenlan-amzn’s stale review via 10f590c October 2, 2023 20:12

AWSHurneyt approved these changes Oct 2, 2023

View reviewed changes

bowenlan-amzn approved these changes Oct 2, 2023

View reviewed changes

lezzago merged commit 1c7239f into opensearch-project:main Oct 2, 2023
3 of 7 checks passed

opensearch-trigger-bot bot mentioned this pull request Oct 2, 2023

[Backport 2.x] Support any channel types from Notification #748

Merged

lezzago mentioned this pull request Oct 11, 2023

[BUG] Blank Page when Editing Monitor with SNS Integration #529

Closed

amsiglan mentioned this pull request Nov 18, 2023

Fix fetching of channels for composite monitors #820

Merged

5 tasks

Desvelao mentioned this pull request Aug 14, 2024

Alert Trigger Channel is not loading MS Teams as optional recipients wazuh/wazuh-dashboard-plugins#6783

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support any channel types from Notification #743

Support any channel types from Notification #743

lezzago commented Sep 26, 2023

codecov bot commented Sep 26, 2023 •

edited

Loading

bowenlan-amzn commented Sep 27, 2023

lezzago commented Sep 27, 2023

AWSHurneyt Oct 2, 2023 •

edited

Loading

lezzago Oct 2, 2023

Support any channel types from Notification #743

Support any channel types from Notification #743

Conversation

lezzago commented Sep 26, 2023

Description

Issues Resolved

Check List

codecov bot commented Sep 26, 2023 • edited Loading

Codecov Report

bowenlan-amzn commented Sep 27, 2023

lezzago commented Sep 27, 2023

AWSHurneyt Oct 2, 2023 • edited Loading

Choose a reason for hiding this comment

lezzago Oct 2, 2023

Choose a reason for hiding this comment

codecov bot commented Sep 26, 2023 •

edited

Loading

AWSHurneyt Oct 2, 2023 •

edited

Loading