[Backport 2.x] Implemented cross-cluster monitors. #872
+1,313
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Support any channel types from Notification (#743) * Support any channel types from Notification Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Remove unused CHANNEL_TYPES constant Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Return empty array if failed to get features Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Drafted 2.11 release notes. (#764) * Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed "last updated by" sections from the UI. (#767) * Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated cypress workflow. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Onboard Jenkins prod docker image to github actions (#789) * Onboard Jenkins prod docker image to github actions Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Small typos Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add back workflows Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Restore macos/windows Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Bumped babel version. (#821) * Bumped babel version. Adjusted babel config. Refactored unit test that started failing after bump. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated yarn file. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fix fetching of channels for composite monitors (#820) * fixed incorrect use of this.props Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * resolved dependency conflict Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated babel config Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. (#828) * Amended 2.11.0 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed bucket monitor groupBy/aggregation display bug. (#827) * Fixed a bug that was causing groupBy/aggregation fields from displaying in various areas of the UI. Related issues: 816, 817, 818. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed trigger context object bug in issue 791. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Capitalized bucket column titles, and moved bucket columns to the end of the column array. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added wait steps to reduce test flakiness. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added wait step to reduce test flakiness. Adjusted test monitor trigger condition to always triggers on a healthy clusters. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed unused imports. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * fixed bucket level monitor flaky cypress test Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Issue #671 fix trigger name validation (#794) Signed-off-by: Chenxi Wang <wangchenxi.us@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Remove integtest.sh since it is not being used (#849) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * do not create Message component on every text change (#854) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented server API call to feature backend API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented remote cluster support for creating/editing query, bucket, and cluster metrics monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented warning model when monitor execution time exceeds a certain value. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated alert details flyout to show remote cluster info. Updated monitor details page to show data sources. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated unit tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added experimental banner. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Edited text on the experimental banner. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Moved getSettings call to hide Data source panel for cluster metrics monitors when remote monitoring is disabled. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Increased cypress test timeout. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: Chenxi Wang <wangchenxi.us@gmail.com> Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Chenxi Wang <56898616+wang-chenxi@users.noreply.github.com> Co-authored-by: Derek Ho <derek01778@gmail.com> (cherry picked from commit fb82368) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #872 +/- ##
==========================================
- Coverage 49.80% 48.74% -1.06%
==========================================
Files 232 236 +4
Lines 6565 6839 +274
Branches 939 995 +56
==========================================
+ Hits 3270 3334 +64
- Misses 3292 3502 +210
Partials 3 3 ☔ View full report in Codecov by Sentry. |
|
As mentioned in the original PR, the cluster metrics cypress tests pass locally. |
AWSHurneyt
approved these changes
Feb 6, 2024
|
Ran all the cypress tests locally again just to make sure. All passed. |
amsiglan
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport fb82368 from #871.