Implemented support for ClusterMetrics monitors #221

AWSHurneyt · 2021-11-02T17:27:04Z

Issue #, if available:

Description of changes:

Implemented support for a new monitor input method that takes in URI components to allow monitoring based on responses from API calls to the local cluster.

CheckList:
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

core/src/main/kotlin/org/opensearch/alerting/core/model/LocalUriInput.kt

alerting/src/main/kotlin/org/opensearch/alerting/settings/SupportedApiSettings.kt

alerting/src/test/kotlin/org/opensearch/alerting/MonitorRunnerIT.kt

lezzago · 2021-11-02T21:16:07Z

core/build.gradle

@@ -37,6 +37,7 @@ dependencies {
    compile "org.opensearch.client:opensearch-rest-client:${opensearch_version}"
    compile 'com.google.googlejavaformat:google-java-format:1.10.0'
    compile "org.opensearch:common-utils:${common_utils_version}"
+    compile 'commons-validator:commons-validator:1.7'


This will be moved to alerting if we move the LocalUriInput class to alerting from core

core/src/main/kotlin/org/opensearch/alerting/core/model/LocalUriInput.kt

codecov-commenter · 2021-11-03T17:10:18Z

Codecov Report

Merging #221 (230bad2) into cluster-metrics-monitor-dev (5f18a5c) will decrease coverage by 0.14%.
The diff coverage is 75.09%.

@@                        Coverage Diff                        @@
##             cluster-metrics-monitor-dev     #221      +/-   ##
=================================================================
- Coverage                          78.59%   78.44%   -0.15%     
- Complexity                           218      276      +58     
=================================================================
  Files                                173      176       +3     
  Lines                               6975     7233     +258     
  Branches                             916      963      +47     
=================================================================
+ Hits                                5482     5674     +192     
- Misses                              1005     1058      +53     
- Partials                             488      501      +13

Impacted Files	Coverage Δ
...ensearch/alerting/settings/SupportedApiSettings.kt	`29.62% <29.62%> (ø)`
...ch/alerting/util/SupportedApiSettingsExtensions.kt	`32.69% <32.69%> (ø)`
...ain/kotlin/org/opensearch/alerting/InputService.kt	`88.57% <75.00%> (+0.69%)`	⬆️
...in/kotlin/org/opensearch/alerting/model/Monitor.kt	`88.67% <85.71%> (-0.29%)`	⬇️
...nsearch/alerting/core/model/ClusterMetricsInput.kt	`94.67% <94.67%> (ø)`
...n/kotlin/org/opensearch/alerting/AlertingPlugin.kt	`94.73% <100.00%> (+0.03%)`	⬆️
...ing/model/destination/DestinationContextFactory.kt	`66.66% <0.00%> (-3.71%)`	⬇️
.../kotlin/org/opensearch/alerting/core/JobSweeper.kt	`71.50% <0.00%> (-0.50%)`	⬇️
...ain/kotlin/org/opensearch/alerting/AlertService.kt	`78.53% <0.00%> (-0.49%)`	⬇️
.../alerting/transport/TransportIndexMonitorAction.kt	`59.52% <0.00%> (+0.47%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f18a5c...230bad2. Read the comment docs.

core/src/main/kotlin/org/opensearch/alerting/core/model/LocalUriInput.kt

qreshi · 2021-11-04T00:05:14Z

alerting/src/main/kotlin/org/opensearch/alerting/util/SupportedApiSettingsExtensions.kt

+    return when {
+        supportedJsonPayload.isEmpty() -> mappedActionResponse
+        else -> {
+            val output = hashMapOf<String, Any>()
+            for ((key, value) in supportedJsonPayload) {
+                when (val mappedValue = mappedActionResponse[key]) {
+                    is Map<*, *> -> output[key] = XContentMapValues.filter(
+                        mappedActionResponse[key] as MutableMap<String, *>?,
+                        value.toTypedArray(), arrayOf()
+                    )
+                    else -> output[key] = mappedValue ?: hashMapOf<String, Any>()
+                }
+            }
+            output
+        }
+    }


A few possible concerns with this format I see:

We are using supported_json_payloads.json to retrieve the allowed keys. This implies that whatever is explicitly mentioned is what is supported, however, if the map in the json is empty ({}) we allow everything through even though that would imply that nothing is supported.

Do we support redaction of a nested map of allowed keys for more complex responses (assuming the result is not flattened)?

These are good points.

I can see how this could be a bit confusing. For this use case, not including the API in the JSON would be the best way to redact everything from its response. This will be something we want to explain well in the documentation.

If I'm understanding this point correctly, yes. The test redactFieldsFromResponse with non-empty supportedJsonPayload test case examines that functionality.

qreshi · 2021-11-04T00:21:19Z

core/src/test/kotlin/org/opensearch/alerting/core/model/LocalUriInputTests.kt

+                testCount++
+            }
+        assertEquals(LocalUriInput.ApiType.values().size, testCount)


NP: Up to you but you can exclude the count assertion since if all the assertEquals in the forEach pass then we should be good and if any of them fail, the test will fail anyway.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

…ricsInput. Added Cluster Metrics as a new monitor type to align with frontend experience. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

…ests accordingly. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

…caluri-debug

alerting/src/main/kotlin/org/opensearch/alerting/settings/SupportedApiSettings.kt

alerting/src/main/kotlin/org/opensearch/alerting/util/SupportedApiSettingsExtensions.kt

core/src/main/kotlin/org/opensearch/alerting/core/model/ClusterMetricsInput.kt

AWSHurneyt · 2022-03-08T23:33:29Z

As a side note, the integration tests pass locally. The security test workflow check seems to currently be failing due to the issue tracked in issue #300.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

…ries API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

core/src/main/kotlin/org/opensearch/alerting/core/model/ClusterMetricsInput.kt

rishabhmaurya · 2022-03-10T18:49:52Z

core/src/main/kotlin/org/opensearch/alerting/core/model/ClusterMetricsInput.kt

+        const val MIN_SOCKET_TIMEOUT = 1
+        const val MAX_SOCKET_TIMEOUT = 60
+
+        const val SUPPORTED_SCHEME = "http"


HttpClient is no more being used in your approach, better clean up fields not required in your approach.

Created this issue to track this feedback #341

rishabhmaurya · 2022-03-10T18:50:08Z

core/src/main/kotlin/org/opensearch/alerting/core/model/ClusterMetricsInput.kt

+
+        const val SUPPORTED_SCHEME = "http"
+        const val SUPPORTED_HOST = "localhost"
+        const val SUPPORTED_PORT = 9200


same as above.

Created this issue to track this feedback #341

rishabhmaurya · 2022-03-10T19:52:11Z

alerting/src/main/kotlin/org/opensearch/alerting/settings/SupportedClusterMetricsSettings.kt

+                    val pathParamsArray = pathParams.split(",").toTypedArray()
+                    return ClusterStatsRequest(*pathParamsArray)
+                }
+                ClusterMetricType.NODES_STATS -> NodesStatsRequest().addMetrics(


this is good for now, but ideally, we want to give control to choose what metrics or in general params they would want to pass. Let's add a todo task here.

Created this issue to track this feedback #341

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

rishabhmaurya · 2022-03-10T20:18:07Z

core/src/main/kotlin/org/opensearch/alerting/core/model/ClusterMetricsInput.kt

+    /**
+     * An enum class to quickly reference various supported API.
+     */
+    enum class ClusterMetricType(


This logic can be replaced with regex validations and in future releases we may want to keep it more generic so that if path requires some placeholders, users can configure them without changing code. For e.g. node stats api supports adding node id or cluster metric name as part of url path.

Created this issue to track this feedback #341

rishabhmaurya · 2022-03-10T20:29:29Z

What testing have we done for FGAC related use-cases? It would be great if you can add integ tests for such cases.

AWSHurneyt · 2022-03-10T22:36:30Z

What testing have we done for FGAC related use-cases? It would be great if you can add integ tests for such cases.

Created this issue to track this feedback #341

Manual testing involved creating a user with all permissions except cluster:monitor permissions. This prevents that user from running API like GET /_cluster/heath. The Preview query button for a ClusterMetrics monitor defined by that user fails to execute. In addition, execution of the monitor results in alerts with the following error

Error: Failed fetching inputs: OpenSearchSecurityException[no permissions for [cluster:monitor/health] and associated roles [noClusterApi, own_index]]

Also, I created a user without access to the opensearch_dashboards_sample_data_ecommerce index. Attempting to preview the response for a /_cluster/heath/opensearch_dashboards_sample_data_ecommerce monitor returns the same information as if that user ran GET /_cluster/heath/opensearch_dashboards_sample_data_ecommerce through DevTools. Attempts for that user to preview the response for _cat/recovery/opensearch_dashboards_sample_data_ecommerce fail to execute, and attempts to create the monitor display a popup error that says

[alerting_exception] User doesn't have read permissions for one or more configured index []

* Implemented support for LocalUriInput monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored feature naming convention from LocalUriInput to ClusterMetricsInput. Added Cluster Metrics as a new monitor type to align with frontend experience. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented randomClusterMetricsMonitor test helper, and refactored tests accordingly. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Renamed some assets to align with the new name for this feature. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored cluster metrics feature to remove support for Cat repositories API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored supported JSON payload to return all response fields. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removing unused connectionTimeout and socketTimeout params. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

…) (opensearch-project#342) * Implemented support for LocalUriInput monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored feature naming convention from LocalUriInput to ClusterMetricsInput. Added Cluster Metrics as a new monitor type to align with frontend experience. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented randomClusterMetricsMonitor test helper, and refactored tests accordingly. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Renamed some assets to align with the new name for this feature. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored cluster metrics feature to remove support for Cat repositories API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored supported JSON payload to return all response fields. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removing unused connectionTimeout and socketTimeout params. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added support for JDK 8 and 14. (#335) * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 1.3 release notes. (#336) * Added 1.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 1.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Add backport and auto delete workflow (#339) Signed-off-by: Annie Lee <leeyun@amazon.com> * Implemented support for ClusterMetrics monitors (#221) (#342) * Implemented support for LocalUriInput monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored feature naming convention from LocalUriInput to ClusterMetricsInput. Added Cluster Metrics as a new monitor type to align with frontend experience. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented randomClusterMetricsMonitor test helper, and refactored tests accordingly. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Renamed some assets to align with the new name for this feature. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored cluster metrics feature to remove support for Cat repositories API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored supported JSON payload to return all response fields. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removing unused connectionTimeout and socketTimeout params. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added cluster metrics monitor to release notes. (#343) * Added 1.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 1.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added cluster metrics monitor to release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated DEVELOPER_GUIDE.md and workflows to reference changes to the supported JDKs. (#338) * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added additional release note. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated workflows to build using JDK 11. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removing redundant JDK setup step. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed guide wording. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed guide wording. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Reverted bwc workflow JDK. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Annie Lee <leeyun@amazon.com>

…roject#345) * Added support for JDK 8 and 14. (opensearch-project#335) * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 1.3 release notes. (opensearch-project#336) * Added 1.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 1.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Add backport and auto delete workflow (opensearch-project#339) Signed-off-by: Annie Lee <leeyun@amazon.com> * Implemented support for ClusterMetrics monitors (opensearch-project#221) (opensearch-project#342) * Implemented support for LocalUriInput monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored feature naming convention from LocalUriInput to ClusterMetricsInput. Added Cluster Metrics as a new monitor type to align with frontend experience. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented randomClusterMetricsMonitor test helper, and refactored tests accordingly. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Renamed some assets to align with the new name for this feature. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored cluster metrics feature to remove support for Cat repositories API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored supported JSON payload to return all response fields. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removing unused connectionTimeout and socketTimeout params. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added cluster metrics monitor to release notes. (opensearch-project#343) * Added 1.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 1.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added cluster metrics monitor to release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated DEVELOPER_GUIDE.md and workflows to reference changes to the supported JDKs. (opensearch-project#338) * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added additional release note. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated workflows to build using JDK 11. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removing redundant JDK setup step. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed guide wording. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed guide wording. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Reverted bwc workflow JDK. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Annie Lee <leeyun@amazon.com>

* Add 1.2.4.0 release notes (#282) * Add 1.2.4.0 release notes Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * Commented out flaky test in favor of known issue to unblock build (#331) (#332) (#333) * Commented out flaky test in favor of known issue #300 to unblock build process. Signed-off-by: Saurabh Singh <sisurab@amazon.com> * Commenting out another test Signed-off-by: Aditya Jindal <aditjind@amazon.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Aditya Jindal <aditjind@amazon.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Aditya Jindal <13850971+aditjind@users.noreply.github.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Aditya Jindal <13850971+aditjind@users.noreply.github.com> * Cherry-picking commits for 1.3 release from main to 1.x (#345) * Added support for JDK 8 and 14. (#335) * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 1.3 release notes. (#336) * Added 1.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 1.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Add backport and auto delete workflow (#339) Signed-off-by: Annie Lee <leeyun@amazon.com> * Implemented support for ClusterMetrics monitors (#221) (#342) * Implemented support for LocalUriInput monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored feature naming convention from LocalUriInput to ClusterMetricsInput. Added Cluster Metrics as a new monitor type to align with frontend experience. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented randomClusterMetricsMonitor test helper, and refactored tests accordingly. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Renamed some assets to align with the new name for this feature. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored cluster metrics feature to remove support for Cat repositories API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored supported JSON payload to return all response fields. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removing unused connectionTimeout and socketTimeout params. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added cluster metrics monitor to release notes. (#343) * Added 1.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 1.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added cluster metrics monitor to release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated DEVELOPER_GUIDE.md and workflows to reference changes to the supported JDKs. (#338) * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added additional release note. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated workflows to build using JDK 11. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removing redundant JDK setup step. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed guide wording. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed guide wording. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Reverted bwc workflow JDK. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Annie Lee <leeyun@amazon.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com> Co-authored-by: Saurabh Singh <sisurab@amazon.com> Co-authored-by: Aditya Jindal <13850971+aditjind@users.noreply.github.com> Co-authored-by: Annie Lee <leeyun@amazon.com>

…roject#345) * Added support for JDK 8 and 14. (opensearch-project#335) * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 1.3 release notes. (opensearch-project#336) * Added 1.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 1.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Add backport and auto delete workflow (opensearch-project#339) Signed-off-by: Annie Lee <leeyun@amazon.com> * Implemented support for ClusterMetrics monitors (opensearch-project#221) (opensearch-project#342) * Implemented support for LocalUriInput monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored feature naming convention from LocalUriInput to ClusterMetricsInput. Added Cluster Metrics as a new monitor type to align with frontend experience. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented randomClusterMetricsMonitor test helper, and refactored tests accordingly. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Renamed some assets to align with the new name for this feature. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored cluster metrics feature to remove support for Cat repositories API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored supported JSON payload to return all response fields. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored nodes stats request object to return all metrics. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removing unused connectionTimeout and socketTimeout params. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added cluster metrics monitor to release notes. (opensearch-project#343) * Added 1.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 1.3 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added cluster metrics monitor to release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated DEVELOPER_GUIDE.md and workflows to reference changes to the supported JDKs. (opensearch-project#338) * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added support for JDK 8 and 14. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added additional release note. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated DEVELOPER_GUIDE.md to reference changes to the supported JDKs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated workflows to build using JDK 11. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removing redundant JDK setup step. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed guide wording. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed guide wording. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Reverted bwc workflow JDK. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Annie Lee <leeyun@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

AWSHurneyt requested review from lezzago, qreshi, skkosuri-amzn and annie3431 November 2, 2021 17:27

lezzago reviewed Nov 2, 2021

View reviewed changes

qreshi reviewed Nov 4, 2021

View reviewed changes

Supsource approved these changes Nov 12, 2021

View reviewed changes

qreshi mentioned this pull request Nov 18, 2021

Create shared parent class for HttpInputClient and DestinationHttpClient #44

Closed

AWSHurneyt requested a review from a team November 19, 2021 23:16

AWSHurneyt changed the base branch from main to local-uri-input-dev December 22, 2021 00:49

AWSHurneyt closed this Dec 22, 2021

AWSHurneyt deleted the localuri branch December 22, 2021 00:50

AWSHurneyt restored the localuri branch December 22, 2021 00:50

AWSHurneyt reopened this Dec 22, 2021

AWSHurneyt force-pushed the localuri branch from 0520147 to 2ccaf08 Compare December 22, 2021 00:52

Supsource approved these changes Dec 22, 2021

View reviewed changes

Implemented support for LocalUriInput monitors.

25bd579

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

AWSHurneyt force-pushed the localuri branch from cf86c33 to 25bd579 Compare February 10, 2022 18:09

AWSHurneyt added 4 commits March 1, 2022 23:55

Refactored feature naming convention from LocalUriInput to ClusterMet…

675c9e4

…ricsInput. Added Cluster Metrics as a new monitor type to align with frontend experience. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Fixed ktlint errors.

3439d33

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Implemented randomClusterMetricsMonitor test helper, and refactored t…

13b616f

…ests accordingly. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Merge branch 'main' of github.com:opensearch-project/alerting into lo…

230bad2

…caluri-debug

AWSHurneyt changed the base branch from local-uri-input-dev to cluster-metrics-monitor-dev March 7, 2022 09:19

AWSHurneyt changed the title ~~Implemented support for LocalUriInput monitors~~ Implemented support for ClusterMetrics monitors Mar 7, 2022

lezzago reviewed Mar 8, 2022

View reviewed changes

Renamed some assets to align with the new name for this feature.

525c5fc

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

lezzago approved these changes Mar 9, 2022

View reviewed changes

AWSHurneyt added the v1.3.0 label Mar 9, 2022

AWSHurneyt added 4 commits March 9, 2022 23:56

Refactored cluster metrics feature to remove support for Cat reposito…

d27f6ab

…ries API. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Refactored supported JSON payload to return all response fields.

1a82d0f

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Refactored nodes stats request object to return all metrics.

cf0c7ba

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Refactored nodes stats request object to return all metrics.

e6bc12d

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

rishabhmaurya reviewed Mar 10, 2022

View reviewed changes

Removing unused connectionTimeout and socketTimeout params.

61002d8

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

rishabhmaurya reviewed Mar 10, 2022

View reviewed changes

Merge branch 'opensearch-project:main' into localuri

8b986c0

AWSHurneyt mentioned this pull request Mar 10, 2022

ClusterMetrics monitors enhancements #341

Open

4 tasks

rishabhmaurya approved these changes Mar 10, 2022

View reviewed changes

AWSHurneyt merged commit 688e11d into opensearch-project:cluster-metrics-monitor-dev Mar 10, 2022

tlfeng mentioned this pull request Mar 18, 2022

Add HTTP Input type for monitors (Inherited from PR #82) opendistro-for-elasticsearch/alerting#347

Closed

AWSHurneyt mentioned this pull request Mar 28, 2023

Implemented support for ClusterMetrics monitors (#221) #342

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented support for ClusterMetrics monitors #221

Implemented support for ClusterMetrics monitors #221

AWSHurneyt commented Nov 2, 2021

lezzago Nov 2, 2021

codecov-commenter commented Nov 3, 2021 •

edited

Loading

qreshi Nov 4, 2021

AWSHurneyt Mar 9, 2022

qreshi Nov 4, 2021

AWSHurneyt commented Mar 8, 2022

rishabhmaurya Mar 10, 2022

AWSHurneyt Mar 10, 2022

rishabhmaurya Mar 10, 2022

AWSHurneyt Mar 10, 2022

rishabhmaurya Mar 10, 2022

AWSHurneyt Mar 10, 2022

rishabhmaurya Mar 10, 2022

AWSHurneyt Mar 10, 2022

rishabhmaurya commented Mar 10, 2022

AWSHurneyt commented Mar 10, 2022 •

edited

Loading

Implemented support for ClusterMetrics monitors #221

Implemented support for ClusterMetrics monitors #221

Conversation

AWSHurneyt commented Nov 2, 2021

Choose a reason for hiding this comment

codecov-commenter commented Nov 3, 2021 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AWSHurneyt commented Mar 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rishabhmaurya commented Mar 10, 2022

AWSHurneyt commented Mar 10, 2022 • edited Loading

codecov-commenter commented Nov 3, 2021 •

edited

Loading

AWSHurneyt commented Mar 10, 2022 •

edited

Loading