Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented support for ClusterMetrics monitors #221
Implemented support for ClusterMetrics monitors #221
Changes from 5 commits
25bd579
675c9e4
3439d33
13b616f
230bad2
525c5fc
d27f6ab
1a82d0f
cf0c7ba
e6bc12d
61002d8
8b986c0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few possible concerns with this format I see:
supported_json_payloads.json
to retrieve the allowed keys. This implies that whatever is explicitly mentioned is what is supported, however, if the map in the json is empty ({}
) we allow everything through even though that would imply that nothing is supported.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are good points.
test redactFieldsFromResponse with non-empty supportedJsonPayload
test case examines that functionality.