Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for build version qualifiers #334. #353

Conversation

naveenpajjuri
Copy link
Contributor

Signed-off-by: Naveen Pajjuri nppajjur@amazon.com

Description

Support for build version qualifier.

Issues Resolved

#334

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Naveen Pajjuri <nppajjur@amazon.com>
@naveenpajjuri naveenpajjuri requested a review from a team April 5, 2022 11:01
@@ -37,6 +37,7 @@ buildscript {
// Taken from https://github.com/opensearch-project/alerting/blob/main/build.gradle#L33
// 1.0.0 -> 1.0.0.0, and 1.0.0-SNAPSHOT -> 1.0.0.0-SNAPSHOT
opensearch_build = opensearch_version.replaceAll(/(\.\d)([^\d]*)$/, '$1.0$2')
buildVersionQualifier = System.getProperty("build.version_qualifier")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to these changes for qualifier.
https://github.com/opensearch-project/security/pull/1738/files

Thanks.

@saikaranam-amazon
Copy link
Member

@naveenpajjuri Could you rebase with main to pick latest changes?

@naveenpajjuri
Copy link
Contributor Author

Closing this PR as @saikaranam-amazon is already taking care of this in #358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants