Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added security CI workflow and OS build qualifier #358

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Added security CI workflow and OS build qualifier #358

merged 1 commit into from
Apr 7, 2022

Conversation

saikaranam-amazon
Copy link
Member

@saikaranam-amazon saikaranam-amazon commented Apr 6, 2022 •
edited
Loading

Signed-off-by: Sai Kumar karanas@amazon.com

Description

Added security CI workflow and OS build qualifier

Issues Resolved

#354

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022 •
edited
Loading

Codecov Report

Merging #358 (e9fb4e2) into main (d51e43c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head e9fb4e2 differs from pull request most recent head 8705307. Consider uploading reports for the commit 8705307 to get more accurate results

@@             Coverage Diff              @@
##               main     #358      +/-   ##
============================================
- Coverage     10.92%   10.91%   -0.01%     
  Complexity      111      111              
============================================
  Files           141      141              
  Lines          4559     4554       -5     
  Branches        506      504       -2     
============================================
- Hits            498      497       -1     
+ Misses         3991     3986       -5     
- Partials         70       71       +1
Impacted Files Coverage Δ
...cation/action/changes/TransportGetChangesAction.kt 0.00% <0.00%> (ø)
...tion/action/replay/TransportReplayChangesAction.kt 0.00% <0.00%> (ø)
...ication/metadata/store/ReplicationMetadataStore.kt 24.44% <0.00%> (ø)
...on/repository/RemoteClusterRestoreLeaderService.kt 0.00% <0.00%> (ø)
...pensearch/replication/repository/RestoreContext.kt 0.00% <0.00%> (ø)
.../replication/seqno/RemoteClusterTranslogService.kt 0.00% <0.00%> (ø)
...ndex/translog/ReplicationTranslogDeletionPolicy.kt 37.70% <0.00%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d51e43c...8705307. Read the comment docs.

dblock
dblock reviewed Apr 6, 2022
View reviewed changes
.github/workflows/security-tests.yml
working-directory: ./security
run: |
./gradlew clean build -Dbuild.snapshot=false -x test
cp build/distributions/opensearch-security-*.zip ../src/test/resources/security/plugin/opensearch-security.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do open an issue to replace this build with using a maven snapshot of security and link it back to opensearch-project/opensearch-build#716.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracked here: #274

@naveenpajjuri naveenpajjuri mentioned this pull request Apr 6, 2022
Closed
5 tasks
peterzhuamazon
peterzhuamazon requested changes Apr 6, 2022
View reviewed changes
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build.gradle 83-86 should change to
version = "${opensearch_build}"

@peterzhuamazon peterzhuamazon mentioned this pull request Apr 6, 2022
Closed
24 tasks
@naveenpajjuri naveenpajjuri mentioned this pull request Apr 7, 2022
Closed
@saikaranam-amazon
Added security CI workflow and OS build qualifier
2a80e4f 
Signed-off-by: Sai Kumar <karanas@amazon.com>
@saikaranam-amazon
Copy link
Member Author

build.gradle 83-86 should change to
version = "${opensearch_build}"

Done

@saikaranam-amazon saikaranam-amazon marked this pull request as ready for review April 7, 2022 16:04
@saikaranam-amazon saikaranam-amazon requested a review from a team April 7, 2022 16:04
ankitkala
ankitkala approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@ankitkala ankitkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@saikaranam-amazon saikaranam-amazon merged commit 4f790d2 into opensearch-project:main Apr 7, 2022
@ankitkala ankitkala mentioned this pull request May 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock left review comments

@peterzhuamazon peterzhuamazon peterzhuamazon approved these changes

@naveenpajjuri naveenpajjuri naveenpajjuri approved these changes

@ankitkala ankitkala ankitkala approved these changes

Assignees
No one assigned
Labels
v2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@saikaranam-amazon @codecov-commenter @dblock @ankitkala @naveenpajjuri @peterzhuamazon