Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for windows & mac build #591

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Add support for windows & mac build #591

merged 1 commit into from
Oct 26, 2022

Conversation

ankitkala
Copy link
Member

@ankitkala ankitkala commented Oct 17, 2022

Signed-off-by: Ankit Kala ankikala@amazon.com

Description

Added CI workflow for windows and macOS build.

Issues Resolved

219
220

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ankitkala ankitkala requested a review from a team October 17, 2022 15:31
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Merging #591 (47d5e4d) into main (33571ca) will increase coverage by 0.21%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #591      +/-   ##
============================================
+ Coverage     74.34%   74.55%   +0.21%     
- Complexity     1003     1006       +3     
============================================
  Files           141      141              
  Lines          4595     4595              
  Branches        506      506              
============================================
+ Hits           3416     3426      +10     
+ Misses          860      851       -9     
+ Partials        319      318       -1     
Impacted Files Coverage Δ
...cation/action/changes/TransportGetChangesAction.kt 63.49% <0.00%> (-20.64%) ⬇️
...rch/replication/task/index/IndexReplicationTask.kt 70.87% <0.00%> (ø)
...rch/replication/action/status/ShardInfoResponse.kt 91.59% <0.00%> (+19.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Ankit Kala <ankikala@amazon.com>
@ankitkala ankitkala merged commit d12271a into opensearch-project:main Oct 26, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 26, 2022
Signed-off-by: Ankit Kala <ankikala@amazon.com>

Signed-off-by: Ankit Kala <ankikala@amazon.com>
(cherry picked from commit d12271a)
ankitkala added a commit that referenced this pull request Oct 26, 2022
Signed-off-by: Ankit Kala <ankikala@amazon.com>

Signed-off-by: Ankit Kala <ankikala@amazon.com>
(cherry picked from commit d12271a)

Co-authored-by: Ankit Kala <ankikala@amazon.com>
@opensearch-trigger-bot
Copy link

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-591-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d12271a2909f32cf766d2405f7b1d3b8b1746c44
# Push it to GitHub
git push --set-upstream origin backport/backport-591-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-591-to-1.3.

@opensearch-trigger-bot
Copy link

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-591-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d12271a2909f32cf766d2405f7b1d3b8b1746c44
# Push it to GitHub
git push --set-upstream origin backport/backport-591-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-591-to-1.x.

ankitkala added a commit that referenced this pull request Dec 5, 2022
Signed-off-by: Ankit Kala <ankikala@amazon.com>

Signed-off-by: Ankit Kala <ankikala@amazon.com>
(cherry picked from commit d12271a)
ankitkala added a commit that referenced this pull request Dec 5, 2022
Signed-off-by: Ankit Kala <ankikala@amazon.com>

Signed-off-by: Ankit Kala <ankikala@amazon.com>
(cherry picked from commit d12271a)
ankitkala added a commit that referenced this pull request Dec 5, 2022
Signed-off-by: Ankit Kala <ankikala@amazon.com>

Signed-off-by: Ankit Kala <ankikala@amazon.com>
(cherry picked from commit d12271a)
ankitkala added a commit that referenced this pull request Dec 5, 2022
Signed-off-by: Ankit Kala <ankikala@amazon.com>

Signed-off-by: Ankit Kala <ankikala@amazon.com>
(cherry picked from commit d12271a)
@ankitkala ankitkala deleted the windows branch April 5, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants