Use smaller and compressed varients of buttons and form components #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
|
Thanks @AMoo-Miki, can we also update the components in unit tests? They are failing in the CI. |
Signed-off-by: Miki <miki@amazon.com>
6 tasks
VijayanB
approved these changes
Aug 5, 2024
martin-gaievski
approved these changes
Aug 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 5, 2024
) * Use EuiSmallButton Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 7e742dc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace instances of
EuiButtonthat don't have an explicit sizing attribute toEuiSmallButton*.Replace instances of
Eui<form elements>that don't have density attributes toEuiCompressed<form elements>.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.