Use new header to maps listing page #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junqiu-lei
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda and
martin-gaievski
as code owners
6 tasks
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei
force-pushed
the
trineo-listing-1
branch
from
feccc20
to
0fab5fa
Compare
junqiu-lei
changed the title
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
|
The header changes look good. Just in case it is not on your radar, the page body also needs updating to use whole width of the page. |
Just offline synced up with @AMoo-Miki, there is hardcoded width restriction in |
VijayanB
approved these changes
Aug 12, 2024
heemin32
approved these changes
Aug 12, 2024
junqiu-lei
merged commit 370e5dd
into
opensearch-project:feature/new-header
8 of 11 checks passed
junqiu-lei
added a commit
to junqiu-lei/dashboards-maps
that referenced
this pull request
Aug 16, 2024
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the changes to apply new header to maps listing page when turn on
home:useNewHomePagein advanced setting.The code change in maps-dashboards plugin mainly is moving
Create mapbutton from table to header by usingHeaderControlprovided from OSD header collective branch navigation component.This PR is target to
feature/new-headerbranch, since above OSD code change isn't available in main branch yet. Will add integ test after this PR and OSD feature code is merged to main.Screenshot
When turn off
home:useNewHomePage(by default)When turn on
home:useNewHomePageIssues Resolved
Part of #649
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.