Conditionally use the new Application Header variant on the Maps visualization page #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junqiu-lei
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda and
martin-gaievski
as code owners
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
AMoo-Miki
reviewed
Aug 13, 2024
AMoo-Miki
approved these changes
Aug 13, 2024
Co-authored-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei
changed the title
heemin32
approved these changes
Aug 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/new-header #654 +/- ##
=====================================================
Coverage ? 43.41%
=====================================================
Files ? 53
Lines ? 1785
Branches ? 331
=====================================================
Hits ? 775
Misses ? 973
Partials ? 37 ☔ View full report in Codecov by Sentry. |
martin-gaievski
approved these changes
Aug 13, 2024
junqiu-lei
merged commit ecd477a
into
opensearch-project:feature/new-header
11 of 13 checks passed
6 tasks
junqiu-lei
added a commit
to junqiu-lei/dashboards-maps
that referenced
this pull request
Aug 16, 2024
…alization page (opensearch-project#654) Signed-off-by: Junqiu Lei <junqiu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR apply the new header UI in Maps visualization page when
home:useNewHomePageis enabled.Will add integ tests for new header UI in separate PR.
Screenshot
When
home:useNewHomePageis NOT enabled(Default)When
home:useNewHomePageis enabledIssues Resolved
Part of #649
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.