Conditionally use full width for Maps listing page table #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junqiu-lei
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda and
martin-gaievski
as code owners
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei
force-pushed
the
full-width-listing-table
branch
from
7c428e8
to
f2996ad
Compare
6 tasks
AMoo-Miki
approved these changes
Aug 16, 2024
heemin32
approved these changes
Aug 16, 2024
martin-gaievski
approved these changes
Aug 16, 2024
junqiu-lei
merged commit ff3c045
into
opensearch-project:feature/new-header
9 of 11 checks passed
junqiu-lei
added a commit
to junqiu-lei/dashboards-maps
that referenced
this pull request
Aug 16, 2024
…project#655) Signed-off-by: Junqiu Lei <junqiu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since opensearch-project/OpenSearch-Dashboards#7691 merged(thanks @AMoo-Miki), this PR allows conditionally use full width for Maps listing page table when new home page UI is enabled.
Screenshot
When new home page UI is NOT enabled(default)
When new home page UI is enabled
Issues Resolved
Part of #649
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.