Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI on Node.js v18 #56

Merged
merged 2 commits into from
May 31, 2023
Merged

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented May 31, 2023

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #56 (70e5b00) into main (5e2ccf9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   86.54%   86.54%           
=======================================
  Files          51       51           
  Lines        1479     1479           
  Branches      352      352           
=======================================
  Hits         1280     1280           
  Misses        196      196           
  Partials        3        3           
Flag Coverage Δ
dashboards-notifications 86.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@SuZhou-Joe
Copy link
Member Author

#45

@xluo-aws xluo-aws merged commit 6d576e4 into opensearch-project:main May 31, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-56-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6d576e46c425fb2eef5eca6686ed4957fcb6378e
# Push it to GitHub
git push --set-upstream origin backport/backport-56-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-56-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.8 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.8 2.8
# Navigate to the new working tree
cd .worktrees/backport-2.8
# Create a new branch
git switch --create backport/backport-56-to-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6d576e46c425fb2eef5eca6686ed4957fcb6378e
# Push it to GitHub
git push --set-upstream origin backport/backport-56-to-2.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.8

Then, create a pull request where the base branch is 2.8 and the compare/head branch is backport/backport-56-to-2.8.

SuZhou-Joe added a commit to SuZhou-Joe/dashboards-notifications that referenced this pull request May 31, 2023
* Fix CI on Node.js v18

Signed-off-by: suzhou <suzhou@amazon.com>

* feat: update release notes

Signed-off-by: suzhou <suzhou@amazon.com>

---------

Signed-off-by: suzhou <suzhou@amazon.com>
(cherry picked from commit 6d576e4)
SuZhou-Joe added a commit to SuZhou-Joe/dashboards-notifications that referenced this pull request May 31, 2023
* Fix CI on Node.js v18

Signed-off-by: suzhou <suzhou@amazon.com>

* feat: update release notes

Signed-off-by: suzhou <suzhou@amazon.com>

---------

Signed-off-by: suzhou <suzhou@amazon.com>
(cherry picked from commit 6d576e4)
Hailong-am pushed a commit that referenced this pull request May 31, 2023
* Fix CI on Node.js v18

Signed-off-by: suzhou <suzhou@amazon.com>

* feat: update release notes

Signed-off-by: suzhou <suzhou@amazon.com>

---------

Signed-off-by: suzhou <suzhou@amazon.com>
(cherry picked from commit 6d576e4)
SuZhou-Joe added a commit that referenced this pull request May 31, 2023
* Fix CI on Node.js v18

Signed-off-by: suzhou <suzhou@amazon.com>

* feat: update release notes

Signed-off-by: suzhou <suzhou@amazon.com>

---------

Signed-off-by: suzhou <suzhou@amazon.com>
(cherry picked from commit 6d576e4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants