Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update CI to see error logs #316

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

SuZhou-Joe
Copy link
Member

Description

Describe what this change achieves.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@SuZhou-Joe SuZhou-Joe marked this pull request as draft October 6, 2023 03:35
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #316 (9aaa8df) into main (7d062c5) will decrease coverage by 2.88%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
- Coverage   89.95%   87.08%   -2.88%     
==========================================
  Files          16       16              
  Lines         209      209              
  Branches       43       43              
==========================================
- Hits          188      182       -6     
- Misses         20       26       +6     
  Partials        1        1              
Flag Coverage Δ
dashboards-search-relevance 87.08% <ø> (-2.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...search_components/search_configs/search_config.tsx 80.00% <ø> (ø)

... and 1 file with indirect coverage changes

@noCharger
Copy link
Collaborator

@SuZhou-Joe Could you sign-off on the commmit msg?

@mingshl
Copy link
Collaborator

mingshl commented Oct 10, 2023

here are some tips to fix DCO

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
Copy link
Member Author

Hi @noCharger , the DCO issue has been fixed.

@noCharger
Copy link
Collaborator

noCharger commented Oct 11, 2023

I searched around this fix in opensearch-project and find two PRs opensearch-project/index-management-dashboards-plugin#785 and opensearch-project/dashboards-notifications#56. Both of them are part of Node.js v18 Compatibility Test campaign (opensearch-project/dashboards-notifications#45 and opensearch-project/index-management-dashboards-plugin#746). Looks like it's a miss from #202

@noCharger noCharger merged commit 1c3f19d into opensearch-project:main Oct 11, 2023
12 checks passed
@noCharger noCharger added 2.x 2.x branch backport 2.x and removed 2.x 2.x branch labels Oct 11, 2023
github-actions bot added a commit that referenced this pull request Oct 11, 2023
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 1c3f19d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 11, 2023
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 1c3f19d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger pushed a commit that referenced this pull request Oct 11, 2023
(cherry picked from commit 1c3f19d)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger pushed a commit that referenced this pull request Oct 11, 2023
(cherry picked from commit 1c3f19d)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants