Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Update searchbar snapshots according to upstream changes #116

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 87f51b1 from #115.

Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit 87f51b1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #116 (ac15fac) into 2.x (ca47e3c) will not change coverage.
Report is 13 commits behind head on 2.x.
The diff coverage is n/a.

❗ Current head ac15fac differs from pull request most recent head 27783bd. Consider uploading reports for the commit 27783bd to get more accurate results

@@           Coverage Diff           @@
##              2.x     #116   +/-   ##
=======================================
  Coverage   62.76%   62.76%           
=======================================
  Files          10       10           
  Lines         658      658           
  Branches      119      119           
=======================================
  Hits          413      413           
  Misses        192      192           
  Partials       53       53           
Flag Coverage Δ
dashboards-query-workbench 62.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@derek-ho
Copy link
Collaborator

derek-ho commented Sep 5, 2023

Dont merge this yet - opensearch-project/OpenSearch-Dashboards#4897, backport failed - need to fix test and build workflow

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
@derek-ho derek-ho merged commit 35948be into 2.x Sep 7, 2023
9 checks passed
@derek-ho derek-ho deleted the backport/backport-115-to-2.x branch September 7, 2023 15:23
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023
…es (#116)

* Update searchbar snapshots according to upstream changes (#115)

Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit 87f51b1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix the test and build workflow file

Signed-off-by: Derek Ho <dxho@amazon.com>

* change ref from OSD to OS

Signed-off-by: Derek Ho <dxho@amazon.com>

---------

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit 35948be)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
pjfitzgibbons pushed a commit that referenced this pull request Sep 8, 2023
…o upstream changes (#119)

* [Backport 2.x] Update searchbar snapshots according to upstream changes (#116)

* Update searchbar snapshots according to upstream changes (#115)

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Derek Ho <dxho@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants