Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.10] [Backport 2.x] Update searchbar snapshots according to upstream changes #119

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 35948be from #116.

…es (#116)

* Update searchbar snapshots according to upstream changes (#115)

Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit 87f51b1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix the test and build workflow file

Signed-off-by: Derek Ho <dxho@amazon.com>

* change ref from OSD to OS

Signed-off-by: Derek Ho <dxho@amazon.com>

---------

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit 35948be)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ps48
Copy link
Member

ps48 commented Sep 7, 2023

@derek-ho If we are planning to merge this in 2.10 will have to update the release notes.

Signed-off-by: Derek Ho <dxho@amazon.com>
@derek-ho
Copy link
Collaborator

derek-ho commented Sep 7, 2023

@ps48 added here: 0a26f3b

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (2.10@c21b14a). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             2.10     #119   +/-   ##
=======================================
  Coverage        ?   62.76%           
=======================================
  Files           ?       10           
  Lines           ?      658           
  Branches        ?      119           
=======================================
  Hits            ?      413           
  Misses          ?      192           
  Partials        ?       53           
Flag Coverage Δ
dashboards-query-workbench 62.76% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📢 Have feedback on the report? Share it here.

@pjfitzgibbons pjfitzgibbons merged commit f373dec into 2.10 Sep 8, 2023
8 checks passed
@pjfitzgibbons pjfitzgibbons deleted the backport/backport-116-to-2.10 branch September 8, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants