[Backport 2.x] UI fixes for loading state, empty tree, added toast for error, fixed no indicies error #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…no indicies error (#176) * sample query button Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added toasts for failure cases Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added changes for error loading message, fixed initial loading screen, added badge for no indicies Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * ui changes to curb sidebar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added fix for error from async query Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated snapshots Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added changes for for mocking toasts, changed table test Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * pr requested changes Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix main.tsx tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 015cab8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand and
anirudha
as code owners
ps48
approved these changes
Oct 25, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #177 +/- ##
==========================================
+ Coverage 54.79% 58.21% +3.42%
==========================================
Files 33 33
Lines 1356 1546 +190
Branches 210 270 +60
==========================================
+ Hits 743 900 +157
- Misses 535 622 +87
+ Partials 78 24 -54
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 015cab8 from #176.