UI fixes for loading state, empty tree, added toast for error, fixed no indicies error #176

sumukhswamy · 2023-10-24T23:57:28Z

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

…, added badge for no indicies Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

ps48 · 2023-10-25T00:16:45Z

public/components/SQLPage/table_view.tsx

    <>
-      <EuiFlexGroup>
+      <>


Do we need double fragments?

removed the double fragments

ps48 · 2023-10-25T00:17:21Z

public/components/SQLPage/table_view.tsx

+                icon={<EuiIcon type="database" size="m" />}
+                iconColor="subdued"


Should the banner change on error from the backend?

this is for the initial databases loading, when error comes there is a text saying Error fetching data as we discussed on call

ps48 · 2023-10-25T00:19:16Z

public/components/Main/main.tsx

                }}
              >
-                <EuiFlexGroup direction="column">
-                  <EuiFlexItem>
+                <EuiFlexItem grow={false}>


Is this flex item needed here? I don't see it part of any flex group

ps48 · 2023-10-25T00:21:33Z

public/components/PPLPage/PPLPage.tsx

+            <EuiFlexItem
+              grow={false}
+              onClick={() =>
+                this.props.updatePPLQueries('source = <datasource>.<database>.<table> | head 10')


Should move the query to common/constants

moved query to constants

ps48 · 2023-10-25T00:22:11Z

common/utils/async_query_helpers.ts

@@ -50,14 +50,15 @@ export const pollQueryStatus = (id: string, http: CoreStart['http'], callback) =
        callback({ status: status });
        setTimeout(() => pollQueryStatus(id, http, callback), POLL_INTERVAL_MS);
      } else if (status === 'failed') {
-        callback({ status: 'FAILED', results: [] });
+        const results = res.data.resp;
+        callback({ status: 'FAILED', error: results.error });


Have we tested the acceleration flyout with the function change here?

not able to test anything, right now

ps48 · 2023-10-25T00:24:10Z

@paulstn @sumukhswamy Can you please update the tests?

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

codecov · 2023-10-25T03:47:23Z

Codecov Report

Merging #176 (a47f644) into main (a5aa2d2) will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
- Coverage   58.39%   58.21%   -0.18%     
==========================================
  Files          32       33       +1     
  Lines        1507     1546      +39     
  Branches      260      270      +10     
==========================================
+ Hits          880      900      +20     
- Misses        605      622      +17     
- Partials       22       24       +2

Flag	Coverage Δ
dashboards-query-workbench	`58.21% <ø> (-0.18%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

…no indicies error (#176) * sample query button Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added toasts for failure cases Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added changes for error loading message, fixed initial loading screen, added badge for no indicies Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * ui changes to curb sidebar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added fix for error from async query Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated snapshots Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added changes for for mocking toasts, changed table test Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * pr requested changes Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix main.tsx tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 015cab8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…no indicies error (#176) (#178) * sample query button * added toasts for failure cases * added changes for error loading message, fixed initial loading screen, added badge for no indicies * ui changes to curb sidebar * added fix for error from async query * updated snapshots * added changes for for mocking toasts, changed table test * pr requested changes * fix main.tsx tests --------- (cherry picked from commit 015cab8) Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>

…no indicies error (#176) (#177) * sample query button * added toasts for failure cases * added changes for error loading message, fixed initial loading screen, added badge for no indicies * ui changes to curb sidebar * added fix for error from async query * updated snapshots * added changes for for mocking toasts, changed table test * pr requested changes * fix main.tsx tests --------- (cherry picked from commit 015cab8) Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>

…, fixed no indicies error (opensearch-project#176) (opensearch-project#178)" This reverts commit 3c47d47.

…, fixed no indicies error (opensearch-project#176) (opensearch-project#178)" This reverts commit 3c47d47. Signed-off-by: Eric <menwe@amazon.com>

* Revert "Fix error handling for user w/o proper permissions (#195) (#197)" This reverts commit 26ed0dc. Signed-off-by: Eric <menwe@amazon.com> * Revert "Increment version to 2.11.1.0 (#186)" This reverts commit b18f5f4. Signed-off-by: Eric <menwe@amazon.com> * Revert "added fix for loading spinner issue for other database (#189) (#192)" This reverts commit 94805c5. Signed-off-by: Eric <menwe@amazon.com> * Revert "UI-bug fixes, added create query for MV (#182) (#188)" This reverts commit 4187b6d. Signed-off-by: Eric <menwe@amazon.com> * Revert "Add backticks and remove ckpt for manual refresh in acceleration flyout (#183) (#185)" This reverts commit f96c5d9. Signed-off-by: Eric <menwe@amazon.com> * Revert "Session update, minor fixes for acceleration flyout (#179) (#181)" This reverts commit 257fb53. Signed-off-by: Eric <menwe@amazon.com> * Revert "UI fixes for loading state, empty tree, added toast for error, fixed no indicies error (#176) (#178)" This reverts commit 3c47d47. Signed-off-by: Eric <menwe@amazon.com> * Revert "Make checkpoint mandatory, add watermark delay, minor UI fixes (#173) (#175)" This reverts commit 0198fa7. Signed-off-by: Eric <menwe@amazon.com> * Revert "design changes for loading, changed the banner, updated tests (#170) (#172)" This reverts commit 786c7c7. Signed-off-by: Eric <menwe@amazon.com> * Revert "Support dark mode and session for sql, minor bug fixes (#165) (#169)" This reverts commit 0f5673a. Signed-off-by: Eric <menwe@amazon.com> * Revert "Added changes for making tree view persistent, made changes for bugs for loading screen (#153) (#167)" This reverts commit 2269d1d. Signed-off-by: Eric <menwe@amazon.com> * Revert "fixed create table async query bug (#158) (#163)" This reverts commit 1964008. Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com>

paulstn and others added 5 commits October 24, 2023 14:15

sample query button

589951b

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

added toasts for failure cases

2e184ce

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

added changes for error loading message, fixed initial loading screen…

5efe351

…, added badge for no indicies Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

ui changes to curb sidebar

beb860e

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

added fix for error from async query

3017d31

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

sumukhswamy requested review from pjfitzgibbons, ps48, kavithacm, derek-ho, joshuali925, dai-chen, YANG-DB, rupal-bq, mengweieric, vamsi-amazon, Swiddis, penghuo, seankao-az, MaxKsyunz, Yury-Fridlyand and anirudha as code owners October 24, 2023 23:57

Merge branch 'main' into ui-fixes

f83de12

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

ps48 reviewed Oct 25, 2023

View reviewed changes

paulstn and others added 2 commits October 24, 2023 17:32

updated snapshots

4f37950

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

added changes for for mocking toasts, changed table test

ff41b4c

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

paulstn and others added 2 commits October 24, 2023 18:49

pr requested changes

a2a756c

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

fix main.tsx tests

a47f644

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

ps48 approved these changes Oct 25, 2023

View reviewed changes

mengweieric approved these changes Oct 25, 2023

View reviewed changes

ps48 added backport 2.x backport 2.11 labels Oct 25, 2023

ps48 merged commit 015cab8 into opensearch-project:main Oct 25, 2023
10 of 11 checks passed

opensearch-trigger-bot bot mentioned this pull request Oct 25, 2023

[Backport 2.x] UI fixes for loading state, empty tree, added toast for error, fixed no indicies error #177

Merged

opensearch-trigger-bot bot mentioned this pull request Oct 25, 2023

[Backport 2.11] UI fixes for loading state, empty tree, added toast for error, fixed no indicies error #178

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI fixes for loading state, empty tree, added toast for error, fixed no indicies error #176

UI fixes for loading state, empty tree, added toast for error, fixed no indicies error #176

sumukhswamy commented Oct 24, 2023

ps48 Oct 25, 2023

paulstn Oct 25, 2023

ps48 Oct 25, 2023

sumukhswamy Oct 25, 2023

ps48 Oct 25, 2023

paulstn Oct 25, 2023

ps48 Oct 25, 2023

paulstn Oct 25, 2023

ps48 Oct 25, 2023

sumukhswamy Oct 25, 2023

ps48 commented Oct 25, 2023

codecov bot commented Oct 25, 2023

		icon={<EuiIcon type="database" size="m" />}
		iconColor="subdued"

UI fixes for loading state, empty tree, added toast for error, fixed no indicies error #176

UI fixes for loading state, empty tree, added toast for error, fixed no indicies error #176

Conversation

sumukhswamy commented Oct 24, 2023

Description

Issues Resolved

Check List

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ps48 commented Oct 25, 2023

codecov bot commented Oct 25, 2023

Codecov Report