Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added fix for loading spinner issue for other database #189

Merged
merged 4 commits into from
Oct 30, 2023
Merged

added fix for loading spinner issue for other database #189

merged 4 commits into from
Oct 30, 2023

Conversation

sumukhswamy
Copy link
Collaborator

@sumukhswamy sumukhswamy commented Oct 27, 2023 •
edited by ps48

Description

Fixed multiple toast for database
added fix for other database click
moved code to functions to reduce the repetition

Issues Resolved

#190

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sumukhswamy
added fix for loading spinner issue
793366d 
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited

Codecov Report

Merging #189 (f4b6c56) into main (be457f6) will increase coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   52.82%   53.02%   +0.19%     
==========================================
  Files          33       33              
  Lines        1628     1622       -6     
  Branches      292      289       -3     
==========================================
  Hits          860      860              
+ Misses        679      673       -6     
  Partials       89       89
Flag Coverage Δ
dashboards-query-workbench 53.02% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@ps48
fix oui scroll issue
1fa6076 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48 ps48 mentioned this pull request Oct 30, 2023
Closed
@sumukhswamy
added button next to the table for query to be added
d799af7 
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
@sumukhswamy
icon changed for wuery loader
f4b6c56 
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
@ps48 ps48 merged commit 5a956ba into opensearch-project:main Oct 30, 2023
11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 30, 2023
@github-actions @ps48
added fix for loading spinner issue for other database (#189)
d6506ad 
* added fix for loading spinner issue

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* fix oui scroll issue

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* added button next to the table for query to be added

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* icon changed for wuery loader

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

---------

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 5a956ba)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 30, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 30, 2023
@github-actions @ps48
added fix for loading spinner issue for other database (#189)
82788c3 
* added fix for loading spinner issue

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* fix oui scroll issue

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* added button next to the table for query to be added

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* icon changed for wuery loader

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

---------

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 5a956ba)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 30, 2023
Merged
ps48 added a commit that referenced this pull request Oct 30, 2023
@opensearch-trigger-bot @github-actions @ps48
added fix for loading spinner issue for other database (#189) (#192)
94805c5 
* added fix for loading spinner issue



* fix oui scroll issue



* added button next to the table for query to be added



* icon changed for wuery loader



---------




(cherry picked from commit 5a956ba)

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
ps48 added a commit that referenced this pull request Oct 30, 2023
@opensearch-trigger-bot @github-actions @ps48
added fix for loading spinner issue for other database (#189) (#191)
09cc788 
* added fix for loading spinner issue



* fix oui scroll issue



* added button next to the table for query to be added



* icon changed for wuery loader



---------




(cherry picked from commit 5a956ba)

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
mengweieric added a commit to mengweieric/dashboards-query-workbench that referenced this pull request Nov 8, 2023
@mengweieric
Revert "added fix for loading spinner issue for other database (opens…
a89dd29 
…earch-project#189) (opensearch-project#192)"

This reverts commit 94805c5.
mengweieric added a commit to mengweieric/dashboards-query-workbench that referenced this pull request Nov 8, 2023
@mengweieric
Revert "added fix for loading spinner issue for other database (opens…
dd4f2cd 
…earch-project#189) (opensearch-project#192)"

This reverts commit 94805c5.

Signed-off-by: Eric <menwe@amazon.com>
mengweieric added a commit that referenced this pull request Nov 13, 2023
@mengweieric
Revert commits back to after 2.11 release (#211)
32a7495 
* Revert "Fix error handling for user w/o proper permissions (#195) (#197)"

This reverts commit 26ed0dc.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Increment version to 2.11.1.0 (#186)"

This reverts commit b18f5f4.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "added fix for loading spinner issue for other database (#189) (#192)"

This reverts commit 94805c5.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "UI-bug fixes, added create query for MV (#182) (#188)"

This reverts commit 4187b6d.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Add backticks and remove ckpt for manual refresh in acceleration flyout (#183) (#185)"

This reverts commit f96c5d9.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Session update, minor fixes for acceleration flyout (#179) (#181)"

This reverts commit 257fb53.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "UI fixes for loading state, empty tree, added toast for error, fixed no indicies error (#176) (#178)"

This reverts commit 3c47d47.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Make checkpoint mandatory, add watermark delay, minor UI fixes (#173) (#175)"

This reverts commit 0198fa7.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "design changes for loading, changed the banner, updated tests (#170) (#172)"

This reverts commit 786c7c7.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Support dark mode and session for sql, minor bug fixes (#165) (#169)"

This reverts commit 0f5673a.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Added changes for making tree view persistent, made changes for bugs for loading screen (#153) (#167)"

This reverts commit 2269d1d.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "fixed create table async query bug (#158) (#163)"

This reverts commit 1964008.

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric <menwe@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps48 ps48 ps48 left review comments

@YANG-DB YANG-DB YANG-DB approved these changes

@mengweieric mengweieric mengweieric approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq rupal-bq is a code owner

@vamsi-amazon vamsi-amazon Awaiting requested review from vamsi-amazon vamsi-amazon is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sumukhswamy @ps48 @YANG-DB @mengweieric