design changes for loading tree elements, changed the banner, updated tests #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumukhswamy
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand and
anirudha
as code owners
Codecov Report
@@ Coverage Diff @@
## main #170 +/- ##
==========================================
- Coverage 58.68% 57.92% -0.77%
==========================================
Files 32 32
Lines 1428 1452 +24
Branches 234 245 +11
==========================================
+ Hits 838 841 +3
- Misses 570 591 +21
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
ps48
reviewed
Oct 24, 2023
| isLoading?: boolean | ||
| } | ||
|
|
||
| export interface isLoading { |
There was a problem hiding this comment.
Should be more specific like dataSourceLoadingStatus?
ps48
reviewed
Oct 24, 2023
| @@ -957,8 +957,8 @@ export class Main extends React.Component<MainProps, MainState> { | |||
| </EuiFlexGroup> | |||
| <EuiPage paddingSize="none"> | |||
| {this.state.language === 'SQL' && ( | |||
| <EuiPanel> | |||
| <EuiPageSideBar style={{ maxWidth: '400px', width: '400px' , overflow: 'auto' }}> | |||
| <EuiPanel grow ={true}> | |||
ps48
approved these changes
Oct 24, 2023
mengweieric
approved these changes
Oct 24, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
Signed-off-by: sumukhswamy <sumukhhs@amazon.com> (cherry picked from commit dcff236) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
Signed-off-by: sumukhswamy <sumukhhs@amazon.com> (cherry picked from commit dcff236) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric
added a commit
to mengweieric/dashboards-query-workbench
that referenced
this pull request
Nov 8, 2023
mengweieric
added a commit
to mengweieric/dashboards-query-workbench
that referenced
this pull request
Nov 8, 2023
…opensearch-project#170) (opensearch-project#172)" This reverts commit 786c7c7. Signed-off-by: Eric <menwe@amazon.com>
mengweieric
added a commit
that referenced
this pull request
Nov 13, 2023
* Revert "Fix error handling for user w/o proper permissions (#195) (#197)" This reverts commit 26ed0dc. Signed-off-by: Eric <menwe@amazon.com> * Revert "Increment version to 2.11.1.0 (#186)" This reverts commit b18f5f4. Signed-off-by: Eric <menwe@amazon.com> * Revert "added fix for loading spinner issue for other database (#189) (#192)" This reverts commit 94805c5. Signed-off-by: Eric <menwe@amazon.com> * Revert "UI-bug fixes, added create query for MV (#182) (#188)" This reverts commit 4187b6d. Signed-off-by: Eric <menwe@amazon.com> * Revert "Add backticks and remove ckpt for manual refresh in acceleration flyout (#183) (#185)" This reverts commit f96c5d9. Signed-off-by: Eric <menwe@amazon.com> * Revert "Session update, minor fixes for acceleration flyout (#179) (#181)" This reverts commit 257fb53. Signed-off-by: Eric <menwe@amazon.com> * Revert "UI fixes for loading state, empty tree, added toast for error, fixed no indicies error (#176) (#178)" This reverts commit 3c47d47. Signed-off-by: Eric <menwe@amazon.com> * Revert "Make checkpoint mandatory, add watermark delay, minor UI fixes (#173) (#175)" This reverts commit 0198fa7. Signed-off-by: Eric <menwe@amazon.com> * Revert "design changes for loading, changed the banner, updated tests (#170) (#172)" This reverts commit 786c7c7. Signed-off-by: Eric <menwe@amazon.com> * Revert "Support dark mode and session for sql, minor bug fixes (#165) (#169)" This reverts commit 0f5673a. Signed-off-by: Eric <menwe@amazon.com> * Revert "Added changes for making tree view persistent, made changes for bugs for loading screen (#153) (#167)" This reverts commit 2269d1d. Signed-off-by: Eric <menwe@amazon.com> * Revert "fixed create table async query bug (#158) (#163)" This reverts commit 1964008. Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.