Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI-bug fixes, added create query for MV #182

Merged
merged 6 commits into from
Oct 26, 2023
Merged

UI-bug fixes, added create query for MV #182

merged 6 commits into from
Oct 26, 2023

Conversation

sumukhswamy
Copy link
Collaborator

@sumukhswamy sumukhswamy commented Oct 25, 2023 •
edited
Loading

Description

fixed MV load bug
added mv create button
handled error case when post async query fails

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sumukhswamy
fixed MV load bug, added mv create button, handled error case when po…
6b77e6b 
…st query async fails

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
@ps48
Copy link
Member

ps48 commented Oct 25, 2023

@sumukhswamy Can you please update the PR title and make it shorter, these title directly go in to the release notes. You can use description for more details.

ps48
ps48 reviewed Oct 25, 2023
View reviewed changes
common/constants/index.ts Outdated Show resolved Hide resolved
ps48
ps48 reviewed Oct 25, 2023
View reviewed changes
common/constants/index.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #182 (9810035) into main (015cab8) will decrease coverage by 5.45%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
- Coverage   58.21%   52.76%   -5.45%     
==========================================
  Files          33       33              
  Lines        1546     1626      +80     
  Branches      270      291      +21     
==========================================
- Hits          900      858      -42     
- Misses        622      679      +57     
- Partials       24       89      +65
Flag Coverage Δ
dashboards-query-workbench 52.76% <ø> (-5.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

ps48
ps48 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@ps48 ps48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

common/constants/index.ts Outdated Show resolved Hide resolved
common/constants/index.ts Outdated Show resolved Hide resolved
common/constants/index.ts Outdated Show resolved Hide resolved
public/components/SQLPage/table_view.tsx Outdated Show resolved Hide resolved
@sumukhswamy sumukhswamy changed the title fixed MV load bug, added mv create button, handled error case when po… UI-bug fixes, added query for MV Oct 25, 2023
@ps48 ps48 changed the title UI-bug fixes, added query for MV UI-bug fixes, added create query for MV Oct 25, 2023
@sumukhswamy
addressed pr commits
f240ce1 
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
@sumukhswamy
changed the materialiazed view check
0725e41 
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
@sumukhswamy
changed badge to notif badge for mv
b6616f9 
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
@sumukhswamy
type check for mv
f8a18d6 
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
@sumukhswamy
added label for mv, changed mv condition
9810035 
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
@ps48 ps48 merged commit be457f6 into opensearch-project:main Oct 26, 2023
10 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 26, 2023
@github-actions
UI-bug fixes, added create query for MV (#182)
0c3cdae 
* fixed MV load bug, added mv create button, handled error case when post query async fails

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* addressed pr commits

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* changed the materialiazed view check

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* changed badge to notif badge for mv

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* type check for mv

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* added label for mv, changed mv condition

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

---------

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
(cherry picked from commit be457f6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 26, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 26, 2023
@github-actions
UI-bug fixes, added create query for MV (#182)
00cc60f 
* fixed MV load bug, added mv create button, handled error case when post query async fails

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* addressed pr commits

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* changed the materialiazed view check

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* changed badge to notif badge for mv

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* type check for mv

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* added label for mv, changed mv condition

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

---------

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
(cherry picked from commit be457f6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 26, 2023
Merged
ps48 pushed a commit that referenced this pull request Oct 26, 2023
@opensearch-trigger-bot @github-actions
UI-bug fixes, added create query for MV (#182) (#187)
f4cbf52 
* fixed MV load bug, added mv create button, handled error case when post query async fails



* addressed pr commits



* changed the materialiazed view check



* changed badge to notif badge for mv



* type check for mv



* added label for mv, changed mv condition



---------


(cherry picked from commit be457f6)

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Oct 26, 2023
@opensearch-trigger-bot @github-actions
UI-bug fixes, added create query for MV (#182) (#188)
4187b6d 
* fixed MV load bug, added mv create button, handled error case when post query async fails



* addressed pr commits



* changed the materialiazed view check



* changed badge to notif badge for mv



* type check for mv



* added label for mv, changed mv condition



---------


(cherry picked from commit be457f6)

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric added a commit to mengweieric/dashboards-query-workbench that referenced this pull request Nov 8, 2023
@mengweieric
Revert "UI-bug fixes, added create query for MV (opensearch-project#182…
39d2258 
…) (opensearch-project#188)"

This reverts commit 4187b6d.
mengweieric added a commit to mengweieric/dashboards-query-workbench that referenced this pull request Nov 8, 2023
@mengweieric
Revert "UI-bug fixes, added create query for MV (opensearch-project#182…
40091f0 
…) (opensearch-project#188)"

This reverts commit 4187b6d.

Signed-off-by: Eric <menwe@amazon.com>
mengweieric added a commit that referenced this pull request Nov 13, 2023
@mengweieric
Revert commits back to after 2.11 release (#211)
32a7495 
* Revert "Fix error handling for user w/o proper permissions (#195) (#197)"

This reverts commit 26ed0dc.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Increment version to 2.11.1.0 (#186)"

This reverts commit b18f5f4.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "added fix for loading spinner issue for other database (#189) (#192)"

This reverts commit 94805c5.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "UI-bug fixes, added create query for MV (#182) (#188)"

This reverts commit 4187b6d.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Add backticks and remove ckpt for manual refresh in acceleration flyout (#183) (#185)"

This reverts commit f96c5d9.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Session update, minor fixes for acceleration flyout (#179) (#181)"

This reverts commit 257fb53.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "UI fixes for loading state, empty tree, added toast for error, fixed no indicies error (#176) (#178)"

This reverts commit 3c47d47.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Make checkpoint mandatory, add watermark delay, minor UI fixes (#173) (#175)"

This reverts commit 0198fa7.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "design changes for loading, changed the banner, updated tests (#170) (#172)"

This reverts commit 786c7c7.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Support dark mode and session for sql, minor bug fixes (#165) (#169)"

This reverts commit 0f5673a.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Added changes for making tree view persistent, made changes for bugs for loading screen (#153) (#167)"

This reverts commit 2269d1d.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "fixed create table async query bug (#158) (#163)"

This reverts commit 1964008.

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric <menwe@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps48 ps48 ps48 approved these changes

@mengweieric mengweieric mengweieric approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq rupal-bq is a code owner

@vamsi-amazon vamsi-amazon Awaiting requested review from vamsi-amazon vamsi-amazon is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumukhswamy @ps48 @mengweieric