[Backport 2.x] UI-bug fixes, added create query for MV #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* fixed MV load bug, added mv create button, handled error case when post query async fails Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed pr commits Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * changed the materialiazed view check Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * changed badge to notif badge for mv Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * type check for mv Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * added label for mv, changed mv condition Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> (cherry picked from commit be457f6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand and
anirudha
as code owners
ps48
approved these changes
Oct 26, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #187 +/- ##
==========================================
- Coverage 54.79% 52.82% -1.97%
==========================================
Files 33 33
Lines 1356 1628 +272
Branches 210 292 +82
==========================================
+ Hits 743 860 +117
- Misses 535 679 +144
- Partials 78 89 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
ps48
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport be457f6 from #182.