Update docker.md #6519
Merged
Update docker.md #6519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding OPENSEARCH_INITIAL_ADMIN_PASSWORD variable to OpenSearch node for version 2.12.0. Signed-off-by: Pawel Wlodarczyk <pawel.wlodarczyk@eliatra.com>
pawelw1
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable and
stephen-crawford
as code owners
|
@derek-ho or @peterzhuamazon - Can you please approve this from a technical standpoint? Thanks! |
hdhalter
added
3 - Tech review
derek-ho
reviewed
Feb 27, 2024
| @@ -170,6 +170,7 @@ services: | |||
| - cluster.initial_cluster_manager_nodes=opensearch-node1,opensearch-node2 # Nodes eligible to serve as cluster manager | |||
| - bootstrap.memory_lock=true # Disable JVM heap memory swapping | |||
| - "OPENSEARCH_JAVA_OPTS=-Xms512m -Xmx512m" # Set min and max JVM heap sizes to at least 50% of system RAM | |||
| - OPENSEARCH_INITIAL_ADMIN_PASSWORD=${OPENSEARCH_INITIAL_ADMIN_PASSWORD} # Sets the demo admin user password when using demo configuration, required for OpenSearch 2.12 and higher | |||
There was a problem hiding this comment.
This looks good to me, but I think we may want to call out whether this is set here, or whether this env variable is present from outside or an .env file. Tagging @DarshitChanpura @peterzhuamazon to leave their comments here as well.
There was a problem hiding this comment.
we should add a note on line 157 stating the requirement to either define the variable in a .env and exporting it in the same terminal session where docker-compose is run from.
There was a problem hiding this comment.
Also, I have a companion PR to update the download steps for docker: opensearch-project/project-website#2526
peterzhuamazon
approved these changes
Feb 27, 2024
hdhalter
reviewed
Mar 1, 2024
Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>
Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>
hdhalter
added
4 - Doc review
Naarcha-AWS
reviewed
Mar 1, 2024
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>
Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>
Naarcha-AWS
reviewed
Mar 1, 2024
Naarcha-AWS
approved these changes
Mar 1, 2024
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
* Update docker.md Adding OPENSEARCH_INITIAL_ADMIN_PASSWORD variable to OpenSearch node for version 2.12.0. Signed-off-by: Pawel Wlodarczyk <pawel.wlodarczyk@eliatra.com> * Added note about 2.12 Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _install-and-configure/install-opensearch/docker.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _install-and-configure/install-opensearch/docker.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update docker.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _install-and-configure/install-opensearch/docker.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> --------- Signed-off-by: Pawel Wlodarczyk <pawel.wlodarczyk@eliatra.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> (cherry picked from commit 083496a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
hdhalter
added a commit
that referenced
this pull request
Mar 1, 2024
* Update docker.md Adding OPENSEARCH_INITIAL_ADMIN_PASSWORD variable to OpenSearch node for version 2.12.0. * Added note about 2.12 * Update _install-and-configure/install-opensearch/docker.md * Update _install-and-configure/install-opensearch/docker.md * Update docker.md * Update _install-and-configure/install-opensearch/docker.md --------- (cherry picked from commit 083496a) Signed-off-by: Pawel Wlodarczyk <pawel.wlodarczyk@eliatra.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
oeyh
pushed a commit
to oeyh/documentation-website
that referenced
this pull request
Mar 14, 2024
* Update docker.md Adding OPENSEARCH_INITIAL_ADMIN_PASSWORD variable to OpenSearch node for version 2.12.0. Signed-off-by: Pawel Wlodarczyk <pawel.wlodarczyk@eliatra.com> * Added note about 2.12 Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _install-and-configure/install-opensearch/docker.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _install-and-configure/install-opensearch/docker.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update docker.md Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> * Update _install-and-configure/install-opensearch/docker.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> --------- Signed-off-by: Pawel Wlodarczyk <pawel.wlodarczyk@eliatra.com> Signed-off-by: Heather Halter <HDHALTER@AMAZON.COM> Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding OPENSEARCH_INITIAL_ADMIN_PASSWORD variable to OpenSearch node for version 2.12.0.
Description
Adding OPENSEARCH_INITIAL_ADMIN_PASSWORD variable to OpenSearch nodes in example docker-compose.yml file for version 2.12.0.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.