Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker.md #6519

Merged
merged 6 commits into from
Mar 1, 2024
Merged

Update docker.md #6519

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
340582e
Update docker.md
pawelw1 Feb 26, 2024
a4b4527
Added note about 2.12
hdhalter Mar 1, 2024
ecff301
Update _install-and-configure/install-opensearch/docker.md
hdhalter Mar 1, 2024
17db451
Update _install-and-configure/install-opensearch/docker.md
hdhalter Mar 1, 2024
3906db4
Update docker.md
hdhalter Mar 1, 2024
9878c2a
Update _install-and-configure/install-opensearch/docker.md
hdhalter Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions _install-and-configure/install-opensearch/docker.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ services:
- cluster.initial_cluster_manager_nodes=opensearch-node1,opensearch-node2 # Nodes eligible to serve as cluster manager
- bootstrap.memory_lock=true # Disable JVM heap memory swapping
- "OPENSEARCH_JAVA_OPTS=-Xms512m -Xmx512m" # Set min and max JVM heap sizes to at least 50% of system RAM
- OPENSEARCH_INITIAL_ADMIN_PASSWORD=${OPENSEARCH_INITIAL_ADMIN_PASSWORD} # Sets the demo admin user password when using demo configuration, required for OpenSearch 2.12 and higher
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I think we may want to call out whether this is set here, or whether this env variable is present from outside or an .env file. Tagging @DarshitChanpura @peterzhuamazon to leave their comments here as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add a note on line 157 stating the requirement to either define the variable in a .env and exporting it in the same terminal session where docker-compose is run from.

Copy link
Member

@DarshitChanpura DarshitChanpura Feb 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I have a companion PR to update the download steps for docker: opensearch-project/project-website#2526

hdhalter marked this conversation as resolved.
Show resolved Hide resolved
ulimits:
memlock:
soft: -1 # Set memlock to unlimited (no soft or hard limit)
Expand All @@ -194,6 +195,7 @@ services:
- cluster.initial_cluster_manager_nodes=opensearch-node1,opensearch-node2
- bootstrap.memory_lock=true
- "OPENSEARCH_JAVA_OPTS=-Xms512m -Xmx512m"
- OPENSEARCH_INITIAL_ADMIN_PASSWORD=${OPENSEARCH_INITIAL_ADMIN_PASSWORD}
ulimits:
memlock:
soft: -1
Expand Down
Loading