Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Fix path in securityConfig section on OpenSearch (values.yaml) #337

Closed
wants to merge 0 commits into from

Conversation

GRomR1
Copy link
Contributor

@GRomR1 GRomR1 commented Oct 13, 2022

When I put some configures into section

securityConfig:
  config:
    data:
      config.yml: |-
        ....

The file config.yml will be created in path /usr/share/opensearch/plugins/opensearch-security/securityconfig/. OpenSearch didn't read this file. The content of this path is

sh-4.2$ ls -lah /usr/share/opensearch/plugins/opensearch-security/
total 44M
drwxr-xr-x. 1 opensearch opensearch    28 Oct 12 18:42 .
drwxr-xr-x. 1 opensearch opensearch    60 Oct 12 18:43 ..
-rw-r--r--. 1 opensearch opensearch   29K Jun 30 21:49 accessors-smart-2.4.7.jar
-rw-r--r--. 1 opensearch opensearch   56K Jun 30 21:49 aggs-matrix-stats-client-2.1.0.jar
-rw-r--r--. 1 opensearch opensearch  119K Jun 30 21:49 asm-9.1.jar
-rw-r--r--. 1 opensearch opensearch  5.7M Jun 30 21:49 bcprov-jdk15on-1.67.jar

I think the right path should be /usr/share/opensearch/config/opensearch-security/

sh-4.2$ ls -lah /usr/share/opensearch/config/opensearch-security/
total 72K
drwxr-x---. 2 opensearch opensearch  245 Jun 30 21:49 .
drwxr-xr-x. 1 opensearch opensearch   46 Oct 13 07:15 ..
-rw-rw----. 1 opensearch opensearch   50 Jun 30 21:49 action_groups.yml
-rw-rw----. 1 opensearch opensearch 2.0K Jun 30 21:49 allowlist.yml
-rw-rw----. 1 opensearch opensearch 2.5K Jun 30 21:49 audit.yml
-rw-rw----. 1 opensearch opensearch 9.8K Jun 30 21:49 config.yml
-rw-rw----. 1 opensearch opensearch 1.7K Jun 30 21:49 internal_users.yml
-rw-rw----. 1 opensearch opensearch  154 Jun 30 21:49 nodes_dn.yml
-rw-rw----. 1 opensearch opensearch  13K Jun 30 21:49 opensearch.yml.example
-rw-rw----. 1 opensearch opensearch 8.4K Jun 30 21:49 roles.yml
-rw-rw----. 1 opensearch opensearch  844 Jun 30 21:49 roles_mapping.yml
-rw-rw----. 1 opensearch opensearch  170 Jun 30 21:49 tenants.yml
-rw-rw----. 1 opensearch opensearch 2.0K Jun 30 21:49 whitelist.yml

Description

[Describe what this change achieves.]

Issues Resolved

[List any issues this PR will resolve. You should likely open an issue if one does not already exist.]

Check List

  • Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

  • Helm chart version bumped
  • Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@GRomR1 GRomR1 requested review from a team, TheAlgo and DandyDeveloper as code owners October 13, 2022 07:17
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you @GRomR1 for the contribution.

This is a specific change in 2.x and it was missed.

Would you mind updating the CHANGELOG and charts version?

Thanks.

@peterzhuamazon
Copy link
Member

@prudhvigodithi @TheAlgo

@peterzhuamazon peterzhuamazon added the bug Something isn't working label Oct 25, 2022
@peterzhuamazon
Copy link
Member

Could you also sign DCO @GRomR1 ?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants