Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path in securityConfig section on OpenSearch (values.yaml) #344

Merged
merged 6 commits into from
Dec 8, 2022

Conversation

GRomR1
Copy link
Contributor

@GRomR1 GRomR1 commented Oct 30, 2022

Signed-off-by: Ruslan Gainanov gromrx1@gmail.com

Description

When I put some configures into section

securityConfig:
  config:
    data:
      config.yml: |-
        ....

The file config.yml will be created in path /usr/share/opensearch/plugins/opensearch-security/securityconfig/. OpenSearch didn't read this file. The content of this path is

sh-4.2$ ls -lah /usr/share/opensearch/plugins/opensearch-security/
total 44M
drwxr-xr-x. 1 opensearch opensearch    28 Oct 12 18:42 .
drwxr-xr-x. 1 opensearch opensearch    60 Oct 12 18:43 ..
-rw-r--r--. 1 opensearch opensearch   29K Jun 30 21:49 accessors-smart-2.4.7.jar
-rw-r--r--. 1 opensearch opensearch   56K Jun 30 21:49 aggs-matrix-stats-client-2.1.0.jar
-rw-r--r--. 1 opensearch opensearch  119K Jun 30 21:49 asm-9.1.jar
-rw-r--r--. 1 opensearch opensearch  5.7M Jun 30 21:49 bcprov-jdk15on-1.67.jar

I think the right path should be /usr/share/opensearch/config/opensearch-security/

sh-4.2$ ls -lah /usr/share/opensearch/config/opensearch-security/
total 72K
drwxr-x---. 2 opensearch opensearch  245 Jun 30 21:49 .
drwxr-xr-x. 1 opensearch opensearch   46 Oct 13 07:15 ..
-rw-rw----. 1 opensearch opensearch   50 Jun 30 21:49 action_groups.yml
-rw-rw----. 1 opensearch opensearch 2.0K Jun 30 21:49 allowlist.yml
-rw-rw----. 1 opensearch opensearch 2.5K Jun 30 21:49 audit.yml
-rw-rw----. 1 opensearch opensearch 9.8K Jun 30 21:49 config.yml
-rw-rw----. 1 opensearch opensearch 1.7K Jun 30 21:49 internal_users.yml
-rw-rw----. 1 opensearch opensearch  154 Jun 30 21:49 nodes_dn.yml
-rw-rw----. 1 opensearch opensearch  13K Jun 30 21:49 opensearch.yml.example
-rw-rw----. 1 opensearch opensearch 8.4K Jun 30 21:49 roles.yml
-rw-rw----. 1 opensearch opensearch  844 Jun 30 21:49 roles_mapping.yml
-rw-rw----. 1 opensearch opensearch  170 Jun 30 21:49 tenants.yml
-rw-rw----. 1 opensearch opensearch 2.0K Jun 30 21:49 whitelist.yml

Check List

  • Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

  • Helm chart version bumped
  • Helm chart CHANGELOG.md updated to reflect change

Signed-off-by: Ruslan Gainanov <gromrx1@gmail.com>
@GRomR1 GRomR1 requested review from a team, TheAlgo and DandyDeveloper as code owners October 30, 2022 09:42
@GRomR1
Copy link
Contributor Author

GRomR1 commented Oct 30, 2022

Attempt 2. I don't understand why but the previous PR has been closed when I try to add CHANGELOG and version

#337

@prudhvigodithi
Copy link
Member

Thanks @GRomR1 for the PR, LGTM, this we need not backport to 1.x, @TheAlgo and @peterzhuamazon can you take a look
?
Thank you

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Nov 12, 2022

Hi,

This is good, one more miss due to this change in 2.x:
opensearch-project/opensearch-plugins#127

I am ok to have this in 2.x only. Thanks @GRomR1 for catching this issue.

Also, @GRomR1 could you please resolve the version issues, will merge then.

Thanks.

@GRomR1
Copy link
Contributor Author

GRomR1 commented Nov 13, 2022

@peterzhuamazon resolved.

@TheAlgo could you please look and approve the PR

@peterzhuamazon
Copy link
Member

Waiting a new approval from @prudhvigodithi or @TheAlgo.
If no responses I will approve and fix the linting after I come back from Thanksgiving.

Thanks.

@prudhvigodithi
Copy link
Member

Hey Thanks for the PR @GRomR1, LGTM, can you please resolve the conflicts?
Thank you

@peterzhuamazon
Copy link
Member

Trying to fix the linting here.

@peterzhuamazon
Copy link
Member

Related to kind action need to update to 1.3.0.

@peterzhuamazon
Copy link
Member

No need to backport this as it is 2.x + only changes

@peterzhuamazon peterzhuamazon merged commit 18d0151 into opensearch-project:main Dec 8, 2022
prathaptce pushed a commit to prathaptce/helm-charts that referenced this pull request Mar 24, 2023
…earch-project#344)

* fix securityConfig.path

Signed-off-by: Ruslan Gainanov <gromrx1@gmail.com>

* add link to issue

Signed-off-by: Ruslan Gainanov <gromrx1@gmail.com>

Signed-off-by: Ruslan Gainanov <gromrx1@gmail.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>
bbarani added a commit that referenced this pull request Apr 24, 2023
* Update appVersion for 2.4.0 release (#350)

Signed-off-by: Zelin Hao <zelinhao@amazon.com>

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Add .whitesource configuration file (#353)

Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Resolve Kind Cluster not able to be built in PR checks (#356)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Fix the kindest/node docker images versions (#357)

* Resolve Kind Cluster not able to be built in PR checks

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Fix the kindest/node versions on docker images

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Resolve Kind Cluster not able to be built in PR checks (#358)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* allow adding plugins and change defaultmode for opensearch dashboards (#342)

* allow adding plugins and change defaultmode for opensearch dashboards yaml file

Signed-off-by: Lu Yu <nluyu@amazon.com>

* bump version and update changelog

Signed-off-by: Lu Yu <nluyu@amazon.com>

* add new line

Signed-off-by: Lu Yu <nluyu@amazon.com>

* bump version for os

Signed-off-by: Lu Yu <nluyu@amazon.com>

* resolve conflict in changelog

Signed-off-by: Lu Yu <nluyu@amazon.com>

* trigger build

Signed-off-by: Lu Yu <nluyu@amazon.com>

Signed-off-by: Lu Yu <nluyu@amazon.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Fix path in securityConfig section on OpenSearch (values.yaml) (#344)

* fix securityConfig.path

Signed-off-by: Ruslan Gainanov <gromrx1@gmail.com>

* add link to issue

Signed-off-by: Ruslan Gainanov <gromrx1@gmail.com>

Signed-off-by: Ruslan Gainanov <gromrx1@gmail.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Update appVersion to 2.4.1 (#363)

* Update appVersion to 2.4.1

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>

* Update appVersion to 2.4.1

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>

* Fix changelog

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>

* Fix changelog

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>

* Fix version

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Fix version for OpenSearch

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Fix version for OpenSearch-Dasboards

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Add hostPort support for http- and transport-ports (#336)

Signed-off-by: Christian Kuhn <phello@gmx.de>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Updated MAINTAINERS.md to match recommended opensearch-project format. (#367)

Signed-off-by: dblock <dblock@amazon.com>

Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Bump OS and OSD version to 2.5.0 (#373)

Signed-off-by: Rishabh Singh <sngri@amazon.com>

Signed-off-by: Rishabh Singh <sngri@amazon.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Created untriaged issue workflow. (#382)

Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Bump OpenSearch and Dashboards to 2.6.0 (#393)

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Updating the CODEOWNERS file (#399)

Signed-off-by: bbarani <bbarani@amazon.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Add lifecycle support in opensearch container (#376)

* Add lifecycle support in opensearch container

Signed-off-by: josephteddick <josephteddick@gmail.com>

* lifecycle support PR cleanup

Signed-off-by: josephteddick <josephteddick@gmail.com>

---------

Signed-off-by: josephteddick <josephteddick@gmail.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* feat: Add user-defined labels option to ingress (#390)

Signed-off-by: Jason Witkowski <jwitkowski@zscaler.com>
Co-authored-by: Jason Witkowski <jwitkowski@zscaler.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Update deployment.yaml

Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Update values.yaml

Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Update values.yaml

Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Update statefulset.yaml

Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Updating chart version and changelog.md

Signed-off-by: Prathap Mahalingam (Nokia) <prathap.mahalingam@nokia.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Add lifecycle support in opensearch container (#376)

* Add lifecycle support in opensearch container

Signed-off-by: josephteddick <josephteddick@gmail.com>

* lifecycle support PR cleanup

Signed-off-by: josephteddick <josephteddick@gmail.com>

---------

Signed-off-by: josephteddick <josephteddick@gmail.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Add github-merit-badger.yml (#408)

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Service port for performance analyzer (#346)

* Performance analyzer port mapping

Signed-off-by: Philipp Hölscher <phoelsch@outlook.de>

* Performance analyzer port on ci-values

Signed-off-by: Philipp Hölscher <phoelsch@outlook.de>

* Update changelog

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

---------

Signed-off-by: Philipp Hölscher <phoelsch@outlook.de>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Incorporated the review comments

Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Update values.yaml

Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Incorporated the review comments

Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Correcting the merge conflicts

Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Updated the README.md for OpenSearch & Dashboard

Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Updated the changelog message

Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

* Updating the version number

Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>

---------

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Ruslan Gainanov <gromrx1@gmail.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Christian Kuhn <phello@gmx.de>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: Rishabh Singh <sngri@amazon.com>
Signed-off-by: bbarani <bbarani@amazon.com>
Signed-off-by: josephteddick <josephteddick@gmail.com>
Signed-off-by: Jason Witkowski <jwitkowski@zscaler.com>
Signed-off-by: Prathap Mahalingam (Nokia) <prathap.mahalingam@nokia.com>
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Signed-off-by: Philipp Hölscher <phoelsch@outlook.de>
Co-authored-by: Zelin Hao <87548827+zelinh@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Co-authored-by: Lu Yu <yulu.nju@gmail.com>
Co-authored-by: Ruslan Gainanov <gromrx1@gmail.com>
Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com>
Co-authored-by: Sayali Gaikawad <gaiksaya@amazon.com>
Co-authored-by: Christian Kuhn <86721442+ph311o@users.noreply.github.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@dblock.org>
Co-authored-by: Rishabh Singh <rishabhksingh@gmail.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Co-authored-by: Barani <70038446+bbarani@users.noreply.github.com>
Co-authored-by: Joseph Teddick <43552317+josephteddick@users.noreply.github.com>
Co-authored-by: Jason Witkowski <jason@witkow.ski>
Co-authored-by: Jason Witkowski <jwitkowski@zscaler.com>
Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com>
Co-authored-by: Philipp Hölscher <46397932+Phoelsch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants