Add lifecycle support in opensearch container #376
Merged
+29
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephteddick
requested review from
a team,
TheAlgo and
DandyDeveloper
as code owners
Signed-off-by: josephteddick <josephteddick@gmail.com>
|
@josephteddick Can you add an issue to it which describes these addition and if you have any use cases in mind? |
TheAlgo
reviewed
Mar 2, 2023
Signed-off-by: josephteddick <josephteddick@gmail.com>
|
Thanks for the PR @josephteddick LGTM!, can you please also test with helm upgrade, just want to make sure its not a breaking change for existing helm charts. @TheAlgo you also review this PR again. |
TheAlgo
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
LGTM! As @prudhvigodithi mentioned lets test these out once with helm upgrade as well
|
@TheAlgo @prudhvigodithi Thank you for the approval. I just did a helm template locally and all values checked out without error. Lmk if there is anything else you need. |
prudhvigodithi
added
the
backport 1.x
prudhvigodithi
approved these changes
Mar 14, 2023
|
Hey @josephteddick I have merged this PR, can you also please backport to 1.x? |
|
@prudhvigodithi Thanks for the merge! Just submitted the backport PR: |
prathaptce
pushed a commit
to prathaptce/helm-charts
that referenced
this pull request
Mar 23, 2023
* Add lifecycle support in opensearch container Signed-off-by: josephteddick <josephteddick@gmail.com> * lifecycle support PR cleanup Signed-off-by: josephteddick <josephteddick@gmail.com> --------- Signed-off-by: josephteddick <josephteddick@gmail.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>
prathaptce
pushed a commit
to prathaptce/helm-charts
that referenced
this pull request
Mar 24, 2023
* Add lifecycle support in opensearch container Signed-off-by: josephteddick <josephteddick@gmail.com> * lifecycle support PR cleanup Signed-off-by: josephteddick <josephteddick@gmail.com> --------- Signed-off-by: josephteddick <josephteddick@gmail.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>
prathaptce
pushed a commit
to prathaptce/helm-charts
that referenced
this pull request
Mar 24, 2023
* Add lifecycle support in opensearch container Signed-off-by: josephteddick <josephteddick@gmail.com> * lifecycle support PR cleanup Signed-off-by: josephteddick <josephteddick@gmail.com> --------- Signed-off-by: josephteddick <josephteddick@gmail.com>
prathaptce
pushed a commit
to prathaptce/helm-charts
that referenced
this pull request
Mar 24, 2023
* Add lifecycle support in opensearch container Signed-off-by: josephteddick <josephteddick@gmail.com> * lifecycle support PR cleanup Signed-off-by: josephteddick <josephteddick@gmail.com> --------- Signed-off-by: josephteddick <josephteddick@gmail.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>
prathaptce
pushed a commit
to prathaptce/helm-charts
that referenced
this pull request
Mar 24, 2023
* Add lifecycle support in opensearch container Signed-off-by: josephteddick <josephteddick@gmail.com> * lifecycle support PR cleanup Signed-off-by: josephteddick <josephteddick@gmail.com> --------- Signed-off-by: josephteddick <josephteddick@gmail.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>
prathaptce
pushed a commit
to prathaptce/helm-charts
that referenced
this pull request
Mar 24, 2023
* Add lifecycle support in opensearch container Signed-off-by: josephteddick <josephteddick@gmail.com> * lifecycle support PR cleanup Signed-off-by: josephteddick <josephteddick@gmail.com> --------- Signed-off-by: josephteddick <josephteddick@gmail.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>
prathaptce
pushed a commit
to prathaptce/helm-charts
that referenced
this pull request
Mar 24, 2023
* Add lifecycle support in opensearch container Signed-off-by: josephteddick <josephteddick@gmail.com> * lifecycle support PR cleanup Signed-off-by: josephteddick <josephteddick@gmail.com> --------- Signed-off-by: josephteddick <josephteddick@gmail.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com>
bbarani
added a commit
that referenced
this pull request
Apr 24, 2023
* Update appVersion for 2.4.0 release (#350) Signed-off-by: Zelin Hao <zelinhao@amazon.com> Signed-off-by: Zelin Hao <zelinhao@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Add .whitesource configuration file (#353) Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Resolve Kind Cluster not able to be built in PR checks (#356) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Fix the kindest/node docker images versions (#357) * Resolve Kind Cluster not able to be built in PR checks Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Fix the kindest/node versions on docker images Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Resolve Kind Cluster not able to be built in PR checks (#358) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * allow adding plugins and change defaultmode for opensearch dashboards (#342) * allow adding plugins and change defaultmode for opensearch dashboards yaml file Signed-off-by: Lu Yu <nluyu@amazon.com> * bump version and update changelog Signed-off-by: Lu Yu <nluyu@amazon.com> * add new line Signed-off-by: Lu Yu <nluyu@amazon.com> * bump version for os Signed-off-by: Lu Yu <nluyu@amazon.com> * resolve conflict in changelog Signed-off-by: Lu Yu <nluyu@amazon.com> * trigger build Signed-off-by: Lu Yu <nluyu@amazon.com> Signed-off-by: Lu Yu <nluyu@amazon.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Fix path in securityConfig section on OpenSearch (values.yaml) (#344) * fix securityConfig.path Signed-off-by: Ruslan Gainanov <gromrx1@gmail.com> * add link to issue Signed-off-by: Ruslan Gainanov <gromrx1@gmail.com> Signed-off-by: Ruslan Gainanov <gromrx1@gmail.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Update appVersion to 2.4.1 (#363) * Update appVersion to 2.4.1 Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Update appVersion to 2.4.1 Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Fix changelog Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Fix changelog Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Fix version Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Fix version for OpenSearch Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Fix version for OpenSearch-Dasboards Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Add hostPort support for http- and transport-ports (#336) Signed-off-by: Christian Kuhn <phello@gmx.de> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Updated MAINTAINERS.md to match recommended opensearch-project format. (#367) Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Bump OS and OSD version to 2.5.0 (#373) Signed-off-by: Rishabh Singh <sngri@amazon.com> Signed-off-by: Rishabh Singh <sngri@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Created untriaged issue workflow. (#382) Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Bump OpenSearch and Dashboards to 2.6.0 (#393) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Updating the CODEOWNERS file (#399) Signed-off-by: bbarani <bbarani@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Add lifecycle support in opensearch container (#376) * Add lifecycle support in opensearch container Signed-off-by: josephteddick <josephteddick@gmail.com> * lifecycle support PR cleanup Signed-off-by: josephteddick <josephteddick@gmail.com> --------- Signed-off-by: josephteddick <josephteddick@gmail.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * feat: Add user-defined labels option to ingress (#390) Signed-off-by: Jason Witkowski <jwitkowski@zscaler.com> Co-authored-by: Jason Witkowski <jwitkowski@zscaler.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Update deployment.yaml Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Update values.yaml Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Update values.yaml Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Update statefulset.yaml Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Updating chart version and changelog.md Signed-off-by: Prathap Mahalingam (Nokia) <prathap.mahalingam@nokia.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Add lifecycle support in opensearch container (#376) * Add lifecycle support in opensearch container Signed-off-by: josephteddick <josephteddick@gmail.com> * lifecycle support PR cleanup Signed-off-by: josephteddick <josephteddick@gmail.com> --------- Signed-off-by: josephteddick <josephteddick@gmail.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Add github-merit-badger.yml (#408) Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Service port for performance analyzer (#346) * Performance analyzer port mapping Signed-off-by: Philipp Hölscher <phoelsch@outlook.de> * Performance analyzer port on ci-values Signed-off-by: Philipp Hölscher <phoelsch@outlook.de> * Update changelog Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Philipp Hölscher <phoelsch@outlook.de> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Incorporated the review comments Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Update values.yaml Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Incorporated the review comments Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Correcting the merge conflicts Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Updated the README.md for OpenSearch & Dashboard Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Updated the changelog message Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> * Updating the version number Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> --------- Signed-off-by: Zelin Hao <zelinhao@amazon.com> Signed-off-by: prathaptce <86703966+prathaptce@users.noreply.github.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Lu Yu <nluyu@amazon.com> Signed-off-by: Ruslan Gainanov <gromrx1@gmail.com> Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: Christian Kuhn <phello@gmx.de> Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Rishabh Singh <sngri@amazon.com> Signed-off-by: bbarani <bbarani@amazon.com> Signed-off-by: josephteddick <josephteddick@gmail.com> Signed-off-by: Jason Witkowski <jwitkowski@zscaler.com> Signed-off-by: Prathap Mahalingam (Nokia) <prathap.mahalingam@nokia.com> Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> Signed-off-by: Philipp Hölscher <phoelsch@outlook.de> Co-authored-by: Zelin Hao <87548827+zelinh@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Lu Yu <yulu.nju@gmail.com> Co-authored-by: Ruslan Gainanov <gromrx1@gmail.com> Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com> Co-authored-by: Sayali Gaikawad <gaiksaya@amazon.com> Co-authored-by: Christian Kuhn <86721442+ph311o@users.noreply.github.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@dblock.org> Co-authored-by: Rishabh Singh <rishabhksingh@gmail.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> Co-authored-by: Barani <70038446+bbarani@users.noreply.github.com> Co-authored-by: Joseph Teddick <43552317+josephteddick@users.noreply.github.com> Co-authored-by: Jason Witkowski <jason@witkow.ski> Co-authored-by: Jason Witkowski <jwitkowski@zscaler.com> Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com> Co-authored-by: Philipp Hölscher <46397932+Phoelsch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was looking to run the securityadmin.sh script automatically after the opensearch container is started up. However, the opensearch container in the StatefulSet did not have 'lifecycle' support. Added support to satisfy my use case, in addition to adding extra customization options to the chart.
Issues Resolved
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.