Added PolicyDetails page #62

lobdelle · 2021-08-12T18:08:44Z

Description

Adds PolicyDetails page and cypress test. Reroutes policy list page link to PolicyDetails page.

Loading:

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dbbaughe · 2021-08-12T19:41:13Z

cypress/support/index.js

@@ -53,3 +53,11 @@ if (Cypress.env("security_enabled")) {
  Cypress.env("opensearch", `http://${Cypress.env("opensearch_url")}`);
  Cypress.env("opensearch_dashboards", `http://${Cypress.env("opensearch_dashboards_url")}`);
 }
+
+const resizeObserverLoopErrRe = /^[^(ResizeObserver loop limit exceeded)]/
+Cypress.on('uncaught:exception', (err) => {


What's this for?

My Policy Details test is throwing that exception, I believe between when the page appears and the API returns with the policy info. Researched and most places I found indicated that that error is benign, but it was causing the test to fail. I don't know what's causing it to appear on the Policy Details page, and not other similar details pages. This allows cypress to ignore that error and not fail the test because of it.

The error message itself is concerning, seems like something going into an infinite loop. If it's not seen on any other page then perhaps we can rewrite to make it go away. Let's create a GitHub issue for it along w/ links you read.

public/pages/PolicyDetails/containers/PolicyDetails/PolicyDetails.tsx

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

…test Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

This reverts commit 0e173f4.

* Revert "Register action hook (#64)" This reverts commit c1b76de. * Revert "Added PolicyDetails page (#62)" This reverts commit 0e173f4. * Revert "Adds VisualCreatePolicy page, missing backend routes/configs, updates… (#61)" This reverts commit 69d8fe1. * Revert "Added PolicySettings and DeleteModal components for PolicyDetails UI (#50)" This reverts commit b9645f1. * Revert "Adds create state container and removes unused props from modal and c… (#60)" This reverts commit ea320d4. * Revert "Adds modal for choosing between visual and json editor (#58)" This reverts commit 0f3e89c. * Revert "Adds create transition container (#59)" This reverts commit 72c200c. * Revert "Adds transition component (#57)" This reverts commit 131becf. * Revert "Adds create action container shown in flyout (#56)" This reverts commit 19883f7. * Revert "Adds ISM Templates UI component (#55)" This reverts commit a90e65f. * Revert "Adds State UI component (#54)" This reverts commit 96ff81c. * Revert "Adds timeout retry settings component used in action flyout (#52)" This reverts commit 6142d13. * Revert "Adds single state UI component (#53)" This reverts commit a25e3fe. * Revert "Adds individual ISM template UI component (#51)" This reverts commit c70a926. * Revert "Adds UI actions for all the supported ISM actions (#49)" This reverts commit 0d6b814. * Revert "Adds draggable transitions and transition content (#48)" This reverts commit dfca9f4. * Revert "Adds error notification UI container and updates snapshots (#47)" This reverts commit 4b6724b. * Revert "Adds policy info section for new UI (#45)" This reverts commit 72e4639. * Revert "Adds new UI for Channel Notification (#44)" This reverts commit 39df0ae. * Revert "Adds notification service to make backend call for getting list of channels for Index Management (#46)" This reverts commit c6fc887. * Revert "Adds draggable action component (#43)" This reverts commit 4c25961. * Revert "Adds legacy notification UI input (#42)" This reverts commit ff15676. * Revert "Adds a small Badge component (#39)" This reverts commit bb691d2. * Revert "Adds reusable flyout footer (#41)" This reverts commit c9fefc9. * Revert "Adds custom label to use with EuiForm component (#40)" This reverts commit 6299cd0.

lobdelle requested review from dbbaughe, bowenlan-amzn and annie3431 August 12, 2021 18:08