Register action hook #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
dbbaughe
reviewed
Aug 13, 2021
dbbaughe
reviewed
Aug 13, 2021
public/plugin.ts
Outdated
| } | ||
|
|
||
| public start(core: CoreStart): IndexManagementPluginStart { | ||
| // https://www.digitalocean.com/community/tutorials/js-js-singletons | ||
| Object.freeze(actionRepoSingleton); |
There was a problem hiding this comment.
Does start happen after all other plugins have potentially "registered" their own actions?
There was a problem hiding this comment.
Asking because I would like to see us freeze the repository after registrations have happened so it can't accidentally be modified. Or make it non accessible without calling registerAction
There was a problem hiding this comment.
Other plugins should register their own action in their setup, so freeze in start here which is after other plugins' setups finished.
Did experiment, I should freeze actionRepoSingleton.repository, then registerAction after freeze will cause Uncaught error.
|
|
|
Integration test temporarily blocked, ongoing update for our backend github workflow. So running locally. One flaky failure. |
|
Can we fix the workflow for now in this PR? I think it was just a one line change we can do to get it passing by changing common utils ref from 1.0 to main |
bowenlan-amzn
force-pushed
the
registeraction
branch
from
eaad074 to
2f4f203
Compare
dbbaughe
approved these changes
Aug 17, 2021
bowenlan-amzn
added a commit
to bowenlan-amzn/index-management-dashboards-plugin
that referenced
this pull request
Sep 23, 2021
This reverts commit c1b76de.
bowenlan-amzn
added a commit
that referenced
this pull request
Sep 28, 2021
* Revert "Register action hook (#64)" This reverts commit c1b76de. * Revert "Added PolicyDetails page (#62)" This reverts commit 0e173f4. * Revert "Adds VisualCreatePolicy page, missing backend routes/configs, updates… (#61)" This reverts commit 69d8fe1. * Revert "Added PolicySettings and DeleteModal components for PolicyDetails UI (#50)" This reverts commit b9645f1. * Revert "Adds create state container and removes unused props from modal and c… (#60)" This reverts commit ea320d4. * Revert "Adds modal for choosing between visual and json editor (#58)" This reverts commit 0f3e89c. * Revert "Adds create transition container (#59)" This reverts commit 72c200c. * Revert "Adds transition component (#57)" This reverts commit 131becf. * Revert "Adds create action container shown in flyout (#56)" This reverts commit 19883f7. * Revert "Adds ISM Templates UI component (#55)" This reverts commit a90e65f. * Revert "Adds State UI component (#54)" This reverts commit 96ff81c. * Revert "Adds timeout retry settings component used in action flyout (#52)" This reverts commit 6142d13. * Revert "Adds single state UI component (#53)" This reverts commit a25e3fe. * Revert "Adds individual ISM template UI component (#51)" This reverts commit c70a926. * Revert "Adds UI actions for all the supported ISM actions (#49)" This reverts commit 0d6b814. * Revert "Adds draggable transitions and transition content (#48)" This reverts commit dfca9f4. * Revert "Adds error notification UI container and updates snapshots (#47)" This reverts commit 4b6724b. * Revert "Adds policy info section for new UI (#45)" This reverts commit 72e4639. * Revert "Adds new UI for Channel Notification (#44)" This reverts commit 39df0ae. * Revert "Adds notification service to make backend call for getting list of channels for Index Management (#46)" This reverts commit c6fc887. * Revert "Adds draggable action component (#43)" This reverts commit 4c25961. * Revert "Adds legacy notification UI input (#42)" This reverts commit ff15676. * Revert "Adds a small Badge component (#39)" This reverts commit bb691d2. * Revert "Adds reusable flyout footer (#41)" This reverts commit c9fefc9. * Revert "Adds custom label to use with EuiForm component (#40)" This reverts commit 6299cd0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bowenlan-amzn bowenlan23@gmail.com
Description
Expose a
registerActionhook for other plugins to add more Action into ISM UX dynamically.Having a singleton
actionRepoSingletoninitialized during plugin setup, which will be used for providing UIAction in several places acrossCreateState,CreateAction,StateIssues Resolved
[List any issues this PR will resolve]
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.