Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI fixes for new ISM UI #84

Merged
merged 19 commits into from
Sep 8, 2021
Merged

UI fixes for new ISM UI #84

merged 19 commits into from
Sep 8, 2021

Conversation

dbbaughe
Copy link
Contributor

@dbbaughe dbbaughe commented Sep 8, 2021

Description

  • Adds isValid method to actions, implements logic, and sets on UI to show error state and disable buttons
  • Fixes update/create not showing error toaster when there is a failure
  • Fixes a bunch of the number type inputs from setting the value as NaN
  • Fixes the timeout/retry settings turning into uncontrolled inputs
  • Fixes allocation and rollup actions not being able to correctly save when edited and not edited.
  • A bunch of the UI inputs had text transform capitalize on them for some reason, probably from copy pasting from other components, removed them.
  • Adds default no conditions option in transition conditions
  • Fixes editing an action bug that instead adding a new action when switching the action type
  • Blocks creating a state if a state with that name already exists on UI
  • Removes unused rollover keys if they are not used
  • We were missing the UI for Allocation action, considering time just added simple JSON editor and we can go back and add a more friendly UI.
  • Removes X from top right of flyout
  • Removes flyout overlay and makes outside clicks not close flyout
  • Changes state flyout button from "X Close" to "Cancel"
  • Removes X icon from action/transition cancel button
  • Adds toolips for edit/delete icons for states, transitions, and actions
  • Removes underline when hovering states

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
…nsition components

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
…nd removes X close button on top right

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
…rom hovering states

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
…uncontrolled inputs and NaN minDocs

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
…nd matching logic didn't find an action

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
…ions option that is the default

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
… value

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
… passes to form labels

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
… on updates

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #84 (295b0b1) into main (5f3b941) will decrease coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   50.24%   49.83%   -0.42%     
==========================================
  Files         154      154              
  Lines        4221     4328     +107     
  Branches      625      662      +37     
==========================================
+ Hits         2121     2157      +36     
- Misses       1950     2014      +64     
- Partials      150      157       +7     
Impacted Files Coverage Δ
...mponents/EuiFormCustomLabel/EuiFormCustomLabel.tsx 85.71% <0.00%> (-14.29%) ⬇️
...licy/components/UIActions/ReplicaCountUIAction.tsx 57.89% <0.00%> (-8.78%) ⬇️
...reatePolicy/containers/CreateState/CreateState.tsx 50.53% <0.00%> (-1.79%) ⬇️
...licy/components/UIActions/NotificationUIAction.tsx 3.44% <0.00%> (-0.90%) ⬇️
...ntainers/VisualCreatePolicy/VisualCreatePolicy.tsx 13.27% <0.00%> (-0.62%) ⬇️
...ges/VisualCreatePolicy/components/States/State.tsx 94.44% <0.00%> (ø)
...ualCreatePolicy/containers/CreateState/Actions.tsx 75.00% <0.00%> (ø)
...reatePolicy/containers/CreateState/Transitions.tsx 75.00% <0.00%> (ø)
...tePolicy/components/UIActions/ReadOnlyUIAction.tsx 0.00% <0.00%> (ø)
...tePolicy/components/UIActions/RolloverUIAction.tsx 50.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f3b941...295b0b1. Read the comment docs.

…lup to include ism_rollup key

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Copy link
Member

@bowenlan-amzn bowenlan-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dbbaughe dbbaughe merged commit d23f65a into opensearch-project:main Sep 8, 2021
@bowenlan-amzn bowenlan-amzn added enhancement New feature or request v1.1.0.0 labels Sep 9, 2021
dbbaughe added a commit to dbbaughe/index-management-dashboards-plugin that referenced this pull request Sep 10, 2021
* Removes X icon from action/transition flyout footer next to cancel

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds tooltips to edit/delete icon buttons on the draggable action/transition components

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Removes overlay for flyout so clicking outside doesn't close flyout and removes X close button on top right

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds edit/delete tooltips for state component and removes underline from hovering states

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Changes state flyout from X Close to Cancel

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds JSON editor for allocation action

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds isValid to action interface and implements in actions

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Correctly removes unused rollover keys from rollover object, handles uncontrolled inputs and NaN minDocs

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds error for state name already existing in policy

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes duplicated actions when editing as previously we had a new ID and matching logic didn't find an action

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes other action inputs that can return NaN and creates a no conditions option that is the default

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates snapshot

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Correctly show danger toast on update/create failures

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes rollup action nesting multiple ism_template keys

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes timeout/retry settings turning into uncontrolled inputs and NaN value

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Removes text transformation on inputs and updates isValid methods and passes to form labels

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes allocation and rollup adding UIAction properties to policy JSON on updates

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates release notes w/ new PR changes

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Wraps actions/transitions in states component and updates default rollup to include ism_rollup key

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
dbbaughe added a commit that referenced this pull request Sep 10, 2021
* Release 1.1.0.0 (#83)

* Release 1.1.0.0

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

* Correct copyright notices

* UI fixes for new ISM UI (#84)

* Removes X icon from action/transition flyout footer next to cancel

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds tooltips to edit/delete icon buttons on the draggable action/transition components

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Removes overlay for flyout so clicking outside doesn't close flyout and removes X close button on top right

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds edit/delete tooltips for state component and removes underline from hovering states

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Changes state flyout from X Close to Cancel

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds JSON editor for allocation action

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds isValid to action interface and implements in actions

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Correctly removes unused rollover keys from rollover object, handles uncontrolled inputs and NaN minDocs

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds error for state name already existing in policy

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes duplicated actions when editing as previously we had a new ID and matching logic didn't find an action

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes other action inputs that can return NaN and creates a no conditions option that is the default

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates snapshot

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Correctly show danger toast on update/create failures

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes rollup action nesting multiple ism_template keys

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes timeout/retry settings turning into uncontrolled inputs and NaN value

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Removes text transformation on inputs and updates isValid methods and passes to form labels

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes allocation and rollup adding UIAction properties to policy JSON on updates

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates release notes w/ new PR changes

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Wraps actions/transitions in states component and updates default rollup to include ism_rollup key

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes some small UI touchups/issues for new ISM UI (#85)

* Moves cancel secondary button next to primary on action/transition flyout

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Removes default ISM template and increases width of empty prompt

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds punctuation

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds back X icon next to cancel for state flyout

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Makes inputs in flyout full width, updates help text, and adds some spacing

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates transition default to not include conditions empty object, and on change transition to delete conditions when selecting none

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Moves edit button out of policy settings content panel and on to global page for view policy

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates release note

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes broken link

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes small issues on new ISM UI (#88)

* Fixes small issues on new ISM UI

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates snapshots

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates release notes

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates workflows to trigger on 1.* branches

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

Co-authored-by: Bowen Lan <62091230+bowenlan-amzn@users.noreply.github.com>
annie3431 added a commit that referenced this pull request Oct 19, 2021
* Rename plugin helper file

* Update TransformIndices.tsx

* Backport commits from main (#90)

* Release 1.1.0.0 (#83)

* Release 1.1.0.0

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

* Correct copyright notices

* UI fixes for new ISM UI (#84)

* Removes X icon from action/transition flyout footer next to cancel

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds tooltips to edit/delete icon buttons on the draggable action/transition components

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Removes overlay for flyout so clicking outside doesn't close flyout and removes X close button on top right

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds edit/delete tooltips for state component and removes underline from hovering states

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Changes state flyout from X Close to Cancel

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds JSON editor for allocation action

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds isValid to action interface and implements in actions

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Correctly removes unused rollover keys from rollover object, handles uncontrolled inputs and NaN minDocs

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds error for state name already existing in policy

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes duplicated actions when editing as previously we had a new ID and matching logic didn't find an action

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes other action inputs that can return NaN and creates a no conditions option that is the default

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates snapshot

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Correctly show danger toast on update/create failures

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes rollup action nesting multiple ism_template keys

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes timeout/retry settings turning into uncontrolled inputs and NaN value

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Removes text transformation on inputs and updates isValid methods and passes to form labels

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes allocation and rollup adding UIAction properties to policy JSON on updates

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates release notes w/ new PR changes

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Wraps actions/transitions in states component and updates default rollup to include ism_rollup key

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes some small UI touchups/issues for new ISM UI (#85)

* Moves cancel secondary button next to primary on action/transition flyout

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Removes default ISM template and increases width of empty prompt

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds punctuation

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds back X icon next to cancel for state flyout

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Makes inputs in flyout full width, updates help text, and adds some spacing

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates transition default to not include conditions empty object, and on change transition to delete conditions when selecting none

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Moves edit button out of policy settings content panel and on to global page for view policy

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates release note

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes broken link

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes small issues on new ISM UI (#88)

* Fixes small issues on new ISM UI

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates snapshots

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates release notes

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates workflows to trigger on 1.* branches

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

Co-authored-by: Bowen Lan <62091230+bowenlan-amzn@users.noreply.github.com>

* Support data filter when viewing sample data

* Update TransformOptions.tsx

* Add TransformService.test.ts

* Draft of date histogram panel

* Add helper method and move import

* Split calendar and fixed interval to 2 panels

* Add rendering test

* Add close popover test

* Update cypress-workflow.yml

* Update links.yml

* Update unit-tests-workflow.yml

* Update TransformOptions.tsx

* Update tests

* Update DateHistogramPanel.test.tsx

* Make scripted metrics editor larger

* Expand code editor related panels

* Undo changes to workflow

Signed-off-by: Annie Lee <leeyun@amazon.com>

* Update TimeAggregation.tsx

* Update DefineTransforms.tsx

undo changes to style

* Clean up code

* Update snapshot

Signed-off-by: Annie Lee <leeyun@amazon.com>

* Refactor the order of checking if name is defined before checking for duplicate name

* Update CreateTransformForm.tsx

* Update DefineTransforms.tsx

Signed-off-by: Annie Lee <leeyun@amazon.com>

* Update DefineTransforms.tsx

Signed-off-by: Annie Lee <leeyun@amazon.com>

* Update DefineTransforms.tsx

* Update DefineTransforms.tsx

* Update DefineTransforms.tsx

Co-authored-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Co-authored-by: Bowen Lan <62091230+bowenlan-amzn@users.noreply.github.com>
lobdelle added a commit that referenced this pull request Nov 5, 2021
* Fixes editing rollup delay (#82)

* Fixes editing the delay amount and displaying the schedule for rollups

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Bumps version to 1.2 (#103)

* Bumps version to 1.2

* Changes test workflows to follow Dashboards 1.x

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Fixes flakey tests (#105)

* Fixes flakey cypress test 'rollup enable and disable test'

* Fixes flakey unit test 'can delete a rollup job'

Signed-off-by: Robert Downs <downsrob@amazon.com>

* Fixed Transforms geo_point bug and boolean render (#93)

* Fixed Transforms geo_point bug and boolean render
* Set default DefineTransforms table render behavior to JSON.stringify
* Updated DefineTransforms null cell value check

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

* Transform bug fixes (#109)

* Rename plugin helper file

* Update TransformIndices.tsx

* Backport commits from main (#90)

* Release 1.1.0.0 (#83)

* Release 1.1.0.0

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

* Correct copyright notices

* UI fixes for new ISM UI (#84)

* Removes X icon from action/transition flyout footer next to cancel

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds tooltips to edit/delete icon buttons on the draggable action/transition components

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Removes overlay for flyout so clicking outside doesn't close flyout and removes X close button on top right

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds edit/delete tooltips for state component and removes underline from hovering states

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Changes state flyout from X Close to Cancel

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds JSON editor for allocation action

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds isValid to action interface and implements in actions

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Correctly removes unused rollover keys from rollover object, handles uncontrolled inputs and NaN minDocs

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds error for state name already existing in policy

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes duplicated actions when editing as previously we had a new ID and matching logic didn't find an action

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes other action inputs that can return NaN and creates a no conditions option that is the default

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates snapshot

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Correctly show danger toast on update/create failures

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes rollup action nesting multiple ism_template keys

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes timeout/retry settings turning into uncontrolled inputs and NaN value

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Removes text transformation on inputs and updates isValid methods and passes to form labels

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes allocation and rollup adding UIAction properties to policy JSON on updates

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates release notes w/ new PR changes

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Wraps actions/transitions in states component and updates default rollup to include ism_rollup key

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes some small UI touchups/issues for new ISM UI (#85)

* Moves cancel secondary button next to primary on action/transition flyout

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Removes default ISM template and increases width of empty prompt

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds punctuation

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Adds back X icon next to cancel for state flyout

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Makes inputs in flyout full width, updates help text, and adds some spacing

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates transition default to not include conditions empty object, and on change transition to delete conditions when selecting none

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Moves edit button out of policy settings content panel and on to global page for view policy

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates release note

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes broken link

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Fixes small issues on new ISM UI (#88)

* Fixes small issues on new ISM UI

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates snapshots

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates release notes

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Updates workflows to trigger on 1.* branches

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

Co-authored-by: Bowen Lan <62091230+bowenlan-amzn@users.noreply.github.com>

* Support data filter when viewing sample data

* Update TransformOptions.tsx

* Add TransformService.test.ts

* Draft of date histogram panel

* Add helper method and move import

* Split calendar and fixed interval to 2 panels

* Add rendering test

* Add close popover test

* Update cypress-workflow.yml

* Update links.yml

* Update unit-tests-workflow.yml

* Update TransformOptions.tsx

* Update tests

* Update DateHistogramPanel.test.tsx

* Make scripted metrics editor larger

* Expand code editor related panels

* Undo changes to workflow

Signed-off-by: Annie Lee <leeyun@amazon.com>

* Update TimeAggregation.tsx

* Update DefineTransforms.tsx

undo changes to style

* Clean up code

* Update snapshot

Signed-off-by: Annie Lee <leeyun@amazon.com>

* Refactor the order of checking if name is defined before checking for duplicate name

* Update CreateTransformForm.tsx

* Update DefineTransforms.tsx

Signed-off-by: Annie Lee <leeyun@amazon.com>

* Update DefineTransforms.tsx

Signed-off-by: Annie Lee <leeyun@amazon.com>

* Update DefineTransforms.tsx

* Update DefineTransforms.tsx

* Update DefineTransforms.tsx

Co-authored-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Co-authored-by: Bowen Lan <62091230+bowenlan-amzn@users.noreply.github.com>

* Fix the bugs in visual UI for legacy notification (#111)

* Transforms unit and cypress tests (#92)

* Transform cypress tests (#21)

* Added Cypress tests for Transforms UI

* License update

* Unit tests initial commit

* Added jest tests for Transforms, details, edit and create

* Sample transform fix

* Fixed cypress test transform and sample data load order

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

* Test fix debug

* Simplified unit test

* Updated transforms cypress test comments and success criteria

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

* Fixed quotation mark issue in test

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

* Removed debug mapping and index objects from unit test

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

* Cypress test improvements and completed edit transform unit test

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

* Integ test delete fix and EditTransforms jest test fix

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

* Restoring enable disable page refresh delay to fix failing integ test

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

* Resolve test constants conflict

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

* Fix pagination of managed indices page (#113)

* Disables jitter for managed_indices_spec Cypress tests (#122)

Signed-off-by: Robert Downs <downsrob@amazon.com>

Co-authored-by: Clay Downs <89109232+downsrob@users.noreply.github.com>
Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com>
Co-authored-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Co-authored-by: Bowen Lan <62091230+bowenlan-amzn@users.noreply.github.com>
Co-authored-by: Ravi <6005951+thalurur@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v1.1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants