Transforms unit and cypress tests #92

lobdelle · 2021-09-15T00:23:34Z

Description

Adds Cypress tests and Jest unit tests to transforms. Does not fully cover transforms, but adds some bare minimum tests.

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov-commenter · 2021-09-15T00:38:22Z

Codecov Report

❗ No coverage uploaded for pull request base (main@c1b76de). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage        ?   62.45%           
=======================================
  Files           ?      154           
  Lines           ?     4387           
  Branches        ?      682           
=======================================
  Hits            ?     2740           
  Misses          ?     1436           
  Partials        ?      211

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b76de...404557f. Read the comment docs.

cypress/integration/transforms_spec.js

dbbaughe · 2021-10-11T23:07:08Z

cypress/integration/transforms_spec.js

+        // Confirm we have our initial transform
+        cy.contains(TRANSFORM_ID);
+
+        // Disable transform


Does a transform need to be disabled to be deleted?

Yes, an exception is thrown otherwise.

cypress/integration/transforms_spec.js

public/pages/Transforms/containers/Transforms/EditTransform.test.tsx

annie3431 · 2021-10-12T20:52:57Z

Do we want to add "can successfully update transforms job" cypress test, too?

lobdelle · 2021-10-13T00:54:30Z

Do we want to add "can successfully update transforms job" cypress test, too?

Testing for this is present in the "can be edited" test. Updates to transforms are limited. If you mean updating the data and rerunning the job, I think it's better to save tests like that for when we put out continuous transforms, since right now each run is discrete and separate.

annie3431 · 2021-10-20T21:35:21Z

public/pages/CreateTransform/containers/CreateTransformForm/CreateTransformForm.test.tsx

+    userEvent.click(getByTestId("createTransformNextButton"));
+    await waitFor(() => {},{timeout:2000});
+
+    // Currently no pop up warnings?


I think there might be some inline error text that we can check. But knowing that it is still on step 1 is also fine.

annie3431 · 2021-10-20T21:41:57Z

public/pages/Transforms/containers/Transforms/EditTransform.test.tsx

+    await waitFor(() => getByText("Testing transform edit page"));
+  });
+
+  it("can edit description", async () => {


I see that you mentioned this test is incomplete. I think we can probably create a issue with the test cases that are not implemented but should be. Right here I think that we can add check to make sure that the fields such as name is read only.

That was on the previous revision, I made sure the test was actually testing what it needed to, because previously it just wasn't checking for anything it needed to. Checking for read-only fields would be a good future improvement for sure.

* Added Cypress tests for Transforms UI

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

* Fixes editing rollup delay (#82) * Fixes editing the delay amount and displaying the schedule for rollups Signed-off-by: Clay Downs <downsrob@amazon.com> * Bumps version to 1.2 (#103) * Bumps version to 1.2 * Changes test workflows to follow Dashboards 1.x Signed-off-by: Clay Downs <downsrob@amazon.com> * Fixes flakey tests (#105) * Fixes flakey cypress test 'rollup enable and disable test' * Fixes flakey unit test 'can delete a rollup job' Signed-off-by: Robert Downs <downsrob@amazon.com> * Fixed Transforms geo_point bug and boolean render (#93) * Fixed Transforms geo_point bug and boolean render * Set default DefineTransforms table render behavior to JSON.stringify * Updated DefineTransforms null cell value check Signed-off-by: Eric Lobdell <lobdelle@amazon.com> * Transform bug fixes (#109) * Rename plugin helper file * Update TransformIndices.tsx * Backport commits from main (#90) * Release 1.1.0.0 (#83) * Release 1.1.0.0 Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Correct copyright notices * UI fixes for new ISM UI (#84) * Removes X icon from action/transition flyout footer next to cancel Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Adds tooltips to edit/delete icon buttons on the draggable action/transition components Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Removes overlay for flyout so clicking outside doesn't close flyout and removes X close button on top right Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Adds edit/delete tooltips for state component and removes underline from hovering states Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Changes state flyout from X Close to Cancel Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Adds JSON editor for allocation action Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Adds isValid to action interface and implements in actions Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Correctly removes unused rollover keys from rollover object, handles uncontrolled inputs and NaN minDocs Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Adds error for state name already existing in policy Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes duplicated actions when editing as previously we had a new ID and matching logic didn't find an action Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes other action inputs that can return NaN and creates a no conditions option that is the default Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Updates snapshot Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Correctly show danger toast on update/create failures Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes rollup action nesting multiple ism_template keys Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes timeout/retry settings turning into uncontrolled inputs and NaN value Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Removes text transformation on inputs and updates isValid methods and passes to form labels Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes allocation and rollup adding UIAction properties to policy JSON on updates Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Updates release notes w/ new PR changes Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Wraps actions/transitions in states component and updates default rollup to include ism_rollup key Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes some small UI touchups/issues for new ISM UI (#85) * Moves cancel secondary button next to primary on action/transition flyout Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Removes default ISM template and increases width of empty prompt Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Adds punctuation Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Adds back X icon next to cancel for state flyout Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Makes inputs in flyout full width, updates help text, and adds some spacing Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Updates transition default to not include conditions empty object, and on change transition to delete conditions when selecting none Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Moves edit button out of policy settings content panel and on to global page for view policy Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Updates release note Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes broken link Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Fixes small issues on new ISM UI (#88) * Fixes small issues on new ISM UI Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Updates snapshots Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Updates release notes Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> * Updates workflows to trigger on 1.* branches Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> Co-authored-by: Bowen Lan <62091230+bowenlan-amzn@users.noreply.github.com> * Support data filter when viewing sample data * Update TransformOptions.tsx * Add TransformService.test.ts * Draft of date histogram panel * Add helper method and move import * Split calendar and fixed interval to 2 panels * Add rendering test * Add close popover test * Update cypress-workflow.yml * Update links.yml * Update unit-tests-workflow.yml * Update TransformOptions.tsx * Update tests * Update DateHistogramPanel.test.tsx * Make scripted metrics editor larger * Expand code editor related panels * Undo changes to workflow Signed-off-by: Annie Lee <leeyun@amazon.com> * Update TimeAggregation.tsx * Update DefineTransforms.tsx undo changes to style * Clean up code * Update snapshot Signed-off-by: Annie Lee <leeyun@amazon.com> * Refactor the order of checking if name is defined before checking for duplicate name * Update CreateTransformForm.tsx * Update DefineTransforms.tsx Signed-off-by: Annie Lee <leeyun@amazon.com> * Update DefineTransforms.tsx Signed-off-by: Annie Lee <leeyun@amazon.com> * Update DefineTransforms.tsx * Update DefineTransforms.tsx * Update DefineTransforms.tsx Co-authored-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> Co-authored-by: Bowen Lan <62091230+bowenlan-amzn@users.noreply.github.com> * Fix the bugs in visual UI for legacy notification (#111) * Transforms unit and cypress tests (#92) * Transform cypress tests (#21) * Added Cypress tests for Transforms UI * License update * Unit tests initial commit * Added jest tests for Transforms, details, edit and create * Sample transform fix * Fixed cypress test transform and sample data load order Signed-off-by: Eric Lobdell <lobdelle@amazon.com> * Test fix debug * Simplified unit test * Updated transforms cypress test comments and success criteria Signed-off-by: Eric Lobdell <lobdelle@amazon.com> * Fixed quotation mark issue in test Signed-off-by: Eric Lobdell <lobdelle@amazon.com> * Removed debug mapping and index objects from unit test Signed-off-by: Eric Lobdell <lobdelle@amazon.com> * Cypress test improvements and completed edit transform unit test Signed-off-by: Eric Lobdell <lobdelle@amazon.com> * Integ test delete fix and EditTransforms jest test fix Signed-off-by: Eric Lobdell <lobdelle@amazon.com> * Restoring enable disable page refresh delay to fix failing integ test Signed-off-by: Eric Lobdell <lobdelle@amazon.com> * Resolve test constants conflict Signed-off-by: Eric Lobdell <lobdelle@amazon.com> * Fix pagination of managed indices page (#113) * Disables jitter for managed_indices_spec Cypress tests (#122) Signed-off-by: Robert Downs <downsrob@amazon.com> Co-authored-by: Clay Downs <89109232+downsrob@users.noreply.github.com> Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com> Co-authored-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com> Co-authored-by: Bowen Lan <62091230+bowenlan-amzn@users.noreply.github.com> Co-authored-by: Ravi <6005951+thalurur@users.noreply.github.com>

lobdelle requested review from thalurur, dbbaughe and annie3431 September 15, 2021 00:23

annie3431 reviewed Sep 28, 2021

View reviewed changes

cypress/integration/transforms_spec.js Outdated Show resolved Hide resolved

annie3431 reviewed Sep 28, 2021

View reviewed changes

cypress/integration/transforms_spec.js Outdated Show resolved Hide resolved

annie3431 reviewed Sep 28, 2021

View reviewed changes

cypress/integration/transforms_spec.js Outdated Show resolved Hide resolved

lobdelle requested a review from annie3431 October 5, 2021 17:53

dbbaughe reviewed Oct 11, 2021

View reviewed changes

lobdelle requested a review from dbbaughe October 15, 2021 22:36

annie3431 reviewed Oct 20, 2021

View reviewed changes

annie3431 previously approved these changes Oct 20, 2021

View reviewed changes

lobdelle and others added 14 commits October 21, 2021 11:17

Transform cypress tests (opensearch-project#21)

5d6f1df

* Added Cypress tests for Transforms UI

License update

5a6ce89

Unit tests initial commit

dedde12

Added jest tests for Transforms, details, edit and create

a62fe8e

Sample transform fix

167b26a

Fixed cypress test transform and sample data load order

5f986df

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

Test fix debug

760d023

Simplified unit test

be4945d

Updated transforms cypress test comments and success criteria

9d471f2

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

Fixed quotation mark issue in test

80eb9a5

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

Removed debug mapping and index objects from unit test

5f0e138

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

Cypress test improvements and completed edit transform unit test

bfc3cf1

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

Integ test delete fix and EditTransforms jest test fix

28ebf18

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

Restoring enable disable page refresh delay to fix failing integ test

ae544f2

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

lobdelle dismissed annie3431’s stale review via ae544f2 October 21, 2021 18:26

lobdelle force-pushed the transforms-unit-tests branch from 404557f to ae544f2 Compare October 21, 2021 18:26

Resolve test constants conflict

fce4ef8

Signed-off-by: Eric Lobdell <lobdelle@amazon.com>

lobdelle requested a review from annie3431 October 21, 2021 19:38

annie3431 approved these changes Oct 21, 2021

View reviewed changes

lobdelle merged commit 784fc02 into opensearch-project:main Oct 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transforms unit and cypress tests #92

Transforms unit and cypress tests #92

lobdelle commented Sep 15, 2021

codecov-commenter commented Sep 15, 2021 •

edited

Loading

dbbaughe Oct 11, 2021

lobdelle Oct 13, 2021

annie3431 commented Oct 12, 2021

lobdelle commented Oct 13, 2021

annie3431 Oct 20, 2021

annie3431 Oct 20, 2021

lobdelle Oct 21, 2021

Transforms unit and cypress tests #92

Transforms unit and cypress tests #92

Conversation

lobdelle commented Sep 15, 2021

Description

Check List

codecov-commenter commented Sep 15, 2021 • edited Loading

Codecov Report

dbbaughe Oct 11, 2021

Choose a reason for hiding this comment

lobdelle Oct 13, 2021

Choose a reason for hiding this comment

annie3431 commented Oct 12, 2021

lobdelle commented Oct 13, 2021

annie3431 Oct 20, 2021

Choose a reason for hiding this comment

annie3431 Oct 20, 2021

Choose a reason for hiding this comment

lobdelle Oct 21, 2021

Choose a reason for hiding this comment

codecov-commenter commented Sep 15, 2021 •

edited

Loading