Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] Adds build support for JDK 8 #301

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport edd12c4 from #297

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team March 10, 2022 18:28
@downsrob
Copy link
Contributor

This is the git log:

Author: Clay Downs <downsrob@amazon.com>
Date:   Thu Mar 10 10:28:02 2022 -0800

    Adds build support for JDK 8 (#297)
    
    * Adds java matrix to test and build workflow
    
    Signed-off-by: Robert Downs <downsrob@amazon.com>
    
    * Fixes JDK 8 error
    
    Signed-off-by: Robert Downs <downsrob@amazon.com>
    
    * Removes java 17 from matrix
    
    Signed-off-by: Robert Downs <downsrob@amazon.com>
    (cherry picked from commit edd12c4b9fa75b70ce2cac2e34bbfe9a0f093b94)

Did I do something wrong my signoff?

@downsrob
Copy link
Contributor

downsrob commented Mar 10, 2022

Can not find "Clay Downs <downsrob@amazon.com>", in ["Robert Downs <downsrob@amazon.com>", "Robert Downs <downsrob@amazon.com>", "Robert Downs <downsrob@amazon.com>"].
Guess I have an inconsistency somewhere

* Adds java matrix to test and build workflow

Signed-off-by: Robert Downs <downsrob@amazon.com>

* Fixes JDK 8 error

Signed-off-by: Robert Downs <downsrob@amazon.com>

* Removes java 17 from matrix

Signed-off-by: Robert Downs <downsrob@amazon.com>
(cherry picked from commit edd12c4)
Signed-off-by: Robert Downs <downsrob@amazon.com>
@downsrob downsrob force-pushed the backport/backport-297-to-1.x branch from cb8a876 to 57ae36a Compare March 10, 2022 18:36
@downsrob downsrob merged commit 71745ca into 1.x Mar 10, 2022
@downsrob downsrob deleted the backport/backport-297-to-1.x branch March 10, 2022 19:11
downsrob pushed a commit to downsrob/index-management that referenced this pull request Mar 10, 2022
…ject#301)

* Adds java matrix to test and build workflow

Signed-off-by: Robert Downs <downsrob@amazon.com>

* Fixes JDK 8 error

Signed-off-by: Robert Downs <downsrob@amazon.com>

* Removes java 17 from matrix

Signed-off-by: Clay Downs <downsrob@amazon.com>
downsrob added a commit that referenced this pull request Mar 10, 2022
* Adds java matrix to test and build workflow

Signed-off-by: Robert Downs <downsrob@amazon.com>

* Fixes JDK 8 error

Signed-off-by: Robert Downs <downsrob@amazon.com>

* Removes java 17 from matrix

Signed-off-by: Clay Downs <downsrob@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants