Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds build support for JDK 8 (#297) (#301) #302

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Adds build support for JDK 8 (#297) (#301) #302

merged 1 commit into from
Mar 10, 2022

Conversation

downsrob
Copy link
Contributor

@downsrob downsrob commented Mar 10, 2022 •
edited
Loading

Issue #, if available:
#200

Description of changes:
Backports build support for JDK 8 to 1.3 branch

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-trigger-bot @downsrob
Adds build support for JDK 8 (opensearch-project#297) (opensearch-pro…
ddcf8c5 
…ject#301)

* Adds java matrix to test and build workflow

Signed-off-by: Robert Downs <downsrob@amazon.com>

* Fixes JDK 8 error

Signed-off-by: Robert Downs <downsrob@amazon.com>

* Removes java 17 from matrix

Signed-off-by: Clay Downs <downsrob@amazon.com>
@downsrob downsrob requested a review from a team March 10, 2022 19:14
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022 •
edited
Loading

Codecov Report

Merging #302 (ddcf8c5) into 1.3 (a05a5b9) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.3     #302      +/-   ##
============================================
- Coverage     75.71%   75.63%   -0.08%     
+ Complexity     2010     2009       -1     
============================================
  Files           253      253              
  Lines         11466    11466              
  Branches       1815     1815              
============================================
- Hits           8681     8672       -9     
- Misses         1758     1768      +10     
+ Partials       1027     1026       -1
Impacted Files Coverage Δ
...anagement/step/forcemerge/WaitForForceMergeStep.kt 32.50% <0.00%> (ø)
...statemanagement/model/destination/CustomWebhook.kt 65.21% <0.00%> (-27.54%) ⬇️
...management/indexstatemanagement/MetadataService.kt 56.55% <0.00%> (-0.82%) ⬇️
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 73.12% <0.00%> (+0.62%) ⬆️
...nt/rollup/action/stop/TransportStopRollupAction.kt 72.09% <0.00%> (+1.16%) ⬆️
...anagement/indexstatemanagement/model/Transition.kt 67.60% <0.00%> (+2.81%) ⬆️
.../rollup/action/start/TransportStartRollupAction.kt 69.76% <0.00%> (+3.48%) ⬆️
...nt/indexstatemanagement/model/destination/Slack.kt 54.54% <0.00%> (+13.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a05a5b9...ddcf8c5. Read the comment docs.

@downsrob downsrob merged commit dce7f9f into opensearch-project:1.3 Mar 10, 2022
@downsrob downsrob deleted the backports-jdk-8-to-13 branch March 10, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenlan-amzn bowenlan-amzn bowenlan-amzn approved these changes

@dbbaughe dbbaughe dbbaughe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@downsrob @codecov-commenter @dbbaughe @bowenlan-amzn