Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed recursion from Explain Action to avoid stackoverflow in some … #419

Merged
merged 1 commit into from
Jul 20, 2022
Merged

removed recursion from Explain Action to avoid stackoverflow in some … #419

merged 1 commit into from
Jul 20, 2022

Conversation

petardz
Copy link
Contributor

@petardz petardz commented Jul 19, 2022 •
edited by bowenlan-amzn
Loading

…situations

Signed-off-by: Petar Dzepina petar.dzepina@gmail.com

Issue #, if available:
#410
#414

Description of changes:
Removed recursion from Explain Action to avoid stack overflow bug when there's few hundreds+ managed indexes present
CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@petardz
removed recursion from Explain Action to avoid stackoverflow in some …
c7a4108 
…situations

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz petardz requested a review from a team July 19, 2022 19:01
@downsrob
Copy link
Contributor

Looks great Petar, thanks!

getsaurabh02
getsaurabh02 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@getsaurabh02 getsaurabh02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. This looks much cleaner and simpler now.
Also, lets follow up separately on a new issue to discuss the potential alternatives to the TransportManagedIndexAction as suggested in the previous comment.

...arch/indexmanagement/indexstatemanagement/transport/action/explain/TransportExplainAction.kt
for (i in 0 until indexNames.count()) {
val request = ManagedIndexRequest().indices(indexNames[i])
try {
client.suspendUntil<NodeClient, AcknowledgedResponse> { execute(ManagedIndexAction.INSTANCE, request, it) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this will solve the stack overflow issue, I still see the multiple calls for TransportManagedIndexAction for every index as a potential problem and bottleneck for the clusters with large number of indices. It could still block the primary (transport) worker thread until all the transport action calls succeeds or fails for every index and could lead to starvation issue.

The non operational transport action that is used by ISM to check if the user has required index permissions to manage index in form of TransportManagedIndexAction seems to be a workaround due to lack of better ways for mapping user permission with indices.

I will prefer instrumenting some cleaner and direct ways of identifying index permissions for the user. This is outside the scope of this PR, but we should open an issue and follow up separately on the possible approaches.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #422 so that we don't miss out on this and look into this at priority.

cc: @qreshi @downsrob @petardz @praveensameneni

praveensameneni
praveensameneni approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@praveensameneni praveensameneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@downsrob downsrob merged commit 76de976 into opensearch-project:main Jul 20, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 20, 2022
@petardz @github-actions
Removed recursion from Explain Action to avoid stackoverflow in some …
76f912d 
…situations (#419)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 76de976)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 20, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 20, 2022
@petardz @github-actions
Removed recursion from Explain Action to avoid stackoverflow in some …
fcca884 
…situations (#419)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 76de976)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 20, 2022
Merged
downsrob pushed a commit that referenced this pull request Jul 20, 2022
@petardz @downsrob
Removed recursion from Explain Action to avoid stackoverflow in some …
387e49c 
…situations (#419)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 76de976)
downsrob pushed a commit that referenced this pull request Jul 20, 2022
@petardz @downsrob
Removed recursion from Explain Action to avoid stackoverflow in some …
1cd61ed 
…situations (#419)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 76de976)
@getsaurabh02 getsaurabh02 mentioned this pull request Jul 20, 2022
Open
bowenlan-amzn pushed a commit that referenced this pull request Jul 21, 2022
@opensearch-trigger-bot @petardz
Removed recursion from Explain Action to avoid stackoverflow in some …
4df1b41 
…situations (#419) (#420)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 76de976)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
bowenlan-amzn pushed a commit that referenced this pull request Jul 21, 2022
@opensearch-trigger-bot @petardz
Removed recursion from Explain Action to avoid stackoverflow in some …
b63320b 
…situations (#419) (#421)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 76de976)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
opensearch-trigger-bot bot added a commit that referenced this pull request Jul 21, 2022
@opensearch-trigger-bot @github-actions
Removed recursion from Explain Action to avoid stackoverflow in some …
b02148a 
…situations (#419) (#420)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 76de976)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 4df1b41)
opensearch-trigger-bot bot added a commit that referenced this pull request Jul 21, 2022
@opensearch-trigger-bot @github-actions
Removed recursion from Explain Action to avoid stackoverflow in some …
07f15e8 
…situations (#419) (#421)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 76de976)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit b63320b)
opensearch-trigger-bot bot added a commit that referenced this pull request Jul 21, 2022
@opensearch-trigger-bot @github-actions
Removed recursion from Explain Action to avoid stackoverflow in some …
bb47686 
…situations (#419) (#421)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 76de976)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit b63320b)
downsrob pushed a commit that referenced this pull request Jul 27, 2022
@opensearch-trigger-bot
Removed recursion from Explain Action to avoid stackoverflow in some …
abce93b 
…situations (#419) (#421) (#425)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 76de976)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit b63320b)

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
downsrob pushed a commit that referenced this pull request Jul 27, 2022
@opensearch-trigger-bot
Removed recursion from Explain Action to avoid stackoverflow in some …
f8113ce 
…situations (#419) (#420) (#424)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 76de976)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 4df1b41)

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
bowenlan-amzn pushed a commit that referenced this pull request Jul 28, 2022
@opensearch-trigger-bot
Removed recursion from Explain Action to avoid stackoverflow in some …
9d34598 
…situations (#419) (#421) (#426)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 76de976)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit b63320b)

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
ronnaksaxena pushed a commit to ronnaksaxena/index-management that referenced this pull request Jul 29, 2022
@petardz @ronnaksaxena
Removed recursion from Explain Action to avoid stackoverflow in some …
35c5d2f 
…situations (opensearch-project#419)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Ronnak Saxena <ronsax@amazon.com>
jowg-amazon pushed a commit to jowg-amazon/index-management that referenced this pull request Aug 18, 2022
@petardz @jowg-amazon
Removed recursion from Explain Action to avoid stackoverflow in some …
60edc73 
…situations (opensearch-project#419)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>
Angie-Zhang pushed a commit to Angie-Zhang/index-management that referenced this pull request Sep 12, 2022
@opensearch-trigger-bot @petardz
Removed recursion from Explain Action to avoid stackoverflow in some …
dcc83db 
…situations (opensearch-project#419) (opensearch-project#421)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 76de976)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Angie Zhang <langelzh@amazon.com>
Angie-Zhang added a commit that referenced this pull request Oct 14, 2022
@jowg-amazon @petardz
@Angie-Zhang @stevanbz @xluo-aws @bowenlan-amzn @opensearch-trigger-bot @cwillum @deshsidd @lezzago @downsrob
Action Validation framework and Explain API integration (#441)
35b80e0 
* initial framework

Signed-off-by: Joanne Wang <jowg@amazon.com>

* Removed recursion from Explain Action to avoid stackoverflow in some situations (#419)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>

* enabled by default integrated

Signed-off-by: Joanne Wang <jowg@amazon.com>

* cleaned up comments and logs, created unit test and updated previous integration tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added delete validation logic

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed rollover validation unit tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added validation info field to ManagedIndexMetaData

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed step context as input

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added validationmetadata class

Signed-off-by: Joanne Wang <jowg@amazon.com>

* restored old integration tests and changed validation service output

Signed-off-by: Joanne Wang <jowg@amazon.com>

* before integrated validation meta data into managed index meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* integrated validation meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* working version

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added validation mapping

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed integ tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* renamed some values

Signed-off-by: Joanne Wang <jowg@amazon.com>

* before removing from managed index meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* created validation result object in explain

Signed-off-by: Joanne Wang <jowg@amazon.com>

* testing

Signed-off-by: Joanne Wang <jowg@amazon.com>

* run fails

Signed-off-by: Joanne Wang <jowg@amazon.com>

* integration test for delete + added framework for force merge

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed step validation metadata and still testing explain results

Signed-off-by: Joanne Wang <jowg@amazon.com>

* before removing from managed index runner

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed from managed index runner

Signed-off-by: Joanne Wang <jowg@amazon.com>

* clean up and tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* all validation tests pass

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed validation result from all managed index meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* restored old IT tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed it tests, set explain validation to false

Signed-off-by: Joanne Wang <jowg@amazon.com>

* clean up

Signed-off-by: Joanne Wang <jowg@amazon.com>

* Change test page size to avoid index/search TimeInMillis < 1 issue. (#460)

* Change test page size to avoid indexTimeInMillis < 1 issue.

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Change test page size to avoid indexTimeInMillis < 1 issue.

Signed-off-by: Angie Zhang <langelzh@amazon.com>

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Transform maxclauses fix (#477)

* transform maxClauses fix

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* added bucket log to track processed buckets

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* various renames/changes

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* fixed detekt issues

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* added comments to test

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* removed debug logging

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* empty commit to trigger checks

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reduced pageSize to 1 in few ITs to avoid flaky tests; fixed bug where pagesProcessed was calculated incorrectly

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reverted pagesProcessed change; fixed few ITs

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* 483: Updated detekt plugin and snakeyaml dependency. Updated a code t… (#485)

* 483: Updated detekt plugin and snakeyaml dependency. Updated a code to reduce the number of issues after static analysis

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* 483: Updated snakeyaml version to use the latest

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* Remove HOST_DENY_LIST usage as Notification plugin will own it (#471)

(#107)

Signed-off-by: Xuesong Luo <lxuesong@amazon.com>

Signed-off-by: Xuesong Luo <lxuesong@amazon.com>

* Disable detekt because of the CVE (#497)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

* Deprecate Master nonmenclature (#501)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

* [AUTO] Increment version to 2.3.0-SNAPSHOT (#484) (#503)

* fix#921-README-forum-link-index_mgmnt (#499)

Signed-off-by: cwillum <cwmmoore@amazon.com>

Signed-off-by: cwillum <cwmmoore@amazon.com>

* 64: Added rounding when using aggreagate script for avg metric. Added… (#490)

* 64: Added rounding when using aggreagate script for avg metric. Added unit tests for checking average aggregations against the target rollup index

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* 64: Rollup job renamed

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* 64: Removed unrelevant metrics for the avg calculation test

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* Revert Disable detekt and force choose snakeyml 1.32 (#528)

* Revert Disable detekt: 50ac1e9

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Remove force choosing snakeyml 1.31

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Force snakeyaml 1.32

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Empty commit

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Added 2.3 release note (#507) (#515) (#517)

* Update 2.3 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Update 2.3 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Update 2.3 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Update 2.3 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Update 2.3 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

Signed-off-by: Angie Zhang <langelzh@amazon.com>
(cherry picked from commit d9793ac)
Signed-off-by: Angie Zhang <langelzh@amazon.com>

Signed-off-by: Angie Zhang <langelzh@amazon.com>
(cherry picked from commit 7217b5b)

Co-authored-by: Angie Zhang <langelzh@amazon.com>

* Add 2.2 release note (#450) (#452) (#516)

* Add 2.2 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Add 2.2 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

Co-authored-by: Angie Zhang <langelzh@amazon.com>
(cherry picked from commit 8eb5da6)
Signed-off-by: Angie Zhang <langelzh@amazon.com>

Signed-off-by: Angie Zhang <langelzh@amazon.com>
Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>

* Adds plugin version sweep background job (#434)

* [207]: Added 5 min scheduled job for sweeping ISM plugin version in the case of version discrepancy

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* [207]: Created pluginVersionSweepCoordinator component responsible for scheduling the skip execution task. Annotated tests in order to prevent thread leak error during integrational tests

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* [207]: Increased retry period for background job that sets the skip flag up to 5 mins

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* Empty-Commit

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Co-authored-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* flaky transform test fix attempt (#542)

* flaky transform test fix attempt

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

* accidental paste fix

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com>

Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Angie Zhang <langelzh@amazon.com>
Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Signed-off-by: Xuesong Luo <lxuesong@amazon.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Co-authored-by: Petar <petar.dzepina@gmail.com>
Co-authored-by: Angie Zhang <98716549+Angie-Zhang@users.noreply.github.com>
Co-authored-by: Stevan Buzejic <30922513+stevanbz@users.noreply.github.com>
Co-authored-by: xluo-aws <109580118+xluo-aws@users.noreply.github.com>
Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
Co-authored-by: Siddhant Deshmukh <deshsid@amazon.com>
Co-authored-by: Angie Zhang <langelzh@amazon.com>
Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
Co-authored-by: Clay Downs <downsrob@amazon.com>
Co-authored-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com>
bowenlan-amzn pushed a commit that referenced this pull request Nov 3, 2022
@jowg-amazon @petardz
Error prevention stage 1 (#579)
2438f48 
* initial framework

Signed-off-by: Joanne Wang <jowg@amazon.com>

* Removed recursion from Explain Action to avoid stackoverflow in some situations (#419)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>

* enabled by default integrated

Signed-off-by: Joanne Wang <jowg@amazon.com>

* cleaned up comments and logs, created unit test and updated previous integration tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added delete validation logic

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed rollover validation unit tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added validation info field to ManagedIndexMetaData

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed step context as input

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added validationmetadata class

Signed-off-by: Joanne Wang <jowg@amazon.com>

* restored old integration tests and changed validation service output

Signed-off-by: Joanne Wang <jowg@amazon.com>

* before integrated validation meta data into managed index meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* integrated validation meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* working version

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added validation mapping

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed integ tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* renamed some values

Signed-off-by: Joanne Wang <jowg@amazon.com>

* before removing from managed index meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* created validation result object in explain

Signed-off-by: Joanne Wang <jowg@amazon.com>

* testing

Signed-off-by: Joanne Wang <jowg@amazon.com>

* run fails

Signed-off-by: Joanne Wang <jowg@amazon.com>

* integration test for delete + added framework for force merge

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed step validation metadata and still testing explain results

Signed-off-by: Joanne Wang <jowg@amazon.com>

* before removing from managed index runner

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed from managed index runner

Signed-off-by: Joanne Wang <jowg@amazon.com>

* clean up and tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* all validation tests pass

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed validation result from all managed index meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* restored old IT tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed it tests, set explain validation to false

Signed-off-by: Joanne Wang <jowg@amazon.com>

* clean up

Signed-off-by: Joanne Wang <jowg@amazon.com>

* Implemented replica_count, open, read_only, read_write

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Implemented replica_count, open, read_only, read_write

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Fix Test cases

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Fix Test cases

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Fix messages

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Fix comments; set validation disabled by default

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Rename validation_service to action_validation; Fix some detekt issues

Signed-off-by: Angie Zhang <langelzh@amazon.com>

Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Angie Zhang <langelzh@amazon.com>
Co-authored-by: Joanne Wang <jowg@amazon.com>
Co-authored-by: Petar <petar.dzepina@gmail.com>
Co-authored-by: Joanne Wang <109310487+jowg-amazon@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 3, 2022
@github-actions
Error prevention stage 1 (#579)
24ba24d 
* initial framework

Signed-off-by: Joanne Wang <jowg@amazon.com>

* Removed recursion from Explain Action to avoid stackoverflow in some situations (#419)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>

* enabled by default integrated

Signed-off-by: Joanne Wang <jowg@amazon.com>

* cleaned up comments and logs, created unit test and updated previous integration tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added delete validation logic

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed rollover validation unit tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added validation info field to ManagedIndexMetaData

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed step context as input

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added validationmetadata class

Signed-off-by: Joanne Wang <jowg@amazon.com>

* restored old integration tests and changed validation service output

Signed-off-by: Joanne Wang <jowg@amazon.com>

* before integrated validation meta data into managed index meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* integrated validation meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* working version

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added validation mapping

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed integ tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* renamed some values

Signed-off-by: Joanne Wang <jowg@amazon.com>

* before removing from managed index meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* created validation result object in explain

Signed-off-by: Joanne Wang <jowg@amazon.com>

* testing

Signed-off-by: Joanne Wang <jowg@amazon.com>

* run fails

Signed-off-by: Joanne Wang <jowg@amazon.com>

* integration test for delete + added framework for force merge

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed step validation metadata and still testing explain results

Signed-off-by: Joanne Wang <jowg@amazon.com>

* before removing from managed index runner

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed from managed index runner

Signed-off-by: Joanne Wang <jowg@amazon.com>

* clean up and tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* all validation tests pass

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed validation result from all managed index meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* restored old IT tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed it tests, set explain validation to false

Signed-off-by: Joanne Wang <jowg@amazon.com>

* clean up

Signed-off-by: Joanne Wang <jowg@amazon.com>

* Implemented replica_count, open, read_only, read_write

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Implemented replica_count, open, read_only, read_write

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Fix Test cases

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Fix Test cases

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Fix messages

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Fix comments; set validation disabled by default

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Rename validation_service to action_validation; Fix some detekt issues

Signed-off-by: Angie Zhang <langelzh@amazon.com>

Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Angie Zhang <langelzh@amazon.com>
Co-authored-by: Joanne Wang <jowg@amazon.com>
Co-authored-by: Petar <petar.dzepina@gmail.com>
Co-authored-by: Joanne Wang <109310487+jowg-amazon@users.noreply.github.com>
(cherry picked from commit 2438f48)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 3, 2022
@github-actions
Error prevention stage 1 (#579)
cdfcf15 
* initial framework

Signed-off-by: Joanne Wang <jowg@amazon.com>

* Removed recursion from Explain Action to avoid stackoverflow in some situations (#419)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>

* enabled by default integrated

Signed-off-by: Joanne Wang <jowg@amazon.com>

* cleaned up comments and logs, created unit test and updated previous integration tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added delete validation logic

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed rollover validation unit tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added validation info field to ManagedIndexMetaData

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed step context as input

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added validationmetadata class

Signed-off-by: Joanne Wang <jowg@amazon.com>

* restored old integration tests and changed validation service output

Signed-off-by: Joanne Wang <jowg@amazon.com>

* before integrated validation meta data into managed index meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* integrated validation meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* working version

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added validation mapping

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed integ tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* renamed some values

Signed-off-by: Joanne Wang <jowg@amazon.com>

* before removing from managed index meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* created validation result object in explain

Signed-off-by: Joanne Wang <jowg@amazon.com>

* testing

Signed-off-by: Joanne Wang <jowg@amazon.com>

* run fails

Signed-off-by: Joanne Wang <jowg@amazon.com>

* integration test for delete + added framework for force merge

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed step validation metadata and still testing explain results

Signed-off-by: Joanne Wang <jowg@amazon.com>

* before removing from managed index runner

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed from managed index runner

Signed-off-by: Joanne Wang <jowg@amazon.com>

* clean up and tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* all validation tests pass

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed validation result from all managed index meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* restored old IT tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed it tests, set explain validation to false

Signed-off-by: Joanne Wang <jowg@amazon.com>

* clean up

Signed-off-by: Joanne Wang <jowg@amazon.com>

* Implemented replica_count, open, read_only, read_write

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Implemented replica_count, open, read_only, read_write

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Fix Test cases

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Fix Test cases

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Fix messages

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Fix comments; set validation disabled by default

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Rename validation_service to action_validation; Fix some detekt issues

Signed-off-by: Angie Zhang <langelzh@amazon.com>

Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Angie Zhang <langelzh@amazon.com>
Co-authored-by: Joanne Wang <jowg@amazon.com>
Co-authored-by: Petar <petar.dzepina@gmail.com>
Co-authored-by: Joanne Wang <109310487+jowg-amazon@users.noreply.github.com>
(cherry picked from commit 2438f48)
khushbr pushed a commit that referenced this pull request Nov 3, 2022
@opensearch-trigger-bot @jowg-amazon @petardz
Error prevention stage 1 (#579) (#591)
5e75fff 
* Error prevention stage 1
* Removed recursion from Explain Action to avoid stackoverflow in some situations (#419)
* enabled by default integrated
* Fix Test cases
* Fix comments; set validation disabled by default
* Rename validation_service to action_validation; Fix some detekt issues

Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Angie Zhang <langelzh@amazon.com>

Co-authored-by: Joanne Wang <jowg@amazon.com>
Co-authored-by: Petar <petar.dzepina@gmail.com>
Co-authored-by: Angie Zhang <langelzh@amazon.com>
khushbr pushed a commit that referenced this pull request Nov 3, 2022
@opensearch-trigger-bot @jowg-amazon @petardz
Error prevention stage 1 (#579) (#592)
57544c3 
* Removed recursion from Explain Action to avoid stackoverflow in some situations (#419)
* enabled by default integrated
* Fix Test cases
* Fix comments; set validation disabled by default
* Rename validation_service to action_validation; Fix some detekt issues

Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Angie Zhang <langelzh@amazon.com>

Co-authored-by: Joanne Wang <jowg@amazon.com>
Co-authored-by: Petar <petar.dzepina@gmail.com>
Co-authored-by: Angie Zhang <langelzh@amazon.com>
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
@opensearch-trigger-bot @petardz
Removed recursion from Explain Action to avoid stackoverflow in some …
27f6a9f 
…situations (opensearch-project#419) (opensearch-project#421)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 76de976)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
@opensearch-trigger-bot @jowg-amazon @petardz
Error prevention stage 1 (opensearch-project#579) (opensearch-project…
be9afbc 
…#591)

* Error prevention stage 1
* Removed recursion from Explain Action to avoid stackoverflow in some situations (opensearch-project#419)
* enabled by default integrated
* Fix Test cases
* Fix comments; set validation disabled by default
* Rename validation_service to action_validation; Fix some detekt issues

Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Angie Zhang <langelzh@amazon.com>

Co-authored-by: Joanne Wang <jowg@amazon.com>
Co-authored-by: Petar <petar.dzepina@gmail.com>
Co-authored-by: Angie Zhang <langelzh@amazon.com>
@bowenlan-amzn bowenlan-amzn mentioned this pull request May 12, 2023
Closed
ronnaksaxena pushed a commit to ronnaksaxena/index-management that referenced this pull request Jul 19, 2023
@opensearch-trigger-bot @jowg-amazon
@petardz @ronnaksaxena
Error prevention stage 1 (opensearch-project#579) (opensearch-project…
d5e6bee 
…#591)

* Error prevention stage 1
* Removed recursion from Explain Action to avoid stackoverflow in some situations (opensearch-project#419)
* enabled by default integrated
* Fix Test cases
* Fix comments; set validation disabled by default
* Rename validation_service to action_validation; Fix some detekt issues

Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Angie Zhang <langelzh@amazon.com>

Co-authored-by: Joanne Wang <jowg@amazon.com>
Co-authored-by: Petar <petar.dzepina@gmail.com>
Co-authored-by: Angie Zhang <langelzh@amazon.com>
Signed-off-by: Ronnak Saxena <ronsax@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getsaurabh02 getsaurabh02 getsaurabh02 approved these changes

@downsrob downsrob downsrob approved these changes

@praveensameneni praveensameneni praveensameneni approved these changes

Assignees
No one assigned
Labels
backport 1.x backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petardz @downsrob @getsaurabh02 @praveensameneni