Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky transform test fix attempt #542

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

petardz
Copy link
Contributor

@petardz petardz commented Oct 4, 2022

Signed-off-by: Petar Dzepina petar.dzepina@vroom.com

Issue #, if available:

Description of changes:

Moved asserts inside waitFor block

TransformRunnerIT Integ test success run:

index-management % ./gradlew integTest -Dtests.class="*TransformRunnerIT"                              

> Configure project :
mixed cluster flag: false
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.4.2
  OS Info               : Mac OS X 12.6 (x86_64)
  JDK Version           : 17 (Zulu JDK)
  JAVA_HOME             : /Library/Java/JavaVirtualMachines/zulu-17.jdk/Contents/Home
  Random Testing Seed   : D705BCEBC3477413
  In FIPS 140 mode      : false
=======================================

> Task :integTest
OpenJDK 64-Bit Server VM warning: Ignoring option --illegal-access=warn; support was removed in 17.0

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.4.2/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 2m 37s
13 actionable tasks: 3 executed, 10 up-to-date

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Petar Dzepina added 2 commits October 4, 2022 21:46
Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
@petardz petardz requested a review from a team October 4, 2022 20:09
Copy link
Contributor

@khushbr khushbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this flaky test, Petar.

@khushbr khushbr merged commit 5217af0 into opensearch-project:main Oct 4, 2022
@deshsidd
Copy link
Contributor

deshsidd commented Oct 4, 2022

@petardz @khushbr @bowenlan-amzn
Can we backport this?

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 4, 2022
* flaky transform test fix attempt

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

* accidental paste fix

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com>
(cherry picked from commit 5217af0)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 4, 2022
* flaky transform test fix attempt

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

* accidental paste fix

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com>
(cherry picked from commit 5217af0)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 4, 2022
* flaky transform test fix attempt

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

* accidental paste fix

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com>
(cherry picked from commit 5217af0)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 4, 2022
* flaky transform test fix attempt

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

* accidental paste fix

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com>
(cherry picked from commit 5217af0)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-542-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5217af00af16de1482f504b56f0b8163d09bdb4e
# Push it to GitHub
git push --set-upstream origin backport/backport-542-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-542-to-1.3.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 4, 2022
* flaky transform test fix attempt

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

* accidental paste fix

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com>
(cherry picked from commit 5217af0)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-542-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5217af00af16de1482f504b56f0b8163d09bdb4e
# Push it to GitHub
git push --set-upstream origin backport/backport-542-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-542-to-1.x.

deshsidd pushed a commit to deshsidd/index-management that referenced this pull request Oct 4, 2022
* flaky transform test fix attempt

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

* accidental paste fix

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com>
(cherry picked from commit 5217af0)

Signed-off-by: Siddhant Deshmukh deshsid@amazon.com
@khushbr
Copy link
Contributor

khushbr commented Oct 4, 2022

@petardz @khushbr @bowenlan-amzn Can we backport this?

Agreed, added tags for backporting.

deshsidd pushed a commit to deshsidd/index-management that referenced this pull request Oct 4, 2022
* flaky transform test fix attempt

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

* accidental paste fix

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com>
(cherry picked from commit 5217af0)

Signed-off-by: Siddhant Deshmukh deshsid@amazon.com
deshsidd pushed a commit that referenced this pull request Oct 4, 2022
* flaky transform test fix attempt

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

* accidental paste fix

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com>
(cherry picked from commit 5217af0)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
khushbr pushed a commit that referenced this pull request Oct 5, 2022
* flaky transform test fix attempt
Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
khushbr pushed a commit that referenced this pull request Oct 5, 2022
* flaky transform test fix attempt
Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
bowenlan-amzn pushed a commit that referenced this pull request Oct 5, 2022
* flaky transform test fix attempt

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

* accidental paste fix

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com>
(cherry picked from commit 5217af0)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
bowenlan-amzn pushed a commit that referenced this pull request Oct 5, 2022
* flaky transform test fix attempt

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

* accidental paste fix

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com>
(cherry picked from commit 5217af0)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
bowenlan-amzn pushed a commit that referenced this pull request Oct 5, 2022
* flaky transform test fix attempt

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

* accidental paste fix

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com>
(cherry picked from commit 5217af0)

Signed-off-by: Siddhant Deshmukh deshsid@amazon.com

Signed-off-by: Siddhant Deshmukh deshsid@amazon.com
Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
Angie-Zhang added a commit that referenced this pull request Oct 14, 2022
* initial framework

Signed-off-by: Joanne Wang <jowg@amazon.com>

* Removed recursion from Explain Action to avoid stackoverflow in some situations (#419)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>

* enabled by default integrated

Signed-off-by: Joanne Wang <jowg@amazon.com>

* cleaned up comments and logs, created unit test and updated previous integration tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added delete validation logic

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed rollover validation unit tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added validation info field to ManagedIndexMetaData

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed step context as input

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added validationmetadata class

Signed-off-by: Joanne Wang <jowg@amazon.com>

* restored old integration tests and changed validation service output

Signed-off-by: Joanne Wang <jowg@amazon.com>

* before integrated validation meta data into managed index meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* integrated validation meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* working version

Signed-off-by: Joanne Wang <jowg@amazon.com>

* added validation mapping

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed integ tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* renamed some values

Signed-off-by: Joanne Wang <jowg@amazon.com>

* before removing from managed index meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* created validation result object in explain

Signed-off-by: Joanne Wang <jowg@amazon.com>

* testing

Signed-off-by: Joanne Wang <jowg@amazon.com>

* run fails

Signed-off-by: Joanne Wang <jowg@amazon.com>

* integration test for delete + added framework for force merge

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed step validation metadata and still testing explain results

Signed-off-by: Joanne Wang <jowg@amazon.com>

* before removing from managed index runner

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed from managed index runner

Signed-off-by: Joanne Wang <jowg@amazon.com>

* clean up and tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* all validation tests pass

Signed-off-by: Joanne Wang <jowg@amazon.com>

* removed validation result from all managed index meta data

Signed-off-by: Joanne Wang <jowg@amazon.com>

* restored old IT tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fixed it tests, set explain validation to false

Signed-off-by: Joanne Wang <jowg@amazon.com>

* clean up

Signed-off-by: Joanne Wang <jowg@amazon.com>

* Change test page size to avoid index/search TimeInMillis < 1 issue. (#460)

* Change test page size to avoid indexTimeInMillis < 1 issue.

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Change test page size to avoid indexTimeInMillis < 1 issue.

Signed-off-by: Angie Zhang <langelzh@amazon.com>

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Transform maxclauses fix (#477)

* transform maxClauses fix

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* added bucket log to track processed buckets

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* various renames/changes

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* fixed detekt issues

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* added comments to test

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* removed debug logging

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* empty commit to trigger checks

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reduced pageSize to 1 in few ITs to avoid flaky tests; fixed bug where pagesProcessed was calculated incorrectly

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reverted pagesProcessed change; fixed few ITs

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* 483: Updated detekt plugin and snakeyaml dependency. Updated a code t… (#485)

* 483: Updated detekt plugin and snakeyaml dependency. Updated a code to reduce the number of issues after static analysis

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* 483: Updated snakeyaml version to use the latest

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* Remove HOST_DENY_LIST usage as Notification plugin will own it (#471)

(#107)

Signed-off-by: Xuesong Luo <lxuesong@amazon.com>

Signed-off-by: Xuesong Luo <lxuesong@amazon.com>

* Disable detekt because of the CVE (#497)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

* Deprecate Master nonmenclature (#501)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

* [AUTO] Increment version to 2.3.0-SNAPSHOT (#484) (#503)

* fix#921-README-forum-link-index_mgmnt (#499)

Signed-off-by: cwillum <cwmmoore@amazon.com>

Signed-off-by: cwillum <cwmmoore@amazon.com>

* 64: Added rounding when using aggreagate script for avg metric. Added… (#490)

* 64: Added rounding when using aggreagate script for avg metric. Added unit tests for checking average aggregations against the target rollup index

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* 64: Rollup job renamed

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* 64: Removed unrelevant metrics for the avg calculation test

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* Revert Disable detekt and force choose snakeyml 1.32 (#528)

* Revert Disable detekt: 50ac1e9

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Remove force choosing snakeyml 1.31

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Force snakeyaml 1.32

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Empty commit

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Added 2.3 release note (#507) (#515) (#517)

* Update 2.3 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Update 2.3 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Update 2.3 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Update 2.3 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Update 2.3 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

Signed-off-by: Angie Zhang <langelzh@amazon.com>
(cherry picked from commit d9793ac)
Signed-off-by: Angie Zhang <langelzh@amazon.com>

Signed-off-by: Angie Zhang <langelzh@amazon.com>
(cherry picked from commit 7217b5b)

Co-authored-by: Angie Zhang <langelzh@amazon.com>

* Add 2.2 release note (#450) (#452) (#516)

* Add 2.2 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

* Add 2.2 release note

Signed-off-by: Angie Zhang <langelzh@amazon.com>

Co-authored-by: Angie Zhang <langelzh@amazon.com>
(cherry picked from commit 8eb5da6)
Signed-off-by: Angie Zhang <langelzh@amazon.com>

Signed-off-by: Angie Zhang <langelzh@amazon.com>
Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>

* Adds plugin version sweep background job (#434)

* [207]: Added 5 min scheduled job for sweeping ISM plugin version in the case of version discrepancy

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* [207]: Created pluginVersionSweepCoordinator component responsible for scheduling the skip execution task. Annotated tests in order to prevent thread leak error during integrational tests

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* [207]: Increased retry period for background job that sets the skip flag up to 5 mins

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* Empty-Commit

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Co-authored-by: Stevan Buzejic <buzejic.stevan@gmail.com>

* flaky transform test fix attempt (#542)

* flaky transform test fix attempt

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

* accidental paste fix

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com>

Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Angie Zhang <langelzh@amazon.com>
Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Signed-off-by: Xuesong Luo <lxuesong@amazon.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Co-authored-by: Petar <petar.dzepina@gmail.com>
Co-authored-by: Angie Zhang <98716549+Angie-Zhang@users.noreply.github.com>
Co-authored-by: Stevan Buzejic <30922513+stevanbz@users.noreply.github.com>
Co-authored-by: xluo-aws <109580118+xluo-aws@users.noreply.github.com>
Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
Co-authored-by: Siddhant Deshmukh <deshsid@amazon.com>
Co-authored-by: Angie Zhang <langelzh@amazon.com>
Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
Co-authored-by: Clay Downs <downsrob@amazon.com>
Co-authored-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com>
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
…-project#547)

* flaky transform test fix attempt

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

* accidental paste fix

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com>
(cherry picked from commit 5217af0)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
ronnaksaxena pushed a commit to ronnaksaxena/index-management that referenced this pull request Jul 19, 2023
…-project#547)

* flaky transform test fix attempt

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

* accidental paste fix

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>

Signed-off-by: Petar Dzepina <petar.dzepina@vroom.com>
Co-authored-by: Petar Dzepina <petar.dzepina@vroom.com>
(cherry picked from commit 5217af0)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Ronnak Saxena <ronsax@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants