Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added amazon rekognition as a trust endpoint #3419

Merged

Conversation

pyek-bot
Copy link
Contributor

@pyek-bot pyek-bot commented Jan 22, 2025

Description

Adds amazon rekognition url to trusted urls by default preventing user from having to manually add it to use the model.
I have also added (-fips) as an optional string to the regex based on the below link. Please suggest if this seems alright.

Reference: https://docs.aws.amazon.com/general/latest/gr/rekognition.html

Related Issues

Resolves #3308

Check List

  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
@pyek-bot
Copy link
Contributor Author

@mingshl Please update this tutorial accordingly, since user may not have to add to trust endpoint post 2.19: #3290

@pyek-bot pyek-bot had a problem deploying to ml-commons-cicd-env-require-approval January 22, 2025 21:27 — with GitHub Actions Failure
@pyek-bot pyek-bot temporarily deployed to ml-commons-cicd-env-require-approval January 22, 2025 21:27 — with GitHub Actions Inactive
@dhrubo-os
Copy link
Collaborator

Have you tested with making a prediction call if that works?

@pyek-bot pyek-bot closed this Jan 22, 2025
@pyek-bot pyek-bot reopened this Jan 22, 2025
@pyek-bot pyek-bot temporarily deployed to ml-commons-cicd-env-require-approval January 22, 2025 21:39 — with GitHub Actions Inactive
@pyek-bot pyek-bot had a problem deploying to ml-commons-cicd-env-require-approval January 22, 2025 21:39 — with GitHub Actions Failure
@pyek-bot
Copy link
Contributor Author

Have you tested with making a prediction call if that works?

I tried to create the connector with a rekognition url and it succeeded. I will validate the entire workflow once.

… on region

Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
@pyek-bot pyek-bot requested a deployment to ml-commons-cicd-env-require-approval January 22, 2025 21:50 — with GitHub Actions Waiting
@pyek-bot pyek-bot requested a deployment to ml-commons-cicd-env-require-approval January 22, 2025 21:50 — with GitHub Actions Waiting
Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
@pyek-bot pyek-bot requested a deployment to ml-commons-cicd-env-require-approval January 22, 2025 22:32 — with GitHub Actions Waiting
@pyek-bot pyek-bot requested a deployment to ml-commons-cicd-env-require-approval January 22, 2025 22:32 — with GitHub Actions Waiting
Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
@pyek-bot pyek-bot had a problem deploying to ml-commons-cicd-env-require-approval January 22, 2025 22:34 — with GitHub Actions Failure
@pyek-bot pyek-bot had a problem deploying to ml-commons-cicd-env-require-approval January 22, 2025 22:34 — with GitHub Actions Failure
@pyek-bot
Copy link
Contributor Author

Have you tested with making a prediction call if that works?

@dhrubo Successfully hit predict api without adding endpoint to trusted urls manually
I also added a test case to validate connector creation.

Screenshot 2025-01-22 at 2 38 30 PM

@b4sjoo
Copy link
Collaborator

b4sjoo commented Jan 22, 2025

Compilation fails

@pyek-bot
Copy link
Contributor Author

pyek-bot commented Jan 22, 2025

Compilation fails

Seems main is currently not compiling.
most recent build on main: https://github.com/opensearch-project/ml-commons/actions/runs/12918081497/job/36025940916

might be due to lucene upgrade

@pyek-bot
Copy link
Contributor Author

This PR should fix the issue: #3426

@pyek-bot pyek-bot had a problem deploying to ml-commons-cicd-env-require-approval January 24, 2025 00:18 — with GitHub Actions Failure
@pyek-bot pyek-bot had a problem deploying to ml-commons-cicd-env-require-approval January 24, 2025 00:18 — with GitHub Actions Failure
@pyek-bot
Copy link
Contributor Author

Failing due to unrelated changes

Tests with failures:
 - org.opensearch.ml.rest.RestMLRemoteInferenceIT.testPredictWithAutoDeployAndTTL_RemoteModel
111 tests completed, 1 failed, 10 skipped

@pyek-bot pyek-bot had a problem deploying to ml-commons-cicd-env-require-approval January 27, 2025 20:47 — with GitHub Actions Failure
mingshl
mingshl previously approved these changes Jan 27, 2025
Zhangxunmt
Zhangxunmt previously approved these changes Jan 27, 2025
@pyek-bot pyek-bot had a problem deploying to ml-commons-cicd-env-require-approval January 28, 2025 01:29 — with GitHub Actions Failure
Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
@pyek-bot pyek-bot dismissed stale reviews from Zhangxunmt and mingshl via 835cbf1 January 28, 2025 19:07
@b4sjoo
Copy link
Collaborator

b4sjoo commented Jan 28, 2025

spotless check?

Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
@pyek-bot pyek-bot had a problem deploying to ml-commons-cicd-env-require-approval January 28, 2025 19:12 — with GitHub Actions Failure
@pyek-bot pyek-bot temporarily deployed to ml-commons-cicd-env-require-approval January 28, 2025 19:12 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn merged commit 25e6c9a into opensearch-project:main Jan 28, 2025
7 of 8 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3419-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 25e6c9a279df16f4ff1c9a4bcb9e4cf5cd7af91c
# Push it to GitHub
git push --set-upstream origin backport/backport-3419-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3419-to-2.x.

pyek-bot added a commit to pyek-bot/ml-commons that referenced this pull request Jan 28, 2025
* feat: add rekognition trust endpoint

Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>

* refactor: consistent regex with previous connectors and looser checks on region

Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>

* test: add test case to validate connector creation successful

Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>

* chore: spotless apply

Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>

* chore: linter fixes

Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>

---------

Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
jngz-es pushed a commit that referenced this pull request Jan 28, 2025
…int (#3445)

* Added amazon rekognition as a trust endpoint (#3419)

* feat: add rekognition trust endpoint

Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>

* refactor: consistent regex with previous connectors and looser checks on region

Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>

* test: add test case to validate connector creation successful

Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>

* chore: spotless apply

Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>

* chore: linter fixes

Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>

---------

Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>

* fix: handle conflict due to deepseek changes

Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>

---------

Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Trust Endpoint for Rekognition
6 participants