[Backport 2.x] Manual backport for adding AWS Rekognition trust endpoint #3445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add rekognition trust endpoint Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * refactor: consistent regex with previous connectors and looser checks on region Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * test: add test case to validate connector creation successful Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * chore: spotless apply Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * chore: linter fixes Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> --------- Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
pyek-bot
requested review from
b4sjoo,
dhrubo-os,
mingshl,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
|
Not sure why spotless is failing, I have applied it, checking |
ylwu-amzn
approved these changes
Jan 28, 2025
ylwu-amzn
previously approved these changes
Jan 28, 2025
|
@pyek-bot , could you resolve the conflicts? |
Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com>
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
Conflict due to new merges, fixed it again |
jngz-es
approved these changes
Jan 28, 2025
|
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
I saw some other buildings with the same error here. It seems not related to this pr. |
Found this github issue related to this: diffplug/spotless#1783 |
This is also affecting my builds :( |
Zhangxunmt
approved these changes
Jan 28, 2025
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
pyek-bot
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes conflicts and backports PR that adds Amazon Rekognition as a trust endpoint
Main PR: #3419
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.