Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quick fix to Big5 Workload for integration tests #168

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

IanHoang
Copy link
Collaborator

Description

Integration Tests in OpenSearch Benchmark repository are failing due to the following error:

Error: _test.py::test_list_workloads[in-memory-it] [ERROR] Cannot list. Could not load '/home/runner/work/opensearch-benchmark/opensearch-benchmark/.benchmark/benchmarks/workloads/default/big5/workload.json': Expecting value: line 20 column 29 (char 412). Lines containing the error:

        {
          "source-url": "",
          "source-file": "documents.json",
          "document-count": ,
----------------------------^ Error is here
          "uncompressed-bytes": ,
          "compressed-bytes": 1

This PR adds some changes to get around this issue

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ian Hoang <hoangia@amazon.com>
@IanHoang IanHoang requested a review from gkamat as a code owner January 30, 2024 23:10
Copy link
Collaborator

@gkamat gkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@IanHoang IanHoang added the backport 2 Backport to the "2" branch label Jan 30, 2024
@IanHoang IanHoang merged commit 3b451ec into opensearch-project:main Jan 30, 2024
2 checks passed
@IanHoang IanHoang deleted the integration-test-fix branch January 30, 2024 23:11
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 30, 2024
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Co-authored-by: Ian Hoang <hoangia@amazon.com>
(cherry picked from commit 3b451ec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang pushed a commit that referenced this pull request Jan 30, 2024
(cherry picked from commit 3b451ec)

Signed-off-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ian Hoang <hoangia@amazon.com>
@gkamat gkamat added the backport 3 Backport to the "3" branch label Jan 31, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 31, 2024
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Co-authored-by: Ian Hoang <hoangia@amazon.com>
(cherry picked from commit 3b451ec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gkamat pushed a commit that referenced this pull request Jan 31, 2024
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Co-authored-by: Ian Hoang <hoangia@amazon.com>
(cherry picked from commit 3b451ec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link

The backport to 1 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1 1
# Navigate to the new working tree
pushd ../.worktrees/backport-1
# Create a new branch
git switch --create backport/backport-168-to-1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3b451ecb254a554674ea664023f5803ebf8a0d2b
# Push it to GitHub
git push --set-upstream origin backport/backport-168-to-1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1

Then, create a pull request where the base branch is 1 and the compare/head branch is backport/backport-168-to-1.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 2, 2024
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Co-authored-by: Ian Hoang <hoangia@amazon.com>
(cherry picked from commit 3b451ec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gkamat pushed a commit that referenced this pull request Mar 2, 2024
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Co-authored-by: Ian Hoang <hoangia@amazon.com>
(cherry picked from commit 3b451ec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/opensearch-benchmark-workloads that referenced this pull request Mar 5, 2024
…ect#168)

Signed-off-by: Ian Hoang <hoangia@amazon.com>
Co-authored-by: Ian Hoang <hoangia@amazon.com>
gkamat pushed a commit to gkamat/opensearch-benchmark-workloads that referenced this pull request Mar 20, 2024
…ect#168)

Signed-off-by: Ian Hoang <hoangia@amazon.com>
Co-authored-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Govind Kamat <govkamat@amazon.com>
gkamat pushed a commit to gkamat/opensearch-benchmark-workloads that referenced this pull request Mar 22, 2024
…ect#168)

Signed-off-by: Ian Hoang <hoangia@amazon.com>
Co-authored-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Govind Kamat <govkamat@amazon.com>
gkamat added a commit that referenced this pull request Mar 22, 2024
* Added the "big5" workload based on Elastic's comparison benchmark.

Signed-off-by: Govind Kamat <govkamat@amazon.com>

* Added license file to big5 workload and parameterized some fields.

Signed-off-by: Govind Kamat <govkamat@amazon.com>

* Add quick fix to Big5 Workload for integration tests (#168)

Signed-off-by: Ian Hoang <hoangia@amazon.com>
Co-authored-by: Ian Hoang <hoangia@amazon.com>
Signed-off-by: Govind Kamat <govkamat@amazon.com>

* Added a data corpus to the big5 workload and included several enhancements. (#199)

Signed-off-by: Govind Kamat <govkamat@amazon.com>

* Added attribution and change notification.

Signed-off-by: Govind Kamat <govkamat@amazon.com>

* Canonicalized big5 mapping files.

Signed-off-by: Govind Kamat <govkamat@amazon.com>

* Added support for a 100 GB corpus that models a more realistic time series. (#242)

Updated mappings and included several improvements.

Signed-off-by: Govind Kamat <govkamat@amazon.com>

---------

Signed-off-by: Govind Kamat <govkamat@amazon.com>
Signed-off-by: Ian Hoang <hoangia@amazon.com>
Co-authored-by: Ian Hoang <51065478+IanHoang@users.noreply.github.com>
Co-authored-by: Ian Hoang <hoangia@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1 backport 2 Backport to the "2" branch backport 3 Backport to the "3" branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants