Refactored alerting test, and added wait logic to reduce flakiness. (#…

…953) (#955)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
(cherry picked from commit 5db8065)

Co-authored-by: AWSHurneyt <hurneyt@amazon.com>

cypress/integration/plugins/alerting-dashboards-plugin/monitors_dashboard_spec.js

@@ -38,7 +38,7 @@ const clusterHealthMonitor = {
         severity: '1',
         condition: {
           script: {
-            source: 'ctx.results[0].status != "green"',
+            source: 'ctx.results[0].status != "blue"',
             lang: 'painless',
           },
         },
@@ -107,8 +107,13 @@ describe('Monitors dashboard page', () => {
   });
 
   it('Displays expected number of alerts', () => {
+    // Wait for table to finish loading
+    cy.get('tbody > tr').should(($tr) =>
+      expect($tr).to.have.length.greaterThan(1)
+    );
+
     // Ensure the 'Monitor name' column is sorted in ascending order by sorting another column first
-    cy.contains('Last updated by').click({ force: true });
+    cy.contains('Last notification time').click({ force: true });
     cy.contains('Monitor name').click({ force: true });
 
     testMonitors.forEach((entry) => {