Refactored alerting test, and added wait logic to reduce flakiness. #953
Conversation
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
| @@ -38,7 +38,7 @@ const clusterHealthMonitor = { | |||
| severity: '1', | |||
| condition: { | |||
| script: { | |||
| source: 'ctx.results[0].status != "green"', | |||
| source: 'ctx.results[0].status != "blue"', | |||
There was a problem hiding this comment.
For context, this was changed to blue because the test was failing when run against multinode clusters. The indexes used by the tests were only reliably in a yellow state on single node clusters because they were configured to have replicas. Rather than reconfigure the test indexes, it was less invasive for other tests to adjust the condition used by this test.
There was a problem hiding this comment.
Could we add comments of this change with the context,so we can understand in future when look back at this code piece
| // Ensure the 'Monitor name' column is sorted in ascending order by sorting another column first | ||
| cy.contains('Last updated by').click({ force: true }); | ||
| cy.contains('Last notification time').click({ force: true }); |
There was a problem hiding this comment.
For context, the Last updated by column was removed from this UI in PR opensearch-project/alerting-dashboards-plugin#767
|
Would someone be able to add the |
|
@Hailong-am @SuZhou-Joe |
…pensearch-project#953) Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Description
Refactored alerting test, and added wait logic to reduce flakiness.
The edited test passes locally.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.