Adding wrapper query, requirement for spring reactive #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ls-urs-keller
requested review from
reta,
Bukhtawar,
dblock,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Signed-off-by: Urs Keller <urs.keller@lightspeedhq.com>
ls-urs-keller
force-pushed
the
v2.1.0a
branch
from
8bea70b
to
b3b1224
Compare
|
If someone would be so kind to explain how to modify the "source" of the generated code I couldn't find it, or point me in the right direction. Thank you. |
|
@ls-urs-keller thanks for the fix, please add the test case for it (probably java-client/src/test/java/org/opensearch/client/opensearch/integTest/AbstractRequestIT.java is the best place right now), thank you |
|
@ls-urs-keller Thank you for the changes! Want to finish this PR? The code is not generated anymore and the related comments have been removed from the code. You can merge in the latest changes from the main branch. |
|
Done via #630 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm trying to port spring reactive to opensearch for one of our projects, it uses wrapper queries.
This is missing from the opensearch-java library.
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.