Add support for wrapper queries #630
Conversation
andrewparmet
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Signed-off-by: Andrew Parmet <andrew@parmet.com>
andrewparmet
force-pushed
the
add-wrapper-query
branch
from
9d0ce42
to
60812e2
Compare
| */ | ||
|
|
||
| /* | ||
| * Licensed to Elasticsearch B.V. under one or more contributor |
There was a problem hiding this comment.
The Elasticsearch header could be dropped, this is a new file, right?
There was a problem hiding this comment.
I suppose - I copied it from the other PR which has this header, so it's actually less clear that I can just drop it depending on where the other PR sourced the file.
|
@andrewparmet thank you for picking it up, would be great to have tests added for this change (and CHANGELOG entry) |
|
@reta Happy to - can you point me to the example test that most closely mirrors what you're looking for? Looks like most query variants don't have tests. |
Please check |
|
@andrewparmet could you please fix DCO ? (may need |
Signed-off-by: Andrew Parmet <andrew@parmet.com>
andrewparmet
force-pushed
the
add-wrapper-query
branch
from
8ba5998
to
e5e6ace
Compare
@reta Should be good to go! |
* add wrapperquery Signed-off-by: Andrew Parmet <andrew@parmet.com> * add changelog entry Signed-off-by: Andrew Parmet <andrew@parmet.com> * add test Signed-off-by: Andrew Parmet <andrew@parmet.com> --------- Signed-off-by: Andrew Parmet <andrew@parmet.com> (cherry picked from commit 626e99c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* add wrapperquery * add changelog entry * add test --------- (cherry picked from commit 626e99c) Signed-off-by: Andrew Parmet <andrew@parmet.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Adds support the wrapper query type. A rehash of #342, which appears to be abandoned.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.