Fix async client without http auth

[liran-cohen-hs]

Description

Fix for async connection that is used without http auth

Issues Resolved

Closes #283

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[dblock]

Makes sense. This needs a test, please?

[liran-cohen-hs]

Makes sense. This needs a test, please?

I tried to see where I can add a specific test
it seems that RequestsHttpConnection and AIOHttpConnection classes has a lot of tests which is great, but the bug was on AsyncHttpConnection which inherits AIOHttpConnection but has no tests
so I am not sure how to approach this (rather than adding a lot of tests for AsyncHttpConnection which not sure I have the time to invest in :))

[dblock]

Makes sense. This needs a test, please?

I tried to see where I can add a specific test it seems that RequestsHttpConnection and AIOHttpConnection classes has a lot of tests which is great, but the bug was on AsyncHttpConnection which inherits AIOHttpConnection but has no tests so I am not sure how to approach this (rather than adding a lot of tests for AsyncHttpConnection which not sure I have the time to invest in :))

Add just enough tests for AsyncHttpConnection that would fail for the bug you fix and write TODO: for everything else?

[liran-cohen-hs]

Makes sense. This needs a test, please?

I tried to see where I can add a specific test it seems that RequestsHttpConnection and AIOHttpConnection classes has a lot of tests which is great, but the bug was on AsyncHttpConnection which inherits AIOHttpConnection but has no tests so I am not sure how to approach this (rather than adding a lot of tests for AsyncHttpConnection which not sure I have the time to invest in :))

Add just enough tests for AsyncHttpConnection that would fail for the bug you fix and write TODO: for everything else?

added another commit with the test
I focused on the E2E rather on the mock tests, since the mock can potentially skip the fixed code

[dblock]

Makes sense. This needs a test, please?

I tried to see where I can add a specific test it seems that RequestsHttpConnection and AIOHttpConnection classes has a lot of tests which is great, but the bug was on AsyncHttpConnection which inherits AIOHttpConnection but has no tests so I am not sure how to approach this (rather than adding a lot of tests for AsyncHttpConnection which not sure I have the time to invest in :))

Add just enough tests for AsyncHttpConnection that would fail for the bug you fix and write TODO: for everything else?

added another commit with the test I focused on the E2E rather on the mock tests, since the mock can potentially skip the fixed code

I commented out the code change and none of the tests failed - I was running ./.ci/run-tests true 2.3.0. Also is there an easier way to run these?

[saimedhi]

Hello @liran-cohen-hs, httpbin has been replaced with http server in the following PR. Please use http server instead of httpbin for testing. Thanks :)

[dblock]

Right on! @liran-cohen-hs this should be a lot easier to finish now, hope you have time to pick it up! Happy to help.

[saimedhi]

@liran-cohen-hs, Kindly complete the pull request. Thanks for raising the initial PR :)

[dblock]

@dannosaur - was this fixed by #424?

[dannosaur]

@dblock yup.