Fixed flaky CI tests by replacing httpbin with a simple http server #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimedhi
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor and
Shephalimittal
as code owners
Codecov Report
@@ Coverage Diff @@
## main #395 +/- ##
==========================================
+ Coverage 71.44% 71.57% +0.12%
==========================================
Files 77 77
Lines 7190 7190
==========================================
+ Hits 5137 5146 +9
+ Misses 2053 2044 -9
|
harshavamsi
previously approved these changes
May 17, 2023
dblock
requested changes
May 18, 2023
test_opensearchpy/http_server.py
Outdated
| self._server_thread = threading.Thread(target=self.serve_forever) | ||
| self._server_thread.start() | ||
|
|
||
| def stop(self): |
There was a problem hiding this comment.
This creates two shutdown() methods, which is weird. Overwrite shutdown or use an instance of HTTPServer instead of overriding it.
There was a problem hiding this comment.
while overwriting shutdown I am getting "recursionerror: maximum recursion depth exceeded while calling a python object". So I left it as stop method.
dblock
requested changes
May 18, 2023
Signed-off-by: saimedhi <saimedhi@amazon.com>
saimedhi
force-pushed
the
replacing_httpbin_with_httpserver
branch
from
6554a47 to
d68f37c
Compare
dblock
approved these changes
May 23, 2023
|
👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed flaky CI tests by replacing httpbin with a simple http server
Issues Resolved
Closes #327
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.