Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up the developer guide. #388

Merged
merged 1 commit into from
May 30, 2023

Conversation

dblock
Copy link
Member

@dblock dblock commented May 15, 2023

Description

Took me some time to figure out how to run tests.
A small cleanup of the dev guide.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #388 (a1052dd) into main (2abb8c4) will increase coverage by 0.59%.
The diff coverage is 100.00%.

❗ Current head a1052dd differs from pull request most recent head 87f35d8. Consider uploading reports for the commit 87f35d8 to get more accurate results

@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
+ Coverage   71.44%   72.04%   +0.59%     
==========================================
  Files          77       77              
  Lines        7190     7190              
==========================================
+ Hits         5137     5180      +43     
+ Misses       2053     2010      -43     
Impacted Files Coverage Δ
opensearchpy/_async/http_aiohttp.py 82.81% <100.00%> (+3.12%) ⬆️

... and 16 files with indirect coverage changes

@dblock dblock added the skip-changelog Skips changelog verifier label May 15, 2023
Signed-off-by: dblock <dblock@amazon.com>
@VachaShah
Copy link
Collaborator

VachaShah commented May 18, 2023

The macos tests seem to be failing overall in the repo for TestConnectionHttpbin.test_urllib3_connection, @dblock any insights?

Copy link
Collaborator

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saimedhi
Copy link
Collaborator

saimedhi commented May 24, 2023

The macos tests seem to be failing overall in the repo for TestConnectionHttpbin.test_urllib3_connection, @dblock any insights?

Httpbin is replaced with Http server in this PR. So, now tests will not fail if this branch is synced with main.

@dblock dblock merged commit b4c000a into opensearch-project:main May 30, 2023
@dblock dblock deleted the developer-guide branch May 30, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog verifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants