-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling auto-generated protobuf files #23
Comments
I think the question is whether these files are part of source code, or part of generated files at build time. Your tl;dr says it's the latter, which means we should build them as part of |
An added complication of build time, however, is that Given how little (if ever) these files are going to change, I'm fine with pre-building them. It's more of a question of how much we should touch them with additional automation. |
IMO, since these are generated files we should make sure they have a this is generated header and otherwise not touch them. coverage-wise though they should be used, otherwise they aren’t useful files and shouldn’t exist |
In #54 (comment) we suggest removing the lines of generating proto files from CI and documenting how to update them. |
While reviewing our code coverage I noticed the majority of our uncovered lines (57 of 102) are in the
protobuf
subdirectory.Initial question: should we exclude these files from coverage (I think so).
Follow-up question: Where else should (or shouldn't) we exclude the auto-generated files?
TLDR:
The text was updated successfully, but these errors were encountered: