Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for most of the uncovered lines.
(To be fair, that report includes test lines, so it's not quite that good. 🤷 )
From the CI test:
codecov/project — 93.44% (+1.90%) compared to c31b5b8
Misses are:
pass
on an abstract method (can't test)StreamInput.read_array_size()
, the size is read as a v_int which cannot be negative, so the exception on negative array size branch of code is unreachable (the test is there to catch integer overflow in Java, should it be removed?)InvalidTraceDataFormat
in the netty tests all based on valid logs (why are we including test files in test coverage?)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.