Remove protoc compiling from CI

[dbwiddis]

Description

Since protobuf autogenerated files change rarely (if ever) and require a few extra steps beyond compiling, it's better to not use them in the build. Instructions for the rare case of needing to recompile are added to the Developer Guide

Issues Resolved

Fixes #23

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

Merging #59 (35c9ecf) into main (7dc19ea) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #59   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        55           
  Lines         1462      1462           
=========================================
  Hits          1462      1462           

see 2 files with indirect coverage changes

[dblock]

How about adding a poetry exec proto (pyproject.toml) for these commands and note in dev guide?

[dblock]

It would be nice to explain what these are a little better, with maybe a link to where the files come from in OpenSearch core?

[dbwiddis]

It would be nice to explain what these are a little better,

The link to protobuf.dev is pretty clear on the messages.

with maybe a link to where the files come from in OpenSearch core?

Good idea, I'll add.

[dbwiddis]

How about adding a poetry exec proto (pyproject.toml) for these commands and note in dev guide?

These are done rarely enough it's not worth automating.

[dblock]

These are done rarely enough it's not worth automating.

I won't argue. IMHO copy-pasting from developer guide line by line is annoying, and we're going to be reaching to the code that you're deleting here so I don't have to turn my brain on to generate these files in a few months. Especially the | xargs sed -i.bak -E 's/(USE_C_DESCRIPTORS == False:)/\1 # pragma: no cover/g' part that I am 100% sure the contributor will forget after reading "Add # pragma: no cover to the conditional test" which nobody will know the meaning or the reason for ;)

[dblock]

These are done rarely enough it's not worth automating.

I won't argue. IMHO copy-pasting from developer guide line by line is annoying, and we're going to be reaching to the code that you're deleting here so I don't have to turn my brain on to generate these files in a few months. Especially the | xargs sed -i.bak -E 's/(USE_C_DESCRIPTORS == False:)/\1 # pragma: no cover/g' part that I am 100% sure the contributor will forget after reading "Add # pragma: no cover to the conditional test" which nobody will know the meaning or the reason for ;)