Revert "[Remove] MainResponse version override cluster setting (#3031) (#3032)" #3530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nknize
added
backwards-compatibility
Clients
…earch-project#3031) (opensearch-project#3032)" This reverts commit 199fbb8. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize
force-pushed
the
revert/mainResponseVersionSpoof2.x
branch
from
f9a154b to
61403f0
Compare
|
@nknize thanks for this PR. |
|
@saratvemulapalli @alicejw-aws: Looks like https://opensearch.org/docs/latest/clients/agents-and-ingestion-tools/index/ is still not updated. |
This was referenced Jun 30, 2022
5 tasks
Closed
11 tasks
|
compatibility.override_main_response_version: true is supported v2.1.0 onwards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 199fbb8 which removed the
opensearch.http.override_main_response_versioncluster setting.The setting was originally added so users of legacy clients would not have to upgrade their client to begin using OpenSearch 1.x.
With 2.0 the REST API is further fragmented from legacy clients such that users are forced to upgrade to the latest OpenSearch client.
To reduce this friction OpenSearch is working on a REST API Versioning mechanism to support API compatibility with at least the legacy 7.x line; but this will not be ready until 2.2 at the earliest.
The immediate problem is that there is no OpenSearch version of Beats and Logstash and the upstream maintainers of these projects have no plans to support OpenSearch.
This has already lead to user pain regarding document type removal in beats which is alleviated by ignoring type removal in the bulk API and temporarily adding the docType endpoints back for certain REST APIs.
It is also leading to pain for users of different pipeline processor types in filebeat as these processors have explicit version checks for compatibility only with Elasticsearch.
To alleviate this pain, OpenSearch adds back the
opensearch.http.override_main_response_versionsetting so users of Beats and logstash can continue to function by spoofing the OpenSearch cluster version to7.10.2.