Create opensearch-dashboards-reports.release-notes-1.2.0.0.md #219

kavithacm · 2021-11-05T17:17:54Z

Description

Release notes for Opensearch-Dashboard-Reports V1.2.0

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov-commenter · 2021-11-05T17:25:22Z

Codecov Report

Merging #219 (f199e40) into main (ccdadcc) will decrease coverage by 10.56%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #219       +/-   ##
=============================================
- Coverage     63.57%   53.01%   -10.57%     
  Complexity      296      296               
=============================================
  Files            99       66       -33     
  Lines          4115     2126     -1989     
  Branches        628      242      -386     
=============================================
- Hits           2616     1127     -1489     
+ Misses         1357      860      -497     
+ Partials        142      139        -3

Flag	Coverage Δ
dashboards-reports	`?`
reports-scheduler	`53.01% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
dashboards-reports/server/model/backendModel.ts
...ions/report_settings/report_settings_constants.tsx
...report_definitions/delivery/delivery_constants.tsx
.../report_definitions/report_settings/time_range.tsx
dashboards-reports/public/components/main/main.tsx
...shboards-reports/public/components/utils/utils.tsx
dashboards-reports/server/model/index.ts
dashboards-reports/common/index.ts
...orts/server/routes/utils/converters/uiToBackend.ts
...ashboards-reports/server/utils/validationHelper.ts
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccdadcc...f199e40. Read the comment docs.

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

davidcui1225 · 2021-11-05T18:38:24Z

release-notes/opensearch-dashboards-reports.release-notes-1.2.0.0.md

@@ -0,0 +1,40 @@
+### **Version 1.2.0.0 Release Notes**


Is there an update in the 1.2 release notes to make the section titles in bold? Our past release notes don't have this style

I followed the Version 1.1.0.0 Release Notes title style which i thought was in bold so went with it. I'll change it

davidcui1225 · 2021-11-05T18:40:46Z

release-notes/opensearch-dashboards-reports.release-notes-1.2.0.0.md

+* Add logic to build report detail page link and send as part of message for non-email channels ([#182](https://github.com/opensearch-project/dashboards-reports/pull/182))
+* Forward all cookies while using headless Chromium ([#194](https://github.com/opensearch-project/dashboards-reports/pull/194))
+* Catch Notifications Errors on Details Pages ([#197](https://github.com/opensearch-project/dashboards-reports/pull/197))
+* Remove notifications integration from Details pages ([#210](https://github.com/opensearch-project/dashboards-reports/pull/210))


How come some of the PRs for removing notifications are in Infrastructure and others are in Enhancements? I feel they should all be in the same section

Shall i put all PRs for removing notifications under Infrastructure ?

I would say it should be under Infrastructure, thoughts @joshuali925 ?

we use infra to categorize CI/CD, pipeline, UT/IT changes. Not very sure what goes for removing notifications, maybe Refactoring? but it doesn't matter as much since notifications was added and removed, no changes for existing users, i'm ok with enhancements

joshuali925 · 2021-11-05T18:36:47Z

release-notes/opensearch-dashboards-reports.release-notes-1.2.0.0.md

@@ -0,0 +1,40 @@
+### **Version 1.2.0.0 Release Notes**


could you remove the **? I don't think we use this

Yeah i'll remove it

joshuali925 · 2021-11-05T18:38:31Z

release-notes/opensearch-dashboards-reports.release-notes-1.2.0.0.md

+### **Bug Fixes**
+* Fix quoting and url-encoding ([#153](https://github.com/opensearch-project/dashboards-reports/pull/153))
+* Remove hard coded localhost when calling API ([#172](https://github.com/opensearch-project/dashboards-reports/pull/172))
+* rename plugin helper config file name to consistent with OSD ([#180](https://github.com/opensearch-project/dashboards-reports/pull/180))


this is maintenance, it's to sync with upstream change

I'll change it

joshuali925 · 2021-11-05T18:39:50Z

release-notes/opensearch-dashboards-reports.release-notes-1.2.0.0.md

+* Taking RBAC settings from Alerting plugin default to false ([#165](https://github.com/opensearch-project/dashboards-reports/pull/165))
+* Integrate notifications backend ([#129](https://github.com/opensearch-project/dashboards-reports/pull/129))
+* Build email message from template with reports links ([#184](https://github.com/opensearch-project/dashboards-reports/pull/184))
+* Use advanced settings for date format in csv reports ([#186](https://github.com/opensearch-project/dashboards-reports/pull/186))
+* Remove Notifications from Create/Edit ([#212](https://github.com/opensearch-project/dashboards-reports/pull/212))
+* Remove calling notifications in reports scheduler ([#211](https://github.com/opensearch-project/dashboards-reports/pull/211))


i think you can put them all in Enhancements, infrastructure is mostly unit/integration tests related PRs

ohh got it. I'll change accordingly

joshuali925 · 2021-11-05T18:40:39Z

release-notes/opensearch-dashboards-reports.release-notes-1.2.0.0.md

+### **Maintenance**
+* Bump to version 1.2 ([#203](https://github.com/opensearch-project/dashboards-reports/pull/203))
+* Bump tmpl from 1.0.4 to 1.0.5 in /dashboards-reports ([#164](https://github.com/opensearch-project/dashboards-reports/pull/164))
+* Revert backend paths to opendistro  ([#218](https://github.com/opensearch-project/dashboards-reports/pull/218))


this is a bug fix

just the PR 218 right?

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

joshuali925 · 2021-11-05T21:23:47Z

release-notes/opensearch-dashboards-reports.release-notes-1.2.0.0.md

+
+
+### Infrastructure
+* Integrate notifications backend ([#129](https://github.com/opensearch-project/dashboards-reports/pull/129))


this is also part of adding notifications (which was then removed), could you also put in enhancements like others

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

joshuali925

lgtm

kavithacm closed this Nov 5, 2021

kavithacm reopened this Nov 5, 2021

Create opensearch-dashboards-reports.release-notes-1.2.0.0.md

54b4e6c

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

kavithacm force-pushed the 1.2-release-notes branch from d5a4b4a to 54b4e6c Compare November 5, 2021 17:53

kavithacm requested review from davidcui1225 and joshuali925 November 5, 2021 18:25

davidcui1225 reviewed Nov 5, 2021

View reviewed changes

joshuali925 reviewed Nov 5, 2021

View reviewed changes

changes

fe06fd0

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

kavithacm requested review from joshuali925 and davidcui1225 November 5, 2021 21:06

joshuali925 reviewed Nov 5, 2021

View reviewed changes

changes

f199e40

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

joshuali925 approved these changes Nov 5, 2021

View reviewed changes

kavithacm merged commit b686df8 into opensearch-project:main Nov 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create opensearch-dashboards-reports.release-notes-1.2.0.0.md #219

Create opensearch-dashboards-reports.release-notes-1.2.0.0.md #219

kavithacm commented Nov 5, 2021 •

edited

Loading

codecov-commenter commented Nov 5, 2021 •

edited

Loading

davidcui1225 Nov 5, 2021

kavithacm Nov 5, 2021

davidcui1225 Nov 5, 2021

kavithacm Nov 5, 2021

davidcui1225 Nov 5, 2021

joshuali925 Nov 5, 2021 •

edited

Loading

joshuali925 Nov 5, 2021

kavithacm Nov 5, 2021

joshuali925 Nov 5, 2021

kavithacm Nov 5, 2021

joshuali925 Nov 5, 2021

kavithacm Nov 5, 2021

joshuali925 Nov 5, 2021

kavithacm Nov 5, 2021

joshuali925 Nov 5, 2021

joshuali925 Nov 5, 2021

kavithacm Nov 5, 2021

joshuali925 left a comment



		### Infrastructure
		* Integrate notifications backend ([#129](https://github.com/opensearch-project/dashboards-reports/pull/129))

Create opensearch-dashboards-reports.release-notes-1.2.0.0.md #219

Create opensearch-dashboards-reports.release-notes-1.2.0.0.md #219

Conversation

kavithacm commented Nov 5, 2021 • edited Loading

Description

Issues Resolved

Check List

codecov-commenter commented Nov 5, 2021 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joshuali925 Nov 5, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joshuali925 left a comment

Choose a reason for hiding this comment

kavithacm commented Nov 5, 2021 •

edited

Loading

codecov-commenter commented Nov 5, 2021 •

edited

Loading

joshuali925 Nov 5, 2021 •

edited

Loading