Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create opensearch-dashboards-reports.release-notes-1.2.0.0.md #219

Merged
merged 3 commits into from
Nov 5, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
### **Version 1.2.0.0 Release Notes**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove the **? I don't think we use this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i'll remove it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an update in the 1.2 release notes to make the section titles in bold? Our past release notes don't have this style

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the Version 1.1.0.0 Release Notes title style which i thought was in bold so went with it. I'll change it

Compatible with OpenSearch and OpenSearch Dashboards Version 1.2.0

### **Bug Fixes**
* Fix quoting and url-encoding ([#153](https://github.com/opensearch-project/dashboards-reports/pull/153))
* Remove hard coded localhost when calling API ([#172](https://github.com/opensearch-project/dashboards-reports/pull/172))
* rename plugin helper config file name to consistent with OSD ([#180](https://github.com/opensearch-project/dashboards-reports/pull/180))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is maintenance, it's to sync with upstream change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change it

* Support range filters for csv reports ([#185](https://github.com/opensearch-project/dashboards-reports/pull/185))
* Fix Report Creation after Report Definition Creation ([#196](https://github.com/opensearch-project/dashboards-reports/pull/196))
* fix csv missing fields issue and empty csv on _source fields ([#206](https://github.com/opensearch-project/dashboards-reports/pull/206))


### **Infrastructure**
* Taking RBAC settings from Alerting plugin default to false ([#165](https://github.com/opensearch-project/dashboards-reports/pull/165))
* Integrate notifications backend ([#129](https://github.com/opensearch-project/dashboards-reports/pull/129))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also part of adding notifications (which was then removed), could you also put in enhancements like others

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah okay!

* Build email message from template with reports links ([#184](https://github.com/opensearch-project/dashboards-reports/pull/184))
* Use advanced settings for date format in csv reports ([#186](https://github.com/opensearch-project/dashboards-reports/pull/186))
* Remove Notifications from Create/Edit ([#212](https://github.com/opensearch-project/dashboards-reports/pull/212))
* Remove calling notifications in reports scheduler ([#211](https://github.com/opensearch-project/dashboards-reports/pull/211))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you can put them all in Enhancements, infrastructure is mostly unit/integration tests related PRs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh got it. I'll change accordingly



### **Enhancements**
* Add metrics for notifications ([#173](https://github.com/opensearch-project/dashboards-reports/pull/173))
* Add logic to build report detail page link and send as part of message for non-email channels ([#182](https://github.com/opensearch-project/dashboards-reports/pull/182))
* Forward all cookies while using headless Chromium ([#194](https://github.com/opensearch-project/dashboards-reports/pull/194))
* Catch Notifications Errors on Details Pages ([#197](https://github.com/opensearch-project/dashboards-reports/pull/197))
* Remove notifications integration from Details pages ([#210](https://github.com/opensearch-project/dashboards-reports/pull/210))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come some of the PRs for removing notifications are in Infrastructure and others are in Enhancements? I feel they should all be in the same section

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall i put all PRs for removing notifications under Infrastructure ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it should be under Infrastructure, thoughts @joshuali925 ?

Copy link
Member

@joshuali925 joshuali925 Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use infra to categorize CI/CD, pipeline, UT/IT changes. Not very sure what goes for removing notifications, maybe Refactoring? but it doesn't matter as much since notifications was added and removed, no changes for existing users, i'm ok with enhancements

* refactor logic for creating DSL from saved object using `buildOpensearchQuery()` ([#213](https://github.com/opensearch-project/dashboards-reports/pull/213))
* Use advanced settings for csv separator and visual report timezone ([#209](https://github.com/opensearch-project/dashboards-reports/pull/209))

### **Documentation**
* Update validation for observability notebooks integration ([#174](https://github.com/opensearch-project/dashboards-reports/pull/174))
* Add dco and release drafter workflows ([#217](https://github.com/opensearch-project/dashboards-reports/pull/217))
* update README notification section ([#216](https://github.com/opensearch-project/dashboards-reports/pull/216))

### **Maintenance**
* Bump to version 1.2 ([#203](https://github.com/opensearch-project/dashboards-reports/pull/203))
* Bump tmpl from 1.0.4 to 1.0.5 in /dashboards-reports ([#164](https://github.com/opensearch-project/dashboards-reports/pull/164))
* Revert backend paths to opendistro ([#218](https://github.com/opensearch-project/dashboards-reports/pull/218))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a bug fix

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the PR 218 right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right